public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Sander Vanheule <sander@svanheule.net>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>
Subject: [PATCH v3 3/5] regcache: flat: Remove unneeded check and error message for -ENOMEM
Date: Fri, 31 Oct 2025 09:03:18 +0100	[thread overview]
Message-ID: <20251031080540.3970776-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20251031080540.3970776-1-andriy.shevchenko@linux.intel.com>

There is a convention in the kernel to avoid error messages
in the cases of -ENOMEM errors. Besides that, the idea behind
using struct_size() and other macros from overflow.h is
to saturate the size that the following allocation call will
definitely fail, hence the check and the error messaging added
in regcache_flat_init() are redundant. Remove them.

Acked-by: Sander Vanheule <sander@svanheule.net>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/base/regmap/regcache-flat.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/base/regmap/regcache-flat.c b/drivers/base/regmap/regcache-flat.c
index 3b9235bb8313..bacb7137092f 100644
--- a/drivers/base/regmap/regcache-flat.c
+++ b/drivers/base/regmap/regcache-flat.c
@@ -30,7 +30,6 @@ struct regcache_flat_data {
 static int regcache_flat_init(struct regmap *map)
 {
 	int i;
-	size_t cache_data_size;
 	unsigned int cache_size;
 	struct regcache_flat_data *cache;
 
@@ -38,14 +37,7 @@ static int regcache_flat_init(struct regmap *map)
 		return -EINVAL;
 
 	cache_size = regcache_flat_get_index(map, map->max_register) + 1;
-	cache_data_size = struct_size(cache, data, cache_size);
-
-	if (cache_data_size == SIZE_MAX) {
-		dev_err(map->dev, "cannot allocate regmap cache");
-		return -ENOMEM;
-	}
-
-	cache = kzalloc(cache_data_size, map->alloc_flags);
+	cache = kzalloc(struct_size(cache, data, cache_size), map->alloc_flags);
 	if (!cache)
 		return -ENOMEM;
 
-- 
2.50.1


  parent reply	other threads:[~2025-10-31  8:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31  8:03 [PATCH v3 0/5] regcache: Split out ->populate() and use it Andy Shevchenko
2025-10-31  8:03 ` [PATCH v3 1/5] regcache: Add ->populate() callback to separate from ->init() Andy Shevchenko
2025-10-31 10:48   ` Charles Keepax
2025-10-31 12:49     ` Andy Shevchenko
2025-10-31  8:03 ` [PATCH v3 2/5] regcache: rbtree: Split ->populate() " Andy Shevchenko
2025-10-31 10:49   ` Charles Keepax
2025-10-31  8:03 ` Andy Shevchenko [this message]
2025-10-31 10:51   ` [PATCH v3 3/5] regcache: flat: Remove unneeded check and error message for -ENOMEM Charles Keepax
2025-10-31  8:03 ` [PATCH v3 4/5] regcache: flat: Split ->populate() from ->init() Andy Shevchenko
2025-10-31 10:52   ` Charles Keepax
2025-10-31  8:03 ` [PATCH v3 5/5] regcache: maple: " Andy Shevchenko
2025-10-31 10:53   ` Charles Keepax
2025-10-31 14:48 ` [PATCH v3 0/5] regcache: Split out ->populate() and use it Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251031080540.3970776-4-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dakr@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sander@svanheule.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox