From: Igor Reznichenko <igor@reznichenko.net>
To: krzk@kernel.org
Cc: conor+dt@kernel.org, corbet@lwn.net,
david.hunter.linux@gmail.com, devicetree@vger.kernel.org,
krzk+dt@kernel.org, linux-doc@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@roeck-us.net, robh@kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: Add support for ST TSC1641 power monitor
Date: Fri, 31 Oct 2025 10:30:28 -0700 [thread overview]
Message-ID: <20251031173029.904313-1-igor@reznichenko.net> (raw)
In-Reply-To: <35d41d46-5bc8-43af-a84d-6b118fff08e0@kernel.org>
>>> On 10/28/25 08:17, Igor Reznichenko wrote:
>>>> Understood. The bit in question controls the alert pin polarity on the device side,
>>>> independent of whether the pin is used as interrupt or not. I'll drop the property
>>>> for now and revisit if there's a board that actually uses an inverter or needs to
>>>> program the bit explicitly.
>>>>
>>>
>>> This is kind of unusual. The requirement used to be that devicetree properties
>>> shall be complete. "Only if there is a known use case" is a significant policy
>>> change. Has the policy changed recently ?
>>>
>>> Thanks,
>>> Guenter
>>
>> Rob, following up on Guenter's question above.
>> I'm not sure whether it's better to drop the property as discussed earlier or keep
>> it for binding completeness.
>> Could you clarify what approach is preferred?
>
>Don't you have there possibility of interrupt (not only SMBus Alert)? At
>least this is what I understood from previous talks.
Yes, the alert pin could be used as interrupt in principle.
Datasheet calls it "Multi-functional digital alert pin".
Thanks, Igor
next prev parent reply other threads:[~2025-10-31 17:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 4:47 [PATCH 0/5] hwmon: Add TSC1641 I2C power monitor driver Igor Reznichenko
2025-10-22 4:47 ` [PATCH 1/5] drivers/hwmon: " Igor Reznichenko
2025-10-22 14:51 ` Guenter Roeck
2025-10-23 7:50 ` Igor Reznichenko
2025-10-23 12:55 ` Guenter Roeck
2025-10-22 4:47 ` [PATCH 2/5] drivers/hwmon: Add Kconfig entry for TSC1641 Igor Reznichenko
2025-10-22 6:49 ` Krzysztof Kozlowski
2025-10-22 4:47 ` [PATCH 3/5] drivers/hwmon: Add TSC1641 module to Makefile Igor Reznichenko
2025-10-22 6:49 ` Krzysztof Kozlowski
2025-10-22 4:47 ` [PATCH 4/5] Documentation/hwmon: Add TSC1641 driver documentation Igor Reznichenko
2025-10-22 4:47 ` [PATCH 5/5] Documentation/devicetree/bindings/hwmon: Add TSC1641 binding Igor Reznichenko
2025-10-22 6:29 ` Rob Herring (Arm)
2025-10-22 6:48 ` Krzysztof Kozlowski
2025-10-22 14:07 ` [PATCH 0/5] hwmon: Add TSC1641 I2C power monitor driver Guenter Roeck
2025-10-26 6:50 ` [PATCH v2 0/2] " Igor Reznichenko
2025-10-26 6:50 ` [PATCH v2 1/2] dt-bindings: hwmon: Add support for ST TSC1641 power monitor Igor Reznichenko
2025-10-26 16:32 ` Krzysztof Kozlowski
2025-10-26 17:22 ` Guenter Roeck
2025-10-26 19:15 ` Krzysztof Kozlowski
2025-10-26 18:46 ` Igor Reznichenko
2025-10-26 19:41 ` Krzysztof Kozlowski
2025-10-26 19:58 ` Guenter Roeck
2025-10-27 8:40 ` Krzysztof Kozlowski
2025-10-27 16:53 ` Guenter Roeck
2025-10-27 18:01 ` Krzysztof Kozlowski
2025-10-27 19:14 ` Rob Herring
2025-10-28 15:17 ` Igor Reznichenko
2025-10-28 15:33 ` Guenter Roeck
2025-10-31 4:40 ` Igor Reznichenko
2025-10-31 7:57 ` Krzysztof Kozlowski
2025-10-31 17:30 ` Igor Reznichenko [this message]
2025-10-31 18:37 ` Guenter Roeck
2025-10-26 6:50 ` [PATCH v2 2/2] hwmon: Add TSC1641 I2C power monitor driver Igor Reznichenko
2025-10-26 17:08 ` Guenter Roeck
2025-10-27 6:41 ` Igor Reznichenko
2025-10-27 16:52 ` Guenter Roeck
2025-10-26 16:28 ` [PATCH v2 0/2] " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251031173029.904313-1-igor@reznichenko.net \
--to=igor@reznichenko.net \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=david.hunter.linux@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox