[PATCH 1/2] tools/nolibc: clean up outdated comments in generic arch.h

[PATCH 1/2] tools/nolibc: clean up outdated comments in generic arch.h

[Willy Tarreau]

Along the code reorganizations, the file has been keeping the original
comments about argv and envp which are no longer relevant to this file
anymore. Let's just drop them.
---
 tools/include/nolibc/arch.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/tools/include/nolibc/arch.h b/tools/include/nolibc/arch.h
index 426c89198135..0871c439be7d 100644
--- a/tools/include/nolibc/arch.h
+++ b/tools/include/nolibc/arch.h
@@ -3,15 +3,6 @@
  * Copyright (C) 2017-2022 Willy Tarreau <w@1wt.eu>
  */
 
-/* Below comes the architecture-specific code. For each architecture, we have
- * the syscall declarations and the _start code definition. This is the only
- * global part. On all architectures the kernel puts everything in the stack
- * before jumping to _start just above us, without any return address (_start
- * is not a function but an entry point). So at the stack pointer we find argc.
- * Then argv[] begins, and ends at the first NULL. Then we have envp which
- * starts and ends with a NULL as well. So envp=argv+argc+1.
- */
-
 #ifndef _NOLIBC_ARCH_H
 #define _NOLIBC_ARCH_H
 
-- 
2.17.5

Re: [PATCH 1/2] tools/nolibc: clean up outdated comments in generic arch.h

[Thomas Weißschuh]

On 2025-11-02 15:25:48+0100, Willy Tarreau wrote:
> Along the code reorganizations, the file has been keeping the original
> comments about argv and envp which are no longer relevant to this file
> anymore. Let's just drop them.
> ---
>  tools/include/nolibc/arch.h | 9 ---------
>  1 file changed, 9 deletions(-)

Thanks, applied.
FYI it seems patch 2 never got sent.


Thomas

Re: [PATCH 1/2] tools/nolibc: clean up outdated comments in generic arch.h

[Willy Tarreau]

On Sun, Nov 02, 2025 at 03:40:32PM +0100, Thomas Weißschuh wrote:
> On 2025-11-02 15:25:48+0100, Willy Tarreau wrote:
> > Along the code reorganizations, the file has been keeping the original
> > comments about argv and envp which are no longer relevant to this file
> > anymore. Let's just drop them.
> > ---
> >  tools/include/nolibc/arch.h | 9 ---------
> >  1 file changed, 9 deletions(-)
> 
> Thanks, applied.
> FYI it seems patch 2 never got sent.

Sorry, I now found how I messed up. There's indeed a single one (my
git format-patch command also took an experimental one that was on top
and not to be sent).

Thanks for picking them, that's always less patches in my local tree!
Willy