From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 138D11F4169 for ; Sun, 2 Nov 2025 17:06:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762103205; cv=none; b=tRh9jhKkdzkMCnZ8AGV99uy1Hn7u1LU4yH1aPiNo0Rfe5T+z0ellXdE9pC12q5tmG35nWsK3zsYyLOnvmzaRZyk30tVwMpBoWRBiKrIiG8JPqbOMd2lD1SBFwA/dSX/rIMCJah5YdfDfsJNhQjEkdZ7tcesWPnag6QD25AnObLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762103205; c=relaxed/simple; bh=oedeZmsFxLhCFl1kUSF9/KJ/zIF/AaWI2eynqQGqXh4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PLkqEECE4fNQl2quk01PLsj2N3fUOJ7EW79KCzwSTXeL355lplrzwm5f/pdy2UVomiJfjEmLjrjwd/sOyxbZMC6nFShcBVMRrtGDdYO3QrPUqVjK5lBXF52roDlod4RgxkJyHhjo1yfRE02RaNM6M/E2IkbKX7JR20um0q/Kw+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gL8puQUG; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gL8puQUG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762103203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KP4XinEpyvd8kaWWhUtBs6CxqYLY+EFwwqKCaZv/Q+U=; b=gL8puQUG2PxaMa95iJohbu51mNsYSyGK362eMsSHhlOgpan1Nl80F/YcBZDnP4P2WtSz78 yHt++fXEugeeH6LgkmwBOIPh0YsdDrfJq3FkjN8n/xiBxs39QNwyot3ew10VJctV8Q1DTb kcLjQ+D4TaymY7kqW7qG315GfvpU/Z4= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98--iPxFb9KM8WqsRCXT3-xOQ-1; Sun, 02 Nov 2025 12:06:07 -0500 X-MC-Unique: -iPxFb9KM8WqsRCXT3-xOQ-1 X-Mimecast-MFC-AGG-ID: -iPxFb9KM8WqsRCXT3-xOQ_1762103120 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BB6A619541B5; Sun, 2 Nov 2025 17:05:18 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.84]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id B31AD1800576; Sun, 2 Nov 2025 17:05:12 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 2 Nov 2025 18:04:01 +0100 (CET) Date: Sun, 2 Nov 2025 18:03:54 +0100 From: Oleg Nesterov To: Christian Brauner Cc: linux-fsdevel@vger.kernel.org, Amir Goldstein , Aleksa Sarai , Yu Watanabe , Josef Bacik , Jeff Layton , Jann Horn , Luca Boccassi , Alexander Mikhalitsyn , linux-kernel@vger.kernel.org, Alexander Viro , Jan Kara , Lennart Poettering , Mike Yuan , Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= Subject: Re: [PATCH 00/22] coredump: cleanups & pidfd extension Message-ID: <20251102170353.GA3837@redhat.com> References: <20251028-work-coredump-signal-v1-0-ca449b7b7aa0@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251028-work-coredump-signal-v1-0-ca449b7b7aa0@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 10/28, Christian Brauner wrote: > > Christian Brauner (22): > pidfs: use guard() for task_lock > pidfs: fix PIDFD_INFO_COREDUMP handling > pidfs: add missing PIDFD_INFO_SIZE_VER1 > pidfs: add missing BUILD_BUG_ON() assert on struct pidfd_info > pidfd: add a new supported_mask field > pidfs: prepare to drop exit_info pointer > pidfs: drop struct pidfs_exit_info > pidfs: expose coredump signal I don't think these changes need my review... but FWIW, I see nothing wrong in 1-8. For 1-8: Reviewed-by: Oleg Nesterov