* [PATCH] lib/crypto: arm, arm64: Drop filenames from file comments
@ 2025-11-02 1:48 Eric Biggers
2025-11-03 8:15 ` Ard Biesheuvel
2025-11-03 17:35 ` Eric Biggers
0 siblings, 2 replies; 4+ messages in thread
From: Eric Biggers @ 2025-11-02 1:48 UTC (permalink / raw)
To: linux-crypto
Cc: linux-kernel, Ard Biesheuvel, Jason A . Donenfeld, Herbert Xu,
Eric Biggers
Remove self-references to filenames from assembly files in
lib/crypto/arm/ and lib/crypto/arm64/. This follows the recommended
practice and eliminates an outdated reference to sha2-ce-core.S.
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
This patch is targeting libcrypto-next
lib/crypto/arm/sha1-armv7-neon.S | 2 +-
lib/crypto/arm/sha1-ce-core.S | 2 +-
lib/crypto/arm/sha256-ce.S | 2 +-
lib/crypto/arm64/sha1-ce-core.S | 2 +-
lib/crypto/arm64/sha256-ce.S | 2 +-
lib/crypto/arm64/sha512-ce-core.S | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/crypto/arm/sha1-armv7-neon.S b/lib/crypto/arm/sha1-armv7-neon.S
index 6edba3ab62e8..a0323fa5c58a 100644
--- a/lib/crypto/arm/sha1-armv7-neon.S
+++ b/lib/crypto/arm/sha1-armv7-neon.S
@@ -1,7 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
-/* sha1-armv7-neon.S - ARM/NEON accelerated SHA-1 transform function
+/* ARM/NEON accelerated SHA-1 transform function
*
* Copyright © 2013-2014 Jussi Kivilinna <jussi.kivilinna@iki.fi>
*/
#include <linux/linkage.h>
diff --git a/lib/crypto/arm/sha1-ce-core.S b/lib/crypto/arm/sha1-ce-core.S
index 2de40dd25e47..7d6b2631ca8d 100644
--- a/lib/crypto/arm/sha1-ce-core.S
+++ b/lib/crypto/arm/sha1-ce-core.S
@@ -1,8 +1,8 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/*
- * sha1-ce-core.S - SHA-1 secure hash using ARMv8 Crypto Extensions
+ * SHA-1 secure hash using ARMv8 Crypto Extensions
*
* Copyright (C) 2015 Linaro Ltd.
* Author: Ard Biesheuvel <ard.biesheuvel@linaro.org>
*/
diff --git a/lib/crypto/arm/sha256-ce.S b/lib/crypto/arm/sha256-ce.S
index 7481ac8e6c0d..144ee805f64a 100644
--- a/lib/crypto/arm/sha256-ce.S
+++ b/lib/crypto/arm/sha256-ce.S
@@ -1,8 +1,8 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/*
- * sha256-ce.S - SHA-224/256 secure hash using ARMv8 Crypto Extensions
+ * SHA-224/256 secure hash using ARMv8 Crypto Extensions
*
* Copyright (C) 2015 Linaro Ltd.
* Author: Ard Biesheuvel <ard.biesheuvel@linaro.org>
*/
diff --git a/lib/crypto/arm64/sha1-ce-core.S b/lib/crypto/arm64/sha1-ce-core.S
index 21efbbafd7d6..8fbd4767f0f0 100644
--- a/lib/crypto/arm64/sha1-ce-core.S
+++ b/lib/crypto/arm64/sha1-ce-core.S
@@ -1,8 +1,8 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/*
- * sha1-ce-core.S - SHA-1 secure hash using ARMv8 Crypto Extensions
+ * SHA-1 secure hash using ARMv8 Crypto Extensions
*
* Copyright (C) 2014 Linaro Ltd <ard.biesheuvel@linaro.org>
*/
#include <linux/linkage.h>
diff --git a/lib/crypto/arm64/sha256-ce.S b/lib/crypto/arm64/sha256-ce.S
index 410174ba5237..e4bfe42a61a9 100644
--- a/lib/crypto/arm64/sha256-ce.S
+++ b/lib/crypto/arm64/sha256-ce.S
@@ -1,8 +1,8 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/*
- * sha2-ce-core.S - core SHA-224/SHA-256 transform using v8 Crypto Extensions
+ * Core SHA-224/SHA-256 transform using v8 Crypto Extensions
*
* Copyright (C) 2014 Linaro Ltd <ard.biesheuvel@linaro.org>
*/
#include <linux/linkage.h>
diff --git a/lib/crypto/arm64/sha512-ce-core.S b/lib/crypto/arm64/sha512-ce-core.S
index 22f1ded89bc8..ffd51acfd1ee 100644
--- a/lib/crypto/arm64/sha512-ce-core.S
+++ b/lib/crypto/arm64/sha512-ce-core.S
@@ -1,8 +1,8 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
- * sha512-ce-core.S - core SHA-384/SHA-512 transform using v8 Crypto Extensions
+ * Core SHA-384/SHA-512 transform using v8 Crypto Extensions
*
* Copyright (C) 2018 Linaro Ltd <ard.biesheuvel@linaro.org>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
base-commit: 5a2a5e62a5216ba05d4481cf90d915f4de0bfde9
--
2.51.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] lib/crypto: arm, arm64: Drop filenames from file comments
2025-11-02 1:48 [PATCH] lib/crypto: arm, arm64: Drop filenames from file comments Eric Biggers
@ 2025-11-03 8:15 ` Ard Biesheuvel
2025-11-03 17:35 ` Eric Biggers
1 sibling, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2025-11-03 8:15 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-crypto, linux-kernel, Jason A . Donenfeld, Herbert Xu
On Sun, 2 Nov 2025 at 02:48, Eric Biggers <ebiggers@kernel.org> wrote:
>
> Remove self-references to filenames from assembly files in
> lib/crypto/arm/ and lib/crypto/arm64/. This follows the recommended
> practice and eliminates an outdated reference to sha2-ce-core.S.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> This patch is targeting libcrypto-next
>
> lib/crypto/arm/sha1-armv7-neon.S | 2 +-
> lib/crypto/arm/sha1-ce-core.S | 2 +-
> lib/crypto/arm/sha256-ce.S | 2 +-
> lib/crypto/arm64/sha1-ce-core.S | 2 +-
> lib/crypto/arm64/sha256-ce.S | 2 +-
> lib/crypto/arm64/sha512-ce-core.S | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> diff --git a/lib/crypto/arm/sha1-armv7-neon.S b/lib/crypto/arm/sha1-armv7-neon.S
> index 6edba3ab62e8..a0323fa5c58a 100644
> --- a/lib/crypto/arm/sha1-armv7-neon.S
> +++ b/lib/crypto/arm/sha1-armv7-neon.S
> @@ -1,7 +1,7 @@
> /* SPDX-License-Identifier: GPL-2.0-or-later */
> -/* sha1-armv7-neon.S - ARM/NEON accelerated SHA-1 transform function
> +/* ARM/NEON accelerated SHA-1 transform function
> *
> * Copyright © 2013-2014 Jussi Kivilinna <jussi.kivilinna@iki.fi>
> */
>
> #include <linux/linkage.h>
> diff --git a/lib/crypto/arm/sha1-ce-core.S b/lib/crypto/arm/sha1-ce-core.S
> index 2de40dd25e47..7d6b2631ca8d 100644
> --- a/lib/crypto/arm/sha1-ce-core.S
> +++ b/lib/crypto/arm/sha1-ce-core.S
> @@ -1,8 +1,8 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> /*
> - * sha1-ce-core.S - SHA-1 secure hash using ARMv8 Crypto Extensions
> + * SHA-1 secure hash using ARMv8 Crypto Extensions
> *
> * Copyright (C) 2015 Linaro Ltd.
> * Author: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> */
>
> diff --git a/lib/crypto/arm/sha256-ce.S b/lib/crypto/arm/sha256-ce.S
> index 7481ac8e6c0d..144ee805f64a 100644
> --- a/lib/crypto/arm/sha256-ce.S
> +++ b/lib/crypto/arm/sha256-ce.S
> @@ -1,8 +1,8 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> /*
> - * sha256-ce.S - SHA-224/256 secure hash using ARMv8 Crypto Extensions
> + * SHA-224/256 secure hash using ARMv8 Crypto Extensions
> *
> * Copyright (C) 2015 Linaro Ltd.
> * Author: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> */
>
> diff --git a/lib/crypto/arm64/sha1-ce-core.S b/lib/crypto/arm64/sha1-ce-core.S
> index 21efbbafd7d6..8fbd4767f0f0 100644
> --- a/lib/crypto/arm64/sha1-ce-core.S
> +++ b/lib/crypto/arm64/sha1-ce-core.S
> @@ -1,8 +1,8 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> /*
> - * sha1-ce-core.S - SHA-1 secure hash using ARMv8 Crypto Extensions
> + * SHA-1 secure hash using ARMv8 Crypto Extensions
> *
> * Copyright (C) 2014 Linaro Ltd <ard.biesheuvel@linaro.org>
> */
>
> #include <linux/linkage.h>
> diff --git a/lib/crypto/arm64/sha256-ce.S b/lib/crypto/arm64/sha256-ce.S
> index 410174ba5237..e4bfe42a61a9 100644
> --- a/lib/crypto/arm64/sha256-ce.S
> +++ b/lib/crypto/arm64/sha256-ce.S
> @@ -1,8 +1,8 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
> /*
> - * sha2-ce-core.S - core SHA-224/SHA-256 transform using v8 Crypto Extensions
> + * Core SHA-224/SHA-256 transform using v8 Crypto Extensions
> *
> * Copyright (C) 2014 Linaro Ltd <ard.biesheuvel@linaro.org>
> */
>
> #include <linux/linkage.h>
> diff --git a/lib/crypto/arm64/sha512-ce-core.S b/lib/crypto/arm64/sha512-ce-core.S
> index 22f1ded89bc8..ffd51acfd1ee 100644
> --- a/lib/crypto/arm64/sha512-ce-core.S
> +++ b/lib/crypto/arm64/sha512-ce-core.S
> @@ -1,8 +1,8 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> /*
> - * sha512-ce-core.S - core SHA-384/SHA-512 transform using v8 Crypto Extensions
> + * Core SHA-384/SHA-512 transform using v8 Crypto Extensions
> *
> * Copyright (C) 2018 Linaro Ltd <ard.biesheuvel@linaro.org>
> *
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License version 2 as
>
> base-commit: 5a2a5e62a5216ba05d4481cf90d915f4de0bfde9
> --
> 2.51.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lib/crypto: arm, arm64: Drop filenames from file comments
2025-11-02 1:48 [PATCH] lib/crypto: arm, arm64: Drop filenames from file comments Eric Biggers
2025-11-03 8:15 ` Ard Biesheuvel
@ 2025-11-03 17:35 ` Eric Biggers
2025-11-03 18:16 ` Eric Biggers
1 sibling, 1 reply; 4+ messages in thread
From: Eric Biggers @ 2025-11-03 17:35 UTC (permalink / raw)
To: linux-crypto
Cc: linux-kernel, Ard Biesheuvel, Jason A . Donenfeld, Herbert Xu
On Sat, Nov 01, 2025 at 06:48:06PM -0700, Eric Biggers wrote:
> Remove self-references to filenames from assembly files in
> lib/crypto/arm/ and lib/crypto/arm64/. This follows the recommended
> practice and eliminates an outdated reference to sha2-ce-core.S.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
>
> This patch is targeting libcrypto-next
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next
- Eric
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] lib/crypto: arm, arm64: Drop filenames from file comments
2025-11-03 17:35 ` Eric Biggers
@ 2025-11-03 18:16 ` Eric Biggers
0 siblings, 0 replies; 4+ messages in thread
From: Eric Biggers @ 2025-11-03 18:16 UTC (permalink / raw)
To: linux-crypto
Cc: linux-kernel, Ard Biesheuvel, Jason A . Donenfeld, Herbert Xu
On Mon, Nov 03, 2025 at 09:35:11AM -0800, Eric Biggers wrote:
> On Sat, Nov 01, 2025 at 06:48:06PM -0700, Eric Biggers wrote:
> > Remove self-references to filenames from assembly files in
> > lib/crypto/arm/ and lib/crypto/arm64/. This follows the recommended
> > practice and eliminates an outdated reference to sha2-ce-core.S.
> >
> > Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> > ---
> >
> > This patch is targeting libcrypto-next
>
> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next
>
> - Eric
Since I applied it after the SHA-3 series which moved sha3-ce-core.S
into lib/crypto/, I also folded in the same change to sha3-ce-core.S:
diff --git a/lib/crypto/arm64/sha3-ce-core.S b/lib/crypto/arm64/sha3-ce-core.S
index b62bd714839b..ace90b506490 100644
--- a/lib/crypto/arm64/sha3-ce-core.S
+++ b/lib/crypto/arm64/sha3-ce-core.S
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
- * sha3-ce-core.S - core SHA-3 transform using v8.2 Crypto Extensions
+ * Core SHA-3 transform using v8.2 Crypto Extensions
*
* Copyright (C) 2018 Linaro Ltd <ard.biesheuvel@linaro.org>
*
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-03 18:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-02 1:48 [PATCH] lib/crypto: arm, arm64: Drop filenames from file comments Eric Biggers
2025-11-03 8:15 ` Ard Biesheuvel
2025-11-03 17:35 ` Eric Biggers
2025-11-03 18:16 ` Eric Biggers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox