From: Jason Gunthorpe <jgg@ziepe.ca>
To: Mostafa Saleh <smostafa@google.com>
Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, robin.murphy@arm.com,
will@kernel.org, joro@8bytes.org, praan@google.com
Subject: Re: [PATCH v6 1/4] iommu/io-pgtable-arm: Remove arm_lpae_dump_ops()
Date: Mon, 3 Nov 2025 14:40:22 -0400 [thread overview]
Message-ID: <20251103184022.GF1204670@ziepe.ca> (raw)
In-Reply-To: <20251103123355.1769093-2-smostafa@google.com>
On Mon, Nov 03, 2025 at 12:33:49PM +0000, Mostafa Saleh wrote:
> At the moment, if the selftest fails it prints a lot of information
> about the page table (size, levels...) this requires access to many
> internals, which has to be exposed in the next patch moving the
> tests out.
>
> Instead, we can simplify the print to only print the fmt and
> for each test ias, oas and pgsize_bitmap are already printed.
> That is enough to identify the failed case, and the rest can
> be deduced from the code.
>
> Signed-off-by: Mostafa Saleh <smostafa@google.com>
> ---
> drivers/iommu/io-pgtable-arm.c | 41 ++++++++++++----------------------
> 1 file changed, 14 insertions(+), 27 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2025-11-03 18:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 12:33 [PATCH v6 0/4] Move io-pgtable-arm selftest to KUnit Mostafa Saleh
2025-11-03 12:33 ` [PATCH v6 1/4] iommu/io-pgtable-arm: Remove arm_lpae_dump_ops() Mostafa Saleh
2025-11-03 18:40 ` Jason Gunthorpe [this message]
2025-11-03 12:33 ` [PATCH v6 2/4] iommu/io-pgtable-arm: Move selftests to a separate file Mostafa Saleh
2025-11-03 12:33 ` [PATCH v6 3/4] iommu/io-pgtable-arm-selftests: Modularize the test Mostafa Saleh
2025-11-03 12:33 ` [PATCH v6 4/4] iommu/io-pgtable-arm-selftests: Use KUnit Mostafa Saleh
2025-11-13 9:48 ` [PATCH v6 0/4] Move io-pgtable-arm selftest to KUnit Will Deacon
2025-11-13 15:26 ` Jörg Rödel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103184022.GF1204670@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=praan@google.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox