From: Sumit Kumar <sumit.kumar@oss.qualcomm.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>,
Akhil Vinod <akhil.vinod@oss.qualcomm.com>,
Subramanian Ananthanarayanan
<subramanian.ananthanarayanan@oss.qualcomm.com>,
linux-kernel@vger.kernel.org, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, quic_vpernami@quicinc.com,
Sumit Kumar <sumit.kumar@oss.qualcomm.com>
Subject: [PATCH v2 3/3] bus: mhi: ep: Add loopback driver for data path testing
Date: Tue, 04 Nov 2025 11:09:07 +0530 [thread overview]
Message-ID: <20251104-loopback_mhi-v2-3-727a3fd9aa74@oss.qualcomm.com> (raw)
In-Reply-To: <20251104-loopback_mhi-v2-0-727a3fd9aa74@oss.qualcomm.com>
Add loopback driver for MHI endpoint devices. The driver receives
data on the uplink channel and echoes it back on the downlink
channel using a workqueue for asynchronous processing.
The driver is useful for testing MHI endpoint data path functionality
and debugging communication issues.
Co-developed-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Signed-off-by: Sumit Kumar <sumit.kumar@oss.qualcomm.com>
---
drivers/bus/mhi/ep/Kconfig | 8 +++
drivers/bus/mhi/ep/Makefile | 1 +
drivers/bus/mhi/ep/mhi_ep_loopback.c | 134 +++++++++++++++++++++++++++++++++++
3 files changed, 143 insertions(+)
diff --git a/drivers/bus/mhi/ep/Kconfig b/drivers/bus/mhi/ep/Kconfig
index 90ab3b040672e0f04181d4802e3062afcc7cf782..ce7b63c2da82a6ca49528517687f4910552c35bb 100644
--- a/drivers/bus/mhi/ep/Kconfig
+++ b/drivers/bus/mhi/ep/Kconfig
@@ -8,3 +8,11 @@ config MHI_BUS_EP
MHI_BUS_EP implements the MHI protocol for the endpoint devices,
such as SDX55 modem connected to the host machine over PCIe.
+
+config MHI_BUS_EP_LOOPBACK
+ tristate "MHI Endpoint loopback driver"
+ depends on MHI_BUS_EP
+ help
+ MHI endpoint loopback driver for data path testing.
+ This driver receives data on the uplink channel and echoes
+ it back on the downlink channel for testing purposes.
diff --git a/drivers/bus/mhi/ep/Makefile b/drivers/bus/mhi/ep/Makefile
index aad85f180b707fb997fcb541837eda9bbbb67437..02e4700e8dc3f860d40290476b0a852286683f8f 100644
--- a/drivers/bus/mhi/ep/Makefile
+++ b/drivers/bus/mhi/ep/Makefile
@@ -1,2 +1,3 @@
obj-$(CONFIG_MHI_BUS_EP) += mhi_ep.o
mhi_ep-y := main.o mmio.o ring.o sm.o
+obj-$(CONFIG_MHI_BUS_EP_LOOPBACK) += mhi_ep_loopback.o
diff --git a/drivers/bus/mhi/ep/mhi_ep_loopback.c b/drivers/bus/mhi/ep/mhi_ep_loopback.c
new file mode 100644
index 0000000000000000000000000000000000000000..ba6154dd9b785f051043c10a980ab340012ba986
--- /dev/null
+++ b/drivers/bus/mhi/ep/mhi_ep_loopback.c
@@ -0,0 +1,134 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include <linux/mhi_ep.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+
+struct mhi_ep_loopback {
+ struct workqueue_struct *loopback_wq;
+ struct mhi_ep_device *mdev;
+};
+
+struct mhi_ep_loopback_work {
+ struct mhi_ep_device *mdev;
+ struct work_struct work;
+ void *buf;
+ size_t len;
+};
+
+static void mhi_ep_loopback_work_handler(struct work_struct *work)
+{
+ struct mhi_ep_loopback_work *mhi_ep_lb_work = container_of(work,
+ struct mhi_ep_loopback_work, work);
+ int ret;
+
+ ret = mhi_ep_queue_buf(mhi_ep_lb_work->mdev, mhi_ep_lb_work->buf,
+ mhi_ep_lb_work->len);
+ if (ret) {
+ dev_err(&mhi_ep_lb_work->mdev->dev, "Failed to send the packet\n");
+ kfree(mhi_ep_lb_work->buf);
+ }
+
+ kfree(mhi_ep_lb_work);
+}
+
+static void mhi_ep_loopback_ul_callback(struct mhi_ep_device *mhi_dev,
+ struct mhi_result *mhi_res)
+{
+ struct mhi_ep_loopback *mhi_ep_lb = dev_get_drvdata(&mhi_dev->dev);
+ struct mhi_ep_loopback_work *mhi_ep_lb_work;
+ void *buf;
+
+ if (!(mhi_res->transaction_status)) {
+ buf = kmalloc(mhi_res->bytes_xferd, GFP_KERNEL);
+ if (!buf) {
+ dev_err(&mhi_dev->dev, "Failed to allocate buffer\n");
+ return;
+ }
+
+ memcpy(buf, mhi_res->buf_addr, mhi_res->bytes_xferd);
+
+ mhi_ep_lb_work = kmalloc(sizeof(*mhi_ep_lb_work), GFP_KERNEL);
+ if (!mhi_ep_lb_work) {
+ dev_err(&mhi_dev->dev, "Unable to allocate the work structure\n");
+ kfree(buf);
+ return;
+ }
+
+ INIT_WORK(&mhi_ep_lb_work->work, mhi_ep_loopback_work_handler);
+ mhi_ep_lb_work->mdev = mhi_dev;
+ mhi_ep_lb_work->buf = buf;
+ mhi_ep_lb_work->len = mhi_res->bytes_xferd;
+
+ queue_work(mhi_ep_lb->loopback_wq, &mhi_ep_lb_work->work);
+ }
+}
+
+static void mhi_ep_loopback_dl_callback(struct mhi_ep_device *mhi_dev,
+ struct mhi_result *mhi_res)
+{
+ void *buf;
+
+ if (mhi_res->transaction_status)
+ return;
+
+ buf = mhi_res->buf_addr;
+ if (buf)
+ kfree(buf);
+}
+
+static int mhi_ep_loopback_probe(struct mhi_ep_device *mhi_dev, const struct mhi_device_id *id)
+{
+ struct mhi_ep_loopback *mhi_ep_lb;
+
+ mhi_ep_lb = devm_kzalloc(&mhi_dev->dev, sizeof(struct mhi_ep_loopback), GFP_KERNEL);
+ if (!mhi_ep_lb)
+ return -ENOMEM;
+
+ mhi_ep_lb->loopback_wq = alloc_ordered_workqueue("mhi_loopback", WQ_MEM_RECLAIM);
+ if (!mhi_ep_lb->loopback_wq) {
+ dev_err(&mhi_dev->dev, "Failed to create workqueue.\n");
+ return -ENOMEM;
+ }
+
+ mhi_ep_lb->mdev = mhi_dev;
+ dev_set_drvdata(&mhi_dev->dev, mhi_ep_lb);
+
+ return 0;
+}
+
+static void mhi_ep_loopback_remove(struct mhi_ep_device *mhi_dev)
+{
+ struct mhi_ep_loopback *mhi_ep_lb = dev_get_drvdata(&mhi_dev->dev);
+
+ destroy_workqueue(mhi_ep_lb->loopback_wq);
+ dev_set_drvdata(&mhi_dev->dev, NULL);
+}
+
+static const struct mhi_device_id mhi_ep_loopback_id_table[] = {
+ { .chan = "LOOPBACK"},
+ {}
+};
+MODULE_DEVICE_TABLE(mhi, mhi_ep_loopback_id_table);
+
+static struct mhi_ep_driver mhi_ep_loopback_driver = {
+ .probe = mhi_ep_loopback_probe,
+ .remove = mhi_ep_loopback_remove,
+ .dl_xfer_cb = mhi_ep_loopback_dl_callback,
+ .ul_xfer_cb = mhi_ep_loopback_ul_callback,
+ .id_table = mhi_ep_loopback_id_table,
+ .driver = {
+ .name = "mhi_ep_loopback",
+ .owner = THIS_MODULE,
+ },
+};
+
+module_mhi_ep_driver(mhi_ep_loopback_driver);
+
+MODULE_AUTHOR("Krishna chaitanya chundru <krishna.chundru@oss.qualcomm.com>");
+MODULE_AUTHOR("Sumit Kumar <sumit.kumar@oss.qualcomm.com>");
+MODULE_DESCRIPTION("MHI Endpoint Loopback driver");
+MODULE_LICENSE("GPL");
--
2.34.1
next prev parent reply other threads:[~2025-11-04 5:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 5:39 [PATCH v2 0/3] bus: mhi: Add loopback driver Sumit Kumar
2025-11-04 5:39 ` [PATCH v2 1/3] bus: mhi: host: Add loopback driver with sysfs interface Sumit Kumar
2025-11-05 22:17 ` Bjorn Andersson
2025-11-07 12:28 ` Manivannan Sadhasivam
2025-11-10 4:00 ` Bjorn Andersson
2025-11-10 6:26 ` Manivannan Sadhasivam
2025-11-10 14:28 ` Bjorn Andersson
2025-11-04 5:39 ` [PATCH v2 2/3] bus: mhi: ep: Create mhi_ep_queue_buf API for raw buffer queuing Sumit Kumar
2025-11-05 22:20 ` Bjorn Andersson
2025-11-04 5:39 ` Sumit Kumar [this message]
2025-11-05 22:31 ` [PATCH v2 3/3] bus: mhi: ep: Add loopback driver for data path testing Bjorn Andersson
2025-11-09 22:40 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251104-loopback_mhi-v2-3-727a3fd9aa74@oss.qualcomm.com \
--to=sumit.kumar@oss.qualcomm.com \
--cc=akhil.vinod@oss.qualcomm.com \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=quic_vpernami@quicinc.com \
--cc=subramanian.ananthanarayanan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox