From: David Laight <david.laight.linux@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Guan-Chun Wu <409411716@gms.tku.edu.tw>,
Kuan-Wei Chiu <visitorckw@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] base64: Unroll the tables initialisers
Date: Tue, 4 Nov 2025 09:07:40 +0000 [thread overview]
Message-ID: <20251104090740.716dd95f@pumpkin> (raw)
In-Reply-To: <aQm2366wMJ1K1fp7@smile.fi.intel.com>
On Tue, 4 Nov 2025 10:18:39 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Mon, Nov 03, 2025 at 10:18:57PM +0000, David Laight wrote:
..
> > > + [BASE64_STD] = {
> > > + 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, /* 0 - 7 */
> >
> > You need to use -1 not 0xff.
>
> Whu? The s8 type is pretty much 8-bit, care to explain the point?
I think it is clang that complains that the value is out of range.
David
next prev parent reply other threads:[~2025-11-04 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 19:05 [PATCH v1 1/1] base64: Unroll the tables initialisers Andy Shevchenko
2025-11-03 19:17 ` Andy Shevchenko
2025-11-03 22:18 ` David Laight
2025-11-04 8:18 ` Andy Shevchenko
2025-11-04 9:07 ` David Laight [this message]
2025-11-04 9:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251104090740.716dd95f@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=409411716@gms.tku.edu.tw \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox