From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Joshua Washington <joshwash@google.com>,
Harshitha Ramamurthy <hramamurthy@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Simon Horman <horms@kernel.org>,
Willem de Bruijn <willemb@google.com>,
ziweixiao@google.com, Vedant Mathur <vedantmathur@google.com>
Subject: Re: [PATCH net v1 2/2] gve: use max allowed ring size for ZC page_pools
Date: Wed, 5 Nov 2025 17:11:42 -0800 [thread overview]
Message-ID: <20251105171142.13095017@kernel.org> (raw)
In-Reply-To: <20251105200801.178381-2-almasrymina@google.com>
On Wed, 5 Nov 2025 20:07:58 +0000 Mina Almasry wrote:
> NCCL workloads with NCCL_P2P_PXN_LEVEL=2 or 1 are very slow with the
> current gve devmem tcp configuration.
Hardcoding the ring size because some other attribute makes you think
that a specific application is running is rather unclean IMO..
Do you want me to respin the per-ring config series? Or you can take it over.
IDK where the buffer size config is after recent discussion but IIUC
it will not drag in my config infra so it shouldn't conflict.
next prev parent reply other threads:[~2025-11-06 1:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 20:07 [PATCH net v1 1/2] page_pool: expose max page pool ring size Mina Almasry
2025-11-05 20:07 ` [PATCH net v1 2/2] gve: use max allowed ring size for ZC page_pools Mina Almasry
2025-11-05 21:58 ` Jesper Dangaard Brouer
2025-11-05 22:44 ` Mina Almasry
2025-11-05 22:15 ` Harshitha Ramamurthy
2025-11-05 22:46 ` Mina Almasry
2025-11-06 1:11 ` Jakub Kicinski [this message]
2025-11-06 1:56 ` Mina Almasry
2025-11-06 2:22 ` Jakub Kicinski
2025-11-06 2:56 ` Mina Almasry
2025-11-06 17:25 ` Dragos Tatulea
2025-11-07 1:18 ` Jakub Kicinski
2025-11-07 13:35 ` Dragos Tatulea
2025-11-08 2:04 ` Jakub Kicinski
2025-11-05 21:56 ` [PATCH net v1 1/2] page_pool: expose max page pool ring size Jesper Dangaard Brouer
2025-11-05 22:56 ` Mina Almasry
2025-11-06 13:12 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105171142.13095017@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=ilias.apalodimas@linaro.org \
--cc=joshwash@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vedantmathur@google.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).