From: Hoyeon Lee <hoyeon.lee@suse.com>
To: ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org
Cc: Hoyeon Lee <hoyeon.lee@suse.com>,
andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com,
song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [bpf-next] selftests/bpf: refactor snprintf_btf test to use bpf_strncmp
Date: Thu, 6 Nov 2025 05:14:13 +0900 [thread overview]
Message-ID: <20251105201415.227144-1-hoyeon.lee@suse.com> (raw)
The netif_receive_skb BPF program used in snprintf_btf test still uses
a custom __strncmp. This is unnecessary as the bpf_strncmp helper is
available and provides the same functionality.
This commit refactors the test to use the bpf_strncmp helper, removing
the redundant custom implementation.
Signed-off-by: Hoyeon Lee <hoyeon.lee@suse.com>
---
.../selftests/bpf/progs/netif_receive_skb.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/tools/testing/selftests/bpf/progs/netif_receive_skb.c b/tools/testing/selftests/bpf/progs/netif_receive_skb.c
index 9e067dcbf607..186b8c82b9e6 100644
--- a/tools/testing/selftests/bpf/progs/netif_receive_skb.c
+++ b/tools/testing/selftests/bpf/progs/netif_receive_skb.c
@@ -31,19 +31,6 @@ struct {
__type(value, char[STRSIZE]);
} strdata SEC(".maps");
-static int __strncmp(const void *m1, const void *m2, size_t len)
-{
- const unsigned char *s1 = m1;
- const unsigned char *s2 = m2;
- int i, delta = 0;
-
- for (i = 0; i < len; i++) {
- delta = s1[i] - s2[i];
- if (delta || s1[i] == 0 || s2[i] == 0)
- break;
- }
- return delta;
-}
#if __has_builtin(__builtin_btf_type_id)
#define TEST_BTF(_str, _type, _flags, _expected, ...) \
@@ -69,7 +56,7 @@ static int __strncmp(const void *m1, const void *m2, size_t len)
&_ptr, sizeof(_ptr), _hflags); \
if (ret) \
break; \
- _cmp = __strncmp(_str, _expectedval, EXPECTED_STRSIZE); \
+ _cmp = bpf_strncmp(_str, EXPECTED_STRSIZE, _expectedval); \
if (_cmp != 0) { \
bpf_printk("(%d) got %s", _cmp, _str); \
bpf_printk("(%d) expected %s", _cmp, \
--
2.51.1
next reply other threads:[~2025-11-05 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 20:14 Hoyeon Lee [this message]
2025-11-05 22:22 ` [bpf-next] selftests/bpf: refactor snprintf_btf test to use bpf_strncmp Eduard Zingerman
2025-11-05 22:45 ` Alexei Starovoitov
2025-11-05 22:52 ` Eduard Zingerman
2025-11-05 23:33 ` Alexei Starovoitov
2025-11-05 23:37 ` Eduard Zingerman
2025-11-05 23:43 ` Alexei Starovoitov
2025-11-06 3:26 ` Hoyeon Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251105201415.227144-1-hoyeon.lee@suse.com \
--to=hoyeon.lee@suse.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox