From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A11CB757EA; Tue, 4 Nov 2025 22:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294952; cv=none; b=Zeu+J+ScxIp+/yGTx0NVz3Y8HxPRNIxVqZvl+FV1vFs3svULmPV6cuYVrUmclDlWmX0INIg4j7i/L5bnRLD6ZFVQ6Vp2nZ6j+CBtgd83beCM+V59BMNktPEvsbDhlVQviKQ75WZxov99ingdiqvDPgts1J+3qodiAnvNj9diPak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762294952; c=relaxed/simple; bh=aqlUNg0c596uHdeWTUDcu6EdnafDbwK2pjKj403x1Fo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pDSVLRceTuExCXkhkE5WI7T4W7c0xlwDFsvkgVWI9yKjMsEmLDCtzWpMLmqgzDTrEDsjABvOu6wQWuHKo+Cvi4Vd6opvXEh/pc9hYuHmOxR7hn0EdFnHdI6Ih8urN1S5kJtuDPDbFIWgo3OLy4CgB7UMFfzIm4yJVtryxrPEAZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=GFYjumT7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="GFYjumT7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1884C4CEF8; Tue, 4 Nov 2025 22:22:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1762294952; bh=aqlUNg0c596uHdeWTUDcu6EdnafDbwK2pjKj403x1Fo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GFYjumT7IDjptaa+VauHwXCHykC6cd3SeIip1xQ/bUH83S4u37qHbm7Zs2PqmPn86 V5r96lDUrCEXwsAFPwk46TSN0qQMdCbA0cGiM+dxaQUX6xgb87nZQxVZmfiksEqtDk 2KaCcglRLURC1P6ouRVVQP8i5YpqcNhJZKw4CL8k= Date: Wed, 5 Nov 2025 07:22:30 +0900 From: Greg Kroah-Hartman To: Danilo Krummrich Cc: Alexandre Courbot , Luis Chamberlain , Russ Weight , "Rafael J. Wysocki" , Alice Ryhl , David Airlie , Simona Vetter , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , Andreas Hindborg , Trevor Gross , linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH] firmware_loader: make RUST_FW_LOADER_ABSTRACTIONS select FW_LOADER Message-ID: <2025110555-purifier-veneering-d9e8@gregkh> References: <20251104-b4-select-rust-fw-v1-1-afea175dba22@nvidia.com> <2025110407-scouting-unpiloted-39f4@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Nov 04, 2025 at 03:48:10PM +0100, Danilo Krummrich wrote: > On Tue Nov 4, 2025 at 3:35 PM CET, Greg Kroah-Hartman wrote: > > On Tue, Nov 04, 2025 at 11:04:49PM +0900, Alexandre Courbot wrote: > >> diff --git a/drivers/base/firmware_loader/Kconfig b/drivers/base/firmware_loader/Kconfig > >> index 752b9a9bea03..15eff8a4b505 100644 > >> --- a/drivers/base/firmware_loader/Kconfig > >> +++ b/drivers/base/firmware_loader/Kconfig > >> @@ -38,7 +38,7 @@ config FW_LOADER_DEBUG > >> config RUST_FW_LOADER_ABSTRACTIONS > >> bool "Rust Firmware Loader abstractions" > >> depends on RUST > >> - depends on FW_LOADER=y > >> + select FW_LOADER > > > > Please no, select should almost never be used, it causes hard-to-debug > > issues. > > I agree that select can be very annoying at times, but in this case it seems to > be the correct thing to do? > > For instance for something like: > > config MY_DRIVER > depends on PCI > depends on DRM > select AUXILIARY_BUS > select FW_LOADER > > In this case MY_DRIVER is only available if PCI and DRM is enabled, which makes > sense, there is no reason to show users PCI and DRM drivers if both are > disabled. > > However, for things like AUXILIARY_BUS and FW_LOADER, I'd argue that they are > implementation details of the driver and should be selected if the driver is > selected. > > Otherwise, wouldn't we expect users to know implementation details of drivers > before being able to select them? Ah, good point, I guess this is something like a "feature" that a driver needs to work properly. Ok, no objection from me (other than agreeing that it needs to be split up as you already said.) thanks, greg k-h