Re: [PATCH net-next v15 01/15] dt-bindings: net: Introduce the ethernet-connector description

Maxime Chevallier
2025-11-13T08:10:50Z

Hi Andrew,

On 11/11/2025 04:34, Andrew Lunn wrote:
> On Thu, Nov 06, 2025 at 10:47:26AM +0100, Maxime Chevallier wrote:
>> The ability to describe the physical ports of Ethernet devices is useful
>> to describe multi-port devices, as well as to remove any ambiguity with
>> regard to the nature of the port.
>>
>> Moreover, describing ports allows for a better description of features
>> that are tied to connectors, such as PoE through the PSE-PD devices.
>>
>> Introduce a binding to allow describing the ports, for now with 2
>> attributes :
>>
>> - The number of lanes, which is a quite generic property that allows
>> differentating between multiple similar technologies such as BaseT1
>> and "regular" BaseT (which usually means BaseT4).
>
> You still use lanes here, but the implementation has moved on to
> pairs.
>
> Please add my Reviewed-by when you fix this.

I'm about to send v16, but I have also taken Rob's comments into account
so I'm going to err on the safe side and not include your review tag, in
case I mess this up :(

again, thanks a lot for the round of reviews on v15 !

Maxime

>
> Andrew