public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fernand Sieber <sieberf@amazon.com>
To: <peterz@infradead.org>
Cc: <aubrey.li@linux.intel.com>, <jstultz@google.com>,
	<linux-kernel@vger.kernel.org>, <lkp@intel.com>,
	<oe-lkp@lists.linux.dev>, <oliver.sang@intel.com>,
	<sieberf@amazon.com>, <x86@kernel.org>, <yu.c.chen@intel.com>
Subject: Re: [tip:sched/core] [sched/fair] 79104becf4: BUG:kernel_NULL_pointer_dereference,address
Date: Thu, 6 Nov 2025 12:54:01 +0200	[thread overview]
Message-ID: <20251106105401.220218-1-sieberf@amazon.com> (raw)
In-Reply-To: <20251105122808.GK988547@noisy.programming.kicks-ass.net>

Hi Peter,

> But yeah, if the task holding your resource is doing yield() you're
> 'sad'. Basically a sched-fair yield() means: I've no fucking clue what
> I'm doing and lets hope we can make progress a little later.
>
> And it gets worse in the context of PI/proxy, because in that case your
> fair task can deadlock the system through sheer incompetence.
>
> Anyway, consider the PI case, we bump a fair task to FIFO and then
> yield() would do the FIFO yield -- with all the possible problems.
>
> And we want the same for proxy, if the boosting context is FIFO, we want
> a FIFO yield.

Alright, makes sense. Based on your suggestion I've submitted a patch:
lore.kernel.org/lkml/20251106104022.195157-1-sieberf@amazon.com/T/#u

This is essentially the same as your suggestion + handling of yield to and
scx.

Also confirmed no crashes with this patch + v3 of the vruntime forfeit patch
https://lore.kernel.org/lkml/20250918150528.292620-1-sieberf@amazon.com/

--Fernand



Amazon Development Centre (South Africa) (Proprietary) Limited
29 Gogosoa Street, Observatory, Cape Town, Western Cape, 7925, South Africa
Registration Number: 2004 / 034463 / 07


  reply	other threads:[~2025-11-06 10:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21  5:14 [tip:sched/core] [sched/fair] 79104becf4: BUG:kernel_NULL_pointer_dereference,address kernel test robot
2025-10-21  6:39 ` Chen, Yu C
2025-10-21 11:04 ` Peter Zijlstra
2025-10-27 12:54   ` Peter Zijlstra
2025-10-27 13:14     ` Chen, Yu C
2025-10-27 13:55       ` Peter Zijlstra
2025-10-27 14:07         ` Peter Zijlstra
2025-10-27 14:09           ` Peter Zijlstra
2025-10-28  2:30             ` Chen, Yu C
2025-11-05 11:00               ` Peter Zijlstra
2025-11-05 12:06                 ` Philip Li
2025-11-07 10:16                   ` Philip Li
2025-11-07 10:53                     ` Peter Zijlstra
2025-11-04 21:04 ` Fernand Sieber
2025-11-05  8:43   ` Fernand Sieber
2025-11-05 11:03   ` Peter Zijlstra
2025-11-05 12:28   ` Peter Zijlstra
2025-11-06 10:54     ` Fernand Sieber [this message]
2025-11-06 23:57       ` John Stultz
2025-11-07  8:18         ` Fernand Sieber
  -- strict thread matches above, loose matches on Subject: below --
2025-11-06 10:40 [PATCH] sched: Proxy yields to donor tasks Fernand Sieber
2025-11-06 10:57 ` Peter Zijlstra
2025-11-07  6:54 ` kernel test robot
2025-11-07  8:12   ` Fernand Sieber
2025-11-07  8:25     ` Peter Zijlstra
2025-11-11 11:37 ` [tip: sched/core] sched/proxy: Yield the donor task tip-bot2 for Fernand Sieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251106105401.220218-1-sieberf@amazon.com \
    --to=sieberf@amazon.com \
    --cc=aubrey.li@linux.intel.com \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox