From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 615982F0C6D for ; Thu, 6 Nov 2025 11:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762427737; cv=none; b=TmvrAsQOGdbFPEVsgqkHCh/QtanX+rHRFjIw2wRb8mI3U6Q0EQZ5XODKuY9AD44ro4PXeIMOK11Z4rSL9d1X2nEb1QKv1l/gZ1XElsa9lXeE0R2nVa05yQWH/CDqfrsqUBzid49gtJJZ6VPA6BGmNUiSPm6gC9JwmA7KLtfnkJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762427737; c=relaxed/simple; bh=kJNhoJuafXThiXLHhXB4usAIFL4o51vmul0fN48lYe4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VxfZs6RYDwdE/40zEd+CWhxPNkpYnfZunqEkSEWhM4jrQ9aGi98fjewnuCdb5+raoVnSzLFP5Sa0AsqdbVMdviVQfFUCM30BD93zTPArIDJZx1Jt2OG1N3KuWaZ/lcZyrZXT1J5Y9WoiTMUb2Ec9EPb/YJPhMUtUkMXnjJizIHc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id EAEA9227A87; Thu, 6 Nov 2025 12:15:28 +0100 (CET) Date: Thu, 6 Nov 2025 12:15:28 +0100 From: Christoph Hellwig To: Alistair Francis Cc: Christoph Hellwig , hare@suse.de, kbusch@kernel.org, axboe@kernel.dk, sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Alistair Francis Subject: Re: [PATCH v2] nvmet-auth: update sc_c in target host hash calculation Message-ID: <20251106111528.GB31430@lst.de> References: <20251104231414.1150771-1-alistair.francis@wdc.com> <20251105132023.GC19044@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Nov 06, 2025 at 01:01:51PM +1000, Alistair Francis wrote: > We don't actually need this memset at all, it's a mistake from my > rebase, I'll drop it. > > Do you still want me to just directly pass req->sq->sc_c in? I think that's much cleaner. OTOH we might as well just merge your fix ASAP and clean this entire mess up later, so given that everything looks correct: Reviewed-by: Christoph Hellwig