Re: [PATCH 13/21] trace: don't use GENMASK()

Steven Rostedt
2025-10-25T19:36:29Z

On Sat, 25 Oct 2025 15:29:54 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Sat, 25 Oct 2025 12:32:55 -0400
> "Yury Norov (NVIDIA)" <yury.norov@gmail.com> wrote:
>
> > GENMASK(high, low) notation is confusing. FIRST_BITS() is more
> > appropriate.
> >
>
> I'm fine with this change as a clean up, but...
>
> > Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
> > ---
> > kernel/trace/fgraph.c | 10 +++++-----
> > kernel/trace/trace_probe.h | 2 +-
>
> Make this two different patches. trace_probe and fgraph go through
> different topic branches.

OK, I see this is part of a patch series that adds FIRST_BITS().

Please add that first, and the rest of the patches can go though their
individual trees. Something like this change I would like to make sure
doesn't accidentally cause a regression. That means it must go through
my tests before it gets applied.

-- Steve