From: Peter Korsgaard <peter@korsgaard.com>
To: javier.carrasco@wolfvision.net, heikki.krogerus@linux.intel.com,
neal@gompa.dev, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org
Cc: Peter Korsgaard <peter@korsgaard.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: typec: tipd: drop double register read in tps6598x_interrupt
Date: Thu, 6 Nov 2025 17:48:49 +0100 [thread overview]
Message-ID: <20251106164850.1703648-1-peter@korsgaard.com> (raw)
Commit 409c1cfb5a80 ("usb: typec: tipd: fix event checking for tps6598x")
added (by accident?) a double read of the TPS_REG_INT_EVENT1 register. Drop
that.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
drivers/usb/typec/tipd/core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 2b1049c9a6f3..2d4fcf62c200 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -994,8 +994,6 @@ static irqreturn_t tps6598x_interrupt(int irq, void *data)
TPS_VERSION_HW_VERSION(version) == TPS_VERSION_HW_65987_8_DK)
intev_len = TPS_65987_8_INTEVENT_LEN;
- ret = tps6598x_block_read(tps, TPS_REG_INT_EVENT1, event1, intev_len);
-
ret = tps6598x_block_read(tps, TPS_REG_INT_EVENT1, event1, intev_len);
if (ret) {
dev_err(tps->dev, "%s: failed to read event1\n", __func__);
--
2.39.5
next reply other threads:[~2025-11-06 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 16:48 Peter Korsgaard [this message]
2025-11-07 8:36 ` [PATCH] usb: typec: tipd: drop double register read in tps6598x_interrupt Greg KH
2025-11-07 15:03 ` Peter Korsgaard
2025-11-08 0:43 ` Greg KH
2025-11-10 8:16 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106164850.1703648-1-peter@korsgaard.com \
--to=peter@korsgaard.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=javier.carrasco@wolfvision.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neal@gompa.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox