From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21750303A35; Fri, 7 Nov 2025 06:54:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762498487; cv=none; b=advwr6sm7XrElGkCRe7RR4/Etgs6B89GaG5Zag0gmlr4zMUWHrlpYXN8t42p6KLz1cbi5TZNBXOzvAM9m3jnhlzWMpWfuJOrL1xeyJ1TnysjIp6Bhl64nMuis57dd7m87ZylRrKccPAcjAacUwd3tsaxKbvvoe92eTY/lgtL7H0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762498487; c=relaxed/simple; bh=baqHi0dMXDMwqcuZ0IiBEJFEHLA4yuvJjuO6eYSjQWo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mjrEbCUHpwQyIq8/cprJ21Af9WhgvZSiTOX4aFe2Kpv5gM8OWlV3StAfC1xrfyXx7TFoH53HOqgiDvcQ7onNIxUg30WN0B9brHW5nprcAp+4wFEGGwCD2PZdtTDf5xKnCLPRPPcoYNaPKgh/3cevnWf9czxBZPQQN5x+03vqFew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DZrHR959; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DZrHR959" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1762498487; x=1794034487; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=baqHi0dMXDMwqcuZ0IiBEJFEHLA4yuvJjuO6eYSjQWo=; b=DZrHR959oQgoCEHT8hrGDGwsRUvwvjKKsseYgfeKl6WSrILZyD0FO4S+ gPtAf3SJ2tdempoJCvtB84IoGRU1afhpsSs5FxI3631b0Rs7VKottbhgI 4LLPk8qrJngovP1057eSNaVU2QFu1gkBftUOuGl4DLxW6m47LI1upKy4+ 7k1ZY7rbKAOZYvztJT28sFFEQ8ZLYwluaPvCa7OoYGtnFs8piwlaD/68w lHxZk4xCfKxUiR4vgGCihyoPKuniuGpIAOTczrFlYuUyw9GaHYw7huzNb 1eN8S+5nVNrmrdMpWg318yUIQyGT81SitH3Ogl5kgzDP+5m+QZV9bBknD g==; X-CSE-ConnectionGUID: zxIt0QQZS/+vk5ThFv56uA== X-CSE-MsgGUID: NruOsacvQAmXZaO0JlRusA== X-IronPort-AV: E=McAfee;i="6800,10657,11531"; a="64552951" X-IronPort-AV: E=Sophos;i="6.17,312,1747724400"; d="scan'208";a="64552951" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2025 22:54:46 -0800 X-CSE-ConnectionGUID: izkHjS9MTA2yQuRLAk25jw== X-CSE-MsgGUID: rGfDkCzhQnura6ISz0qw7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,286,1754982000"; d="scan'208";a="193135607" Received: from lkp-server02.sh.intel.com (HELO 66d7546c76b2) ([10.239.97.151]) by orviesa005.jf.intel.com with ESMTP; 06 Nov 2025 22:54:44 -0800 Received: from kbuild by 66d7546c76b2 with local (Exim 4.96) (envelope-from ) id 1vHGMr-000Uoh-1h; Fri, 07 Nov 2025 06:54:41 +0000 Date: Fri, 7 Nov 2025 14:54:24 +0800 From: kernel test robot To: Artem Shimko , Mika Westerberg , Andy Shevchenko , Jan Dabros , Andi Shyti Cc: oe-kbuild-all@lists.linux.dev, Artem Shimko , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] i2c: designware: Replace magic numbers with named constants Message-ID: <202511071402.qHS6LLi9-lkp@intel.com> References: <20251106160206.2617785-1-a.shimko.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251106160206.2617785-1-a.shimko.dev@gmail.com> Hi Artem, kernel test robot noticed the following build errors: [auto build test ERROR on andi-shyti/i2c/i2c-host] [also build test ERROR on westeri-thunderbolt/next linus/master v6.18-rc4 next-20251107] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Artem-Shimko/i2c-designware-Replace-magic-numbers-with-named-constants/20251107-000812 base: https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host patch link: https://lore.kernel.org/r/20251106160206.2617785-1-a.shimko.dev%40gmail.com patch subject: [PATCH v2] i2c: designware: Replace magic numbers with named constants config: loongarch-randconfig-001-20251107 (https://download.01.org/0day-ci/archive/20251107/202511071402.qHS6LLi9-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 15.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251107/202511071402.qHS6LLi9-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202511071402.qHS6LLi9-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/i2c/busses/i2c-designware-common.c: In function 'i2c_dw_set_fifo_size': >> drivers/i2c/busses/i2c-designware-common.c:712:25: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration] 712 | tx_fifo_depth = FIELD_GET(DW_IC_FIFO_TX_FIELD, param) + 1; | ^~~~~~~~~ vim +/FIELD_GET +712 drivers/i2c/busses/i2c-designware-common.c 684 685 int i2c_dw_set_fifo_size(struct dw_i2c_dev *dev) 686 { 687 u32 tx_fifo_depth, rx_fifo_depth; 688 unsigned int param; 689 int ret; 690 691 /* DW_IC_COMP_PARAM_1 not implement for IP issue */ 692 if ((dev->flags & MODEL_MASK) == MODEL_WANGXUN_SP) { 693 dev->tx_fifo_depth = TXGBE_TX_FIFO_DEPTH; 694 dev->rx_fifo_depth = TXGBE_RX_FIFO_DEPTH; 695 696 return 0; 697 } 698 699 /* 700 * Try to detect the FIFO depth if not set by interface driver, 701 * the depth could be from 2 to 256 from HW spec. 702 */ 703 ret = i2c_dw_acquire_lock(dev); 704 if (ret) 705 return ret; 706 707 ret = regmap_read(dev->map, DW_IC_COMP_PARAM_1, ¶m); 708 i2c_dw_release_lock(dev); 709 if (ret) 710 return ret; 711 > 712 tx_fifo_depth = FIELD_GET(DW_IC_FIFO_TX_FIELD, param) + 1; 713 rx_fifo_depth = FIELD_GET(DW_IC_FIFO_RX_FIELD, param) + 1; 714 if (!dev->tx_fifo_depth) { 715 dev->tx_fifo_depth = tx_fifo_depth; 716 dev->rx_fifo_depth = rx_fifo_depth; 717 } else if (tx_fifo_depth >= DW_IC_FIFO_MIN_DEPTH) { 718 dev->tx_fifo_depth = min_t(u32, dev->tx_fifo_depth, 719 tx_fifo_depth); 720 dev->rx_fifo_depth = min_t(u32, dev->rx_fifo_depth, 721 rx_fifo_depth); 722 } 723 724 return 0; 725 } 726 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki