Re: [PATCH v3 1/3] fs: speed up path lookup with cheaper handling of MAY_EXEC

Mateusz Guzik
2025-11-11T10:51:31Z

On Tue, Nov 11, 2025 at 10:41 AM Christian Brauner <brauner@kernel.org> wrote:
>
> On Fri, Nov 07, 2025 at 03:21:47PM +0100, Mateusz Guzik wrote:
> > + if (unlikely(((inode->i_mode & 0111) != 0111) || !no_acl_inode(inode)))
>
> Can you send a follow-up where 0111 is a constant with some descriptive
> name, please? Can be local to the file. I hate these raw-coded
> permission masks with a passion.
>

#define UNIX_PERM_ALL_X 0111?

I have no opinion about hardcoding this vs using a macro, but don't
have a good name for that one either.