From: Thorsten Blum <thorsten.blum@linux.dev>
To: Krzysztof Kozlowski <krzk@kernel.org>, Huisong Li <lihuisong@huawei.com>
Cc: Thorsten Blum <thorsten.blum@linux.dev>, linux-kernel@vger.kernel.org
Subject: [PATCH] w1: therm: Use clamp_t to simplify int_to_short helper
Date: Sun, 9 Nov 2025 13:59:55 +0100 [thread overview]
Message-ID: <20251109130000.406691-1-thorsten.blum@linux.dev> (raw)
Use clamp_t() instead of manually casting the return value.
Replace sprintf() with sysfs_emit() to improve sysfs show functions
while we're at it.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/w1/slaves/w1_therm.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c
index 9ccedb3264fb..cf686e6ba3d5 100644
--- a/drivers/w1/slaves/w1_therm.c
+++ b/drivers/w1/slaves/w1_therm.c
@@ -961,9 +961,8 @@ static inline int temperature_from_RAM(struct w1_slave *sl, u8 rom[9])
*/
static inline s8 int_to_short(int i)
{
- /* Prepare to cast to short by eliminating out of range values */
- i = clamp(i, MIN_TEMP, MAX_TEMP);
- return (s8) i;
+ /* Cast to short by eliminating out of range values */
+ return clamp_t(s8, i, MIN_TEMP, MAX_TEMP);
}
/* Interface Functions */
@@ -1702,7 +1701,7 @@ static ssize_t temperature_show(struct device *device,
return 0;
}
- return sprintf(buf, "%d\n", temperature_from_RAM(sl, info.rom));
+ return sysfs_emit(buf, "%d\n", temperature_from_RAM(sl, info.rom));
}
static ssize_t ext_power_show(struct device *device,
@@ -1724,7 +1723,7 @@ static ssize_t ext_power_show(struct device *device,
"%s: Power_mode may be corrupted. err=%d\n",
__func__, SLAVE_POWERMODE(sl));
}
- return sprintf(buf, "%d\n", SLAVE_POWERMODE(sl));
+ return sysfs_emit(buf, "%d\n", SLAVE_POWERMODE(sl));
}
static ssize_t resolution_show(struct device *device,
@@ -1746,7 +1745,7 @@ static ssize_t resolution_show(struct device *device,
__func__, SLAVE_RESOLUTION(sl));
}
- return sprintf(buf, "%d\n", SLAVE_RESOLUTION(sl));
+ return sysfs_emit(buf, "%d\n", SLAVE_RESOLUTION(sl));
}
static ssize_t resolution_store(struct device *device,
@@ -1827,7 +1826,7 @@ static ssize_t alarms_show(struct device *device,
__func__, ret);
}
- return sprintf(buf, "%hd %hd\n", tl, th);
+ return sysfs_emit(buf, "%hd %hd\n", tl, th);
}
static ssize_t alarms_store(struct device *device,
@@ -1969,7 +1968,7 @@ static ssize_t therm_bulk_read_show(struct device *device,
}
}
show_result:
- return sprintf(buf, "%d\n", ret);
+ return sysfs_emit(buf, "%d\n", ret);
}
static ssize_t conv_time_show(struct device *device,
@@ -1982,7 +1981,7 @@ static ssize_t conv_time_show(struct device *device,
"%s: Device is not supported by the driver\n", __func__);
return 0; /* No device family */
}
- return sprintf(buf, "%d\n", conversion_time(sl));
+ return sysfs_emit(buf, "%d\n", conversion_time(sl));
}
static ssize_t conv_time_store(struct device *device,
@@ -2024,7 +2023,7 @@ static ssize_t features_show(struct device *device,
"%s: Device not supported by the driver\n", __func__);
return 0; /* No device family */
}
- return sprintf(buf, "%u\n", SLAVE_FEATURES(sl));
+ return sysfs_emit(buf, "%u\n", SLAVE_FEATURES(sl));
}
static ssize_t features_store(struct device *device,
--
2.51.1
next reply other threads:[~2025-11-09 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-09 12:59 Thorsten Blum [this message]
2025-11-09 16:20 ` [PATCH] w1: therm: Use clamp_t to simplify int_to_short helper David Laight
2025-11-09 20:30 ` Thorsten Blum
2025-11-09 23:07 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251109130000.406691-1-thorsten.blum@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=krzk@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox