Re: [PATCH v2 01/14] sched_ext: Don't set ddsp_dsq_id during select_cpu in bypass mode

Tejun Heo
2025-11-10T21:56:46Z

On Mon, Nov 10, 2025 at 10:56:23AM -1000, Tejun Heo wrote:
> @@ -2521,12 +2521,8 @@ static int select_task_rq_scx(struct task_struct *p, int prev_cpu, int wake_flag
> s32 cpu;
>
> cpu = scx_select_cpu_dfl(p, prev_cpu, wake_flags, NULL, 0);
> - if (cpu >= 0) {
> - refill_task_slice_dfl(sch, p);
> - p->scx.ddsp_dsq_id = SCX_DSQ_LOCAL;
> - } else {
> + if (cpu < 0)
> cpu = prev_cpu;
> - }

This isn't correct as local dispatch needs to happen when bypass is not
enabled and select_cpu() is not implemented. I'm dropping this patch for
now. The rest of the series applies fine and this doesn't really make any
meaningful difference.

Thanks.

--
tejun