Re: [PATCH v3 1/2] dt-bindings: riscv: spacemit: Add OrangePi R2S board

[Yixun Lan <dlan@gentoo.org>]

Hi All,

On 11:34 Tue 11 Nov     , Krzysztof Kozlowski wrote:
> On 11/11/2025 11:29, Michael Opdenacker wrote:
> > Greetings
> > 
> > Thanks one more time for the reviews!
> > 
> > On 11/11/25 11:13, Krzysztof Kozlowski wrote:
> >> On 11/11/2025 11:11, Yixun Lan wrote:
> >>> Hi Krzysztof,
> >>>
> >>> On 08:43 Tue 11 Nov     , Krzysztof Kozlowski wrote:
> >>>> On Mon, Nov 10, 2025 at 10:06:48PM +0000, michael.opdenacker@rootcommit.com wrote:
> >>>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> >>>>>
> >>>>> Document the compatible string for the OrangePi R2S board [1], which
> >>>>> is marketed as using the Ky X1 SoC but is in fact identical to
> >>> Maybe, just say it "same" to clarify the ambiguity?
> >> What is exactly "same"? Same die? Or same blocks/pieces? Whichever you
> >> choose please make it very explicit.
> > 
> > Maybe Troy Mitchell from Spacemit can shed light on this question.
> > 
> > Anyway, I could use the same wording as in this commit introducing 
> > "OrangePi RV2":
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch?id=bab8dea259100a99e047fd11a48940b229d30031
> > 
> > "The board is described as using the Ky X1 SoC, which, based on 
> > available downstream sources and testing, appears to be identical or 
> > very closely related to the SpacemiT K1 SoC".
sorry for bringing confusion in previous series, we had no further discussion on this..

> > 
> > What do you think?
> 
> This clearly suggests they are not identical thus you should have also
> dedicated compatible. Let me then precise, I thought it is obvious, that
> except writing it more detailed in commit msg, you also need proper
> binding expressing this. If this is not the same die and they look
> compatible, then usually it means you need a compatible.
> 

to be explicit, the Xy X1 has same die, same packaging as SpacemiT K1,
so we should not introduce new compatible in the SoC level, but a new
board compatible in patch [1/2] is ok to me

I hope this clarify this issue..

-- 
Yixun Lan (dlan)