Re: [PATCH v4 13/14] cxl/acpi: Group xor arithmetric setup code in a single block

Jonathan Cameron
2025-11-11T15:35:42Z

On Mon, 3 Nov 2025 19:47:54 +0100
Robert Richter <rrichter@amd.com> wrote:

> Simplify the xor arithmetric setup code by grouping it in a single
> block. No need to split the block for QoS setup.
>
> It is save to reorder the call of cxl_setup_extended_linear_cache()

safe rather than save

> because there are no dependencies.
>
> Signed-off-by: Robert Richter <rrichter@amd.com>
Seems fine to me.
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

> ---
> drivers/cxl/acpi.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> index 778ee29430ea..40894e2156ce 100644
> --- a/drivers/cxl/acpi.c
> +++ b/drivers/cxl/acpi.c
> @@ -449,8 +449,6 @@ static int __cxl_parse_cfmws(struct acpi_cedt_cfmws *cfmws,
> ig = CXL_DECODER_MIN_GRANULARITY;
> cxld->interleave_granularity = ig;
>
> - cxl_setup_extended_linear_cache(cxlrd);
> -
> if (cfmws->interleave_arithmetic == ACPI_CEDT_CFMWS_ARITHMETIC_XOR) {
> if (ways != 1 && ways != 3) {
> cxims_ctx = (struct cxl_cxims_context) {
> @@ -466,15 +464,14 @@ static int __cxl_parse_cfmws(struct acpi_cedt_cfmws *cfmws,
> return -EINVAL;
> }
> }
> - }
> -
> - cxlrd->qos_class = cfmws->qtg_id;
> -
> - if (cfmws->interleave_arithmetic == ACPI_CEDT_CFMWS_ARITHMETIC_XOR) {
> cxlrd->ops.hpa_to_spa = cxl_apply_xor_maps;
> cxlrd->ops.spa_to_hpa = cxl_apply_xor_maps;
> }
>
> + cxl_setup_extended_linear_cache(cxlrd);
> +
> + cxlrd->qos_class = cfmws->qtg_id;
> +
> rc = cxl_decoder_add(cxld);
> if (rc)
> return rc;