Re: [PATCH v4 10/14] cxl: Enable AMD Zen5 address translation using ACPI PRMT

Robert Richter
2025-11-13T11:24:21Z

On 11.11.25 15:30:49, Jonathan Cameron wrote:
> On Mon, 3 Nov 2025 19:47:51 +0100
> Robert Richter <rrichter@amd.com> wrote:

> > +void cxl_setup_prm_address_translation(struct cxl_root *cxl_root)
> > +{
> > + struct device *host = cxl_root->port.uport_dev;
> > + u64 spa;
> > + struct prm_cxl_dpa_spa_data data = { .spa = &spa, };
>
> Trailing comma is a tiny bit pointless as any change will have to replace
> the line anyway. So I'd drop it. (trivial so ignore if you like ;)

I have chosen the MIT comma here, but dropped it in v5. Are you
Cambridge or Oxford? ;)

https://xkcd.com/2995/

Thanks for your reviews.

-Robert