public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>,
	Marc Zyngier <maz@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>
Subject: [PATCH 2/3] clocksource/drivers/nxp-pit: Prevent driver unbind
Date: Tue, 11 Nov 2025 16:32:25 +0100	[thread overview]
Message-ID: <20251111153226.579-3-johan@kernel.org> (raw)
In-Reply-To: <20251111153226.579-1-johan@kernel.org>

The driver does not support unbinding (e.g. as clockevents cannot be
deregistered) so suppress the bind attributes to prevent the driver from
being unbound and rebound after registration (and disabling the timer
when reprobing fails).

Even if the driver can currently only be built-in, also switch to
builtin_platform_driver() to prevent it from being unloaded should
modular builds ever be enabled.

Fixes: bee33f22d7c3 ("clocksource/drivers/nxp-pit: Add NXP Automotive s32g2 / s32g3 support")
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/clocksource/timer-nxp-pit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-nxp-pit.c b/drivers/clocksource/timer-nxp-pit.c
index 2d0a3554b6bf..d1740f18f718 100644
--- a/drivers/clocksource/timer-nxp-pit.c
+++ b/drivers/clocksource/timer-nxp-pit.c
@@ -374,9 +374,10 @@ static struct platform_driver nxp_pit_driver = {
 	.driver = {
 		.name = "nxp-pit",
 		.of_match_table = pit_timer_of_match,
+		.suppress_bind_attrs = true,
 	},
 	.probe = pit_timer_probe,
 };
-module_platform_driver(nxp_pit_driver);
+builtin_platform_driver(nxp_pit_driver);
 
 TIMER_OF_DECLARE(vf610, "fsl,vf610-pit", pit_timer_init);
-- 
2.51.0


  parent reply	other threads:[~2025-11-11 15:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-11 15:32 [PATCH 0/3] clocksource/drivers: Prevent clockevent driver unbind Johan Hovold
2025-11-11 15:32 ` [PATCH 1/3] clocksource/drivers/arm_arch_timer_mmio: Prevent " Johan Hovold
2025-11-11 15:45   ` Marc Zyngier
2025-11-26 14:40   ` [tip: timers/clocksource] " tip-bot2 for Johan Hovold
2025-11-11 15:32 ` Johan Hovold [this message]
2025-11-12 10:00   ` [PATCH 2/3] clocksource/drivers/nxp-pit: " Daniel Lezcano
2025-11-12 11:01     ` Johan Hovold
2025-11-12 15:20       ` Daniel Lezcano
2025-11-26 14:40   ` [tip: timers/clocksource] " tip-bot2 for Johan Hovold
2025-11-11 15:32 ` [PATCH 3/3] clocksource/drivers/nxp-stm: " Johan Hovold
2025-11-26 14:40   ` [tip: timers/clocksource] " tip-bot2 for Johan Hovold
2025-11-12  9:48 ` [PATCH 0/3] clocksource/drivers: Prevent clockevent " Daniel Lezcano
2025-11-12 11:00   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251111153226.579-3-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox