From: SeongJae Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: SeongJae Park <sj@kernel.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>,
damon@lists.linux.dev, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 01/11] mm/damon/tests/core-kunit: remove dynamic allocs on damos_test_commit_filter()
Date: Tue, 11 Nov 2025 10:44:00 -0800 [thread overview]
Message-ID: <20251111184415.141757-2-sj@kernel.org> (raw)
In-Reply-To: <20251111184415.141757-1-sj@kernel.org>
damos_test_commit_filter() is dynamically allocating test-purpose DAMOS
filters. Allocation failure checks are making the code longer,
complicated, and difficult to extend for more test cases. Refactor the
code to remove the dynamic allocation.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/tests/core-kunit.h | 29 +++++++++++++----------------
1 file changed, 13 insertions(+), 16 deletions(-)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index 96a4cd489b39..ae97886137dc 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -499,23 +499,20 @@ static void damos_test_new_filter(struct kunit *test)
static void damos_test_commit_filter(struct kunit *test)
{
- struct damos_filter *src_filter, *dst_filter;
-
- src_filter = damos_new_filter(DAMOS_FILTER_TYPE_ANON, true, true);
- if (!src_filter)
- kunit_skip(test, "src filter alloc fail");
- dst_filter = damos_new_filter(DAMOS_FILTER_TYPE_ACTIVE, false, false);
- if (!dst_filter) {
- damos_destroy_filter(src_filter);
- kunit_skip(test, "dst filter alloc fail");
- }
- damos_commit_filter(dst_filter, src_filter);
- KUNIT_EXPECT_EQ(test, dst_filter->type, src_filter->type);
- KUNIT_EXPECT_EQ(test, dst_filter->matching, src_filter->matching);
- KUNIT_EXPECT_EQ(test, dst_filter->allow, src_filter->allow);
+ struct damos_filter src_filter = {
+ .type = DAMOS_FILTER_TYPE_ANON,
+ .matching = true,
+ .allow = true};
+ struct damos_filter dst_filter = {
+ .type = DAMOS_FILTER_TYPE_ACTIVE,
+ .matching = false,
+ .allow = false,
+ };
- damos_destroy_filter(src_filter);
- damos_destroy_filter(dst_filter);
+ damos_commit_filter(&dst_filter, &src_filter);
+ KUNIT_EXPECT_EQ(test, dst_filter.type, src_filter.type);
+ KUNIT_EXPECT_EQ(test, dst_filter.matching, src_filter.matching);
+ KUNIT_EXPECT_EQ(test, dst_filter.allow, src_filter.allow);
}
static void damos_test_filter_out(struct kunit *test)
--
2.47.3
next prev parent reply other threads:[~2025-11-11 18:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 18:43 [PATCH 00/11] mm/damon/tests: add more tests for online parameters commit SeongJae Park
2025-11-11 18:44 ` SeongJae Park [this message]
2025-11-11 18:44 ` [PATCH 02/11] mm/damon/tests/core-kunit: split out damos_test_commit_filter() core logic SeongJae Park
2025-11-11 18:44 ` [PATCH 03/11] mm/damon/tests/core-kunit: extend damos_test_commit_filter_for() for union fields SeongJae Park
2025-11-11 18:44 ` [PATCH 04/11] mm/damon/tests/core-kunit: add test cases to damos_test_commit_filter() SeongJae Park
2025-11-11 18:44 ` [PATCH 05/11] mm/damon/tests/core-kunit: add damos_commit_quota_goal() test SeongJae Park
2025-11-11 18:44 ` [PATCH 06/11] mm/damon/tests/core-kunit: add damos_commit_quota_goals() test SeongJae Park
2025-11-11 18:44 ` [PATCH 07/11] mm/damon/tests/core-kunit: add damos_commit_quota() test SeongJae Park
2025-11-11 18:44 ` [PATCH 08/11] mm/damon/core: pass migrate_dests to damos_commit_dests() SeongJae Park
2025-11-11 18:44 ` [PATCH 09/11] mm/damon/tests/core-kunit: add damos_commit_dests() test SeongJae Park
2025-11-11 18:44 ` [PATCH 10/11] mm/damon/tests/core-kunit: add damos_commit() test SeongJae Park
2025-11-11 18:44 ` [PATCH 11/11] mm/damon/tests/core-kunit: add damon_commit_target_regions() test SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251111184415.141757-2-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brendan.higgins@linux.dev \
--cc=damon@lists.linux.dev \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox