Re: [PATCH v4 12/26] genirq: Merge irqaction::{dev_id,percpu_dev_id}

Jonathan Cameron
2025-11-12T18:09:27Z

On Mon, 20 Oct 2025 13:29:29 +0100
Marc Zyngier <maz@kernel.org> wrote:

> When irqaction::percpu_dev_id was introduced, it was hoped that it
> could be part of an anonymous union with dev_id, as the two fields
> are mutually exclusive.
>
> However, toolchains used at the time were often showing terrible
> support for anonymous unions, breaking the build on a number of
> architectures. It was therefore decided to keep the two fields separate
> and address this down the line.
>
> 14 years later, the compiler dark age is over, and there is universal
> support for anonymous unions. Let's get a whole pointer back that can
> immediately be spent on something else.
>
> Tested-by: Will Deacon <will@kernel.org>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
I'm glad I either never saw that anon union problem or have blanked it from
my mind.

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>