Re: [PATCH v4 25/26] irqdomain: Kill of_node_to_fwnode() helper

Jonathan Cameron
2025-11-12T18:35:51Z

On Mon, 20 Oct 2025 13:29:42 +0100
Marc Zyngier <maz@kernel.org> wrote:

> There is no in-tree users of this helper since b13b41cc3dc18 ("misc:
> ti_fpc202: Switch to of_fwnode_handle()"), and is replaced with
> of_fwnode_handle().
>
> Get rid of it.
>
> Suggested-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> Tested-by: Will Deacon <will@kernel.org>
> Signed-off-by: Marc Zyngier <maz@kernel.org>

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
I didn't bother checking all the other removal patches but didn't see
anything wrong with them! Ripping code out is (usually) uncontroversial.

> ---
> include/linux/irqdomain.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
> index 9d6a5e99394fa..5907baf6099d9 100644
> --- a/include/linux/irqdomain.h
> +++ b/include/linux/irqdomain.h
> @@ -730,12 +730,6 @@ static inline void msi_device_domain_free_wired(struct irq_domain *domain, unsig
> }
> #endif
>
> -/* Deprecated functions. Will be removed in the merge window */
> -static inline struct fwnode_handle *of_node_to_fwnode(struct device_node *node)
> -{
> - return node ? &node->fwnode : NULL;
> -}
> -
> static inline struct irq_domain *irq_domain_add_tree(struct device_node *of_node,
> const struct irq_domain_ops *ops,
> void *host_data)