Re: [PATCH v4 14/26] genirq: Add affinity to percpu_devid interrupt requests

Marc Zyngier
2025-11-13T13:37:49Z

On Wed, 12 Nov 2025 18:13:18 +0000,
Jonathan Cameron <jonathan.cameron@huawei.com> wrote:
>
> On Mon, 20 Oct 2025 13:29:31 +0100
> Marc Zyngier <maz@kernel.org> wrote:
>
> > Add an affinity field to both the irqaction structure and the interrupt
> > request primitives. Nothing is making use of it yet, and the only value
> > used it NULL, which is used as a shorthand for cpu_possible_mask.
>
> used is NULL
>
> >
> > This will shortly get used with actual affinities.
> >
> > Tested-by: Will Deacon <will@kernel.org>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
>
> With trivial bit of documentation added
> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>
> > ---
> > include/linux/interrupt.h | 5 +++--
> > kernel/irq/manage.c | 14 ++++++++++----
> > 2 files changed, 13 insertions(+), 6 deletions(-)
> >
> > diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> > index 0ec1a71ab4e84..52147d5f432b3 100644
> > --- a/include/linux/interrupt.h
> > +++ b/include/linux/interrupt.h
> > @@ -125,6 +125,7 @@ struct irqaction {
> > void *dev_id;
> > void __percpu *percpu_dev_id;
> > };
> > + const struct cpumask *affinity;
>
> This structure has kernel-doc that needs an update.
>
> > struct irqaction *next;
> > irq_handler_t thread_fn;
> > struct task_struct *thread;

See 68c4c159a0db4 ("genirq: Fix percpu_devid irq affinity
documentation") in -next for the merged fix.

Thanks,

M.

--
Without deviation from the norm, progress is not possible.