Re: [PATCH 4/8] tools: Remove s390 compat support

Thomas Weißschuh
2025-11-13T15:54:03Z

On 2025-11-13 16:07:26+0100, Heiko Carstens wrote:
> Remove s390 compat support from everything within tools, since s390 compat
> support will be removed from the kernel.
>
> While removing s390 compat code replace __s390__ ifdef guards with
> __s390x__ everywhere. Even though this is not strictly required this
> makes it easier to spot s390 compat code support leftovers.
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
> .../arch/s390/include/uapi/asm/bitsperlong.h | 4 --

Wouldn't it make sense to emit an explicit error from the UAPI
headers if a user tries to use them in 31-bit mode?

> tools/lib/bpf/libbpf.c | 4 --
> tools/lib/bpf/usdt.c | 2 -

> tools/include/nolibc/arch-s390.h | 5 ---
> tools/include/nolibc/arch.h | 2 +-
> .../testing/selftests/nolibc/Makefile.nolibc | 5 ---
> tools/testing/selftests/nolibc/run-tests.sh | 6 +--

Acked-by: Thomas Weißschuh <linux@weissschuh.net> # tools/nolibc selftests/nolibc

> tools/testing/selftests/rseq/rseq-s390.h | 39 -------------------

> tools/testing/selftests/vDSO/vdso_config.h | 4 --

Reviewed-by: Thomas Weißschuh <linux@weissschuh.net> # selftests/vDSO

> 9 files changed, 2 insertions(+), 69 deletions(-)

(...)

Thomas