From: John Hubbard <jhubbard@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Edwin Peer" <epeer@nvidia.com>, "Zhi Wang" <zhiw@nvidia.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"John Hubbard" <jhubbard@nvidia.com>
Subject: [PATCH v8 4/6] gpu: nova-core: use ENOTSUPP for unsupported GPUs, in all cases
Date: Thu, 13 Nov 2025 18:41:07 -0800 [thread overview]
Message-ID: <20251114024109.465136-5-jhubbard@nvidia.com> (raw)
In-Reply-To: <20251114024109.465136-1-jhubbard@nvidia.com>
Some places in the driver use ENODEV for unsupported GPUs, while others
use ENOTSUPP. ENOTSUPP is more accurate, so change the ENODEV instances
to ENOTSUPP.
Cc: Alexandre Courbot <acourbot@nvidia.com>
Cc: Danilo Krummrich <dakr@kernel.org>
Cc: Timur Tabi <ttabi@nvidia.com>
Cc: Joel Fernandes <joelagnelf@nvidia.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
drivers/gpu/nova-core/gpu.rs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs
index c1eca052968b..aa8e881dd474 100644
--- a/drivers/gpu/nova-core/gpu.rs
+++ b/drivers/gpu/nova-core/gpu.rs
@@ -62,7 +62,7 @@ impl TryFrom<u32> for Chipset {
fn try_from(value: u32) -> Result<Self, Self::Error> {
match value {
$( $value => Ok(Chipset::$variant), )*
- _ => Err(ENODEV),
+ _ => Err(ENOTSUPP),
}
}
}
@@ -143,7 +143,7 @@ fn try_from(value: u8) -> Result<Self> {
0x16 => Ok(Self::Turing),
0x17 => Ok(Self::Ampere),
0x19 => Ok(Self::Ada),
- _ => Err(ENODEV),
+ _ => Err(ENOTSUPP),
}
}
}
--
2.51.2
next prev parent reply other threads:[~2025-11-14 2:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 2:41 [PATCH v8 0/6] gpu: nova: add boot42 support for next-gen GPUs John Hubbard
2025-11-14 2:41 ` [PATCH v8 1/6] gpu: nova-core: implement Display for Spec John Hubbard
2025-11-14 15:18 ` Alexandre Courbot
2025-11-14 2:41 ` [PATCH v8 2/6] gpu: nova-core: prepare Spec and Revision types for boot0/boot42 John Hubbard
2025-11-14 14:37 ` Alexandre Courbot
2025-11-15 0:49 ` John Hubbard
2025-11-14 2:41 ` [PATCH v8 3/6] gpu: nova-core: make Architecture behave as a u8 type John Hubbard
2025-11-14 2:41 ` John Hubbard [this message]
2025-11-14 15:03 ` [PATCH v8 4/6] gpu: nova-core: use ENOTSUPP for unsupported GPUs, in all cases Alexandre Courbot
2025-11-14 23:41 ` John Hubbard
2025-11-14 2:41 ` [PATCH v8 5/6] gpu: nova-core: add boot42 support for next-gen GPUs John Hubbard
2025-11-14 14:01 ` Alexandre Courbot
2025-11-15 0:10 ` John Hubbard
2025-11-14 2:41 ` [PATCH v8 6/6] gpu: nova-core: provide a clear error report for unsupported GPUs John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114024109.465136-5-jhubbard@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=epeer@nvidia.com \
--cc=gary@garyguo.net \
--cc=joelagnelf@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox