From: Phil Auld <pauld@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org,
Frederic Weisbecker <frederic@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
x86@kernel.org
Subject: Re: [tip: sched/core] sched: Increase sched_tick_remote timeout
Date: Fri, 14 Nov 2025 08:07:53 -0500 [thread overview]
Message-ID: <20251114130753.GA21708@pauld.westford.csb> (raw)
In-Reply-To: <176312274606.498.4882667650358877046.tip-bot2@tip-bot2>
On Fri, Nov 14, 2025 at 12:19:06PM -0000 tip-bot2 for Phil Auld wrote:
> The following commit has been merged into the sched/core branch of tip:
>
> Commit-ID: 2616d12247639da40339757adc08c822147aa993
> Gitweb: https://git.kernel.org/tip/2616d12247639da40339757adc08c822147aa993
> Author: Phil Auld <pauld@redhat.com>
> AuthorDate: Thu, 11 Sep 2025 12:13:00 -04:00
> Committer: Peter Zijlstra <peterz@infradead.org>
> CommitterDate: Fri, 14 Nov 2025 13:03:06 +01:00
>
Thanks Peter!
> sched: Increase sched_tick_remote timeout
>
> Increase the sched_tick_remote WARN_ON timeout to remove false
> positives due to temporarily busy HK cpus. The suggestion
> was 30 seconds to catch really stuck remote tick processing
> but not trigger it too easily.
>
> Suggested-by: Frederic Weisbecker <frederic@kernel.org>
> Signed-off-by: Phil Auld <pauld@redhat.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Acked-by: Frederic Weisbecker <frederic@kernel.org>
> Link: https://patch.msgid.link/20250911161300.437944-1-pauld@redhat.com
> ---
> kernel/sched/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 68f19aa..699db3f 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -5619,7 +5619,7 @@ static void sched_tick_remote(struct work_struct *work)
> * reasonable amount of time.
> */
> u64 delta = rq_clock_task(rq) - curr->se.exec_start;
> - WARN_ON_ONCE(delta > (u64)NSEC_PER_SEC * 3);
> + WARN_ON_ONCE(delta > (u64)NSEC_PER_SEC * 30);
> }
> curr->sched_class->task_tick(rq, curr, 0);
>
>
--
next prev parent reply other threads:[~2025-11-14 13:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 12:42 [PATCH] sched/core: Fix potential deadlock on rq lock Wang Tao
2025-09-11 13:53 ` Peter Zijlstra
2025-09-11 15:02 ` Frederic Weisbecker
2025-09-11 15:14 ` Phil Auld
2025-09-11 15:38 ` Frederic Weisbecker
2025-09-11 16:13 ` [PATCH] sched: Increase sched_tick_remote timeout Phil Auld
2025-09-11 16:29 ` Frederic Weisbecker
2025-09-17 6:26 ` wangtao (EQ)
2025-09-16 8:44 ` wangtao (EQ)
2025-09-16 12:49 ` Phil Auld
2025-09-23 10:47 ` Phil Auld
2025-10-10 12:13 ` Phil Auld
2025-11-03 21:56 ` Phil Auld
2025-11-14 12:19 ` [tip: sched/core] " tip-bot2 for Phil Auld
2025-11-14 13:07 ` Phil Auld [this message]
2025-11-17 16:23 ` tip-bot2 for Phil Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114130753.GA21708@pauld.westford.csb \
--to=pauld@redhat.com \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox