From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F0D61C01 for ; Fri, 14 Nov 2025 23:32:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763163129; cv=none; b=gimNLRwDUqveXtVTQ9eJmGZC3pzJZq4EQejve6XL4AzouMZrg1UHnOj9+VmcU4RybHbXWUS9WbGBuSIdI1x4TOrSX8pwTH0pBRTBcYsAf4EhcbFtDxQa8uh6GS8O4VKY8t0M6sZQ100FIVaR4d14na28pbuv+uDlpfyNtQ4hMMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763163129; c=relaxed/simple; bh=SoTFD8Opb4K0t99wfrk2kFa2zctifhwLmarh8UuTrEA=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=Kl0MEBbmj0FzrGrOuhVa0mb/e1qPfzHdVusKISsqnIOgLyZE2pWOImPhivSCMNYSacj5+jIJNzZiTnuESJ3hZ8pu2flWmR86Q+AfroPyBGxtiHDNKfreLUfU7DZcSRNgv2xapKADkk//zZGyGMWuZPFL1m7CGVNFmkSc7XlFEi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--ynaffit.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=tiFiNPIH; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--ynaffit.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tiFiNPIH" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-bc0de474d4eso5465102a12.0 for ; Fri, 14 Nov 2025 15:32:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763163126; x=1763767926; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=dgkun4FImuaBCa+EU4L7TF2efRgEadjeMwhhBvRSEJk=; b=tiFiNPIH74zV17T9N6QILhDkRiO7k8sqZcNFJU6ycm11PaRUVH04ruToEgZtn/JBH8 E+ylP3e8IgPhM2KUZF85QzoMFIK7zKmePUOBOsGa9qEpynPMeN/vYbPlMtPNOhSivfm9 LKzmAUpbrJsBNY9o2JG8xs/BArOgzE5YDzr8D9URu9XGNqeUbN+61Une2CejkAIPNDvw s0vIKYm3lVTws9GGjGPUKfeQrIWenSugBCLe96AMhzs2jUqOroPOO5rOdaZ75UT/k4My ebMnyj4D+JNtGJl8dW9JTV15N1wVIVKk5S6mfDyvXzVosLX7F+Ei8fPmfKmDIjYYRL+x dOsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763163126; x=1763767926; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dgkun4FImuaBCa+EU4L7TF2efRgEadjeMwhhBvRSEJk=; b=hJQiO5E7pEEbYHoykfqbZQLEoKNiTHixArXBbV3a9J8Ed11ugBwNSwFAVVJnLiKzD9 aV8R5O6AlvHl4o0Gx4z/NcPEZeFK2GQEgsLCKl06gIPqmzNdX7T6u/tv4VSF8NiTLitY aswKwzDRhuMGbx6E6cLrx4mFQVxEne+ZEFmlw8fHlIrq95JU8yBx/JoKuUo0yRa7fB9u TmVa4h6Rx8arisQjq8JHS3G0DpO20g6r8CsPA224VAk5QVeaIVRwCiCeCLmDZuO2SRWl hjMQi1cMEvokLzST2Z8I02KXJiPPoK1kVog3UENrGc0Rj6CVie7wpZJszePPyvdPPCb7 hQ/w== X-Gm-Message-State: AOJu0YzoJ5Fnd4cEgwq0B4g72Vmhv5/J6OllgL4z1TZV+iVGSIDe7auZ Q54thkWV/zeW78PsriSJQgkdN0iTfXS9kVp88Xf9HPAk0jU7lE8h12qzmBE/WMO0esWEe8CrPmF 5vEa4iEtd0YXJ7lD4KHVXd7GV5jPPIUCQuWOHkQ0KUfTs3k0KrsNsG8Sh1uTM0bH/n0Z7jhRhGB hj9I73SFa/BIy4snbkTpDnXfSNEfhIahZGfc1F53xWD7pT50TCRQ== X-Google-Smtp-Source: AGHT+IHga3e876Z6vtP6Vruzp/+pIt+9JMTZlndegTreRoSuvgzuAoE+gw7ko/+L/FFWrUuFad1wU8dMXOA2 X-Received: from dlbay43.prod.google.com ([2002:a05:7022:662b:b0:119:b185:ea6a]) (user=ynaffit job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:1305:b0:119:fa62:2672 with SMTP id a92af1059eb24-11b4130b889mr1317173c88.40.1763163126284; Fri, 14 Nov 2025 15:32:06 -0800 (PST) Date: Fri, 14 Nov 2025 15:31:51 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.rc1.455.g30608eb744-goog Message-ID: <20251114233150.396974-4-ynaffit@google.com> Subject: [PATCH 1/3] checkpatch: handle variables that begin with 'case' From: Tiffany Yang To: linux-kernel@vger.kernel.org Cc: kernel-team@android.com, Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn Content-Type: text/plain; charset="UTF-8" The current script returns switch statement-related errors when variables that start with "case" are used in a ternary. For example: ./scripts/checkpatch.pl --git d1934ed9803c ERROR: space prohibited before that ':' (ctx:WxW) #289: FILE: drivers/android/tests/binder_alloc_kunit.c:321: + case_failed ? "FAILED" : "PASSED", ^ ERROR: trailing statements should be on next line #289: FILE: drivers/android/tests/binder_alloc_kunit.c:321: + case_failed ? "FAILED" : "PASSED", Fix these false positives. Signed-off-by: Tiffany Yang --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 92669904eecc..b026b1235079 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2179,7 +2179,7 @@ sub annotate_values { $av_pending = 'E'; $type = 'N'; - } elsif ($cur =~/^(case)/o) { + } elsif ($cur =~/^(case)\b/o) { print "CASE($1)\n" if ($dbg_values > 1); $av_pend_colon = 'C'; $type = 'N'; @@ -5797,7 +5797,7 @@ sub process { $herecurr); } # case and default should not have general statements after them - if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g && + if ($line =~ /^.\s*(?:case\b\s*.*|default\s*):/g && $line !~ /\G(?: (?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$| \s*return\s+ -- 2.52.0.rc1.455.g30608eb744-goog