From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8715A1E4AB for ; Sun, 16 Nov 2025 06:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763274806; cv=none; b=I0ILAMrTz/Gl7Kp3jurxfoh7Ro9/MgUPzJ2KJgVnrnDrAag/X5efKQ3jdzXIHhwPdzmbifsD3nlZHNEcpqX9wxL0YKjJ8zb5cfNmvlOuJxeCcoxh5xN5tKBtbsHM2pCUFXqDR6zdG22iLv/cD4DTT8FyBPZz31UlUubmydfTIwU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763274806; c=relaxed/simple; bh=WURvRpuuk12XdsZYvcXdQ1i13F9ybXWwTkb2ajgBfZ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HnM7/RxlA+p1WgYdeeHyIAUrZLvyLIlKaXRfJ0ksqVPX8Wi/QPIgBNCc9ueOdiNOsmGO1o+1YUyw4ONFd8BV0gwDHSoD3X7mop08GLyfkWlDN+vY87cBM2vwSk7XUrDeCdXgjQ2m1m6ln0GSxeVWWyxQuTrIezmNtFv7SIJ8PYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=O62TuyOs; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=L640yfDl; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O62TuyOs"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="L640yfDl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763274803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i26Qsd4zcCbdcCUnhvn7MD8Ef78Ua9nu0uaADaCZAtc=; b=O62TuyOsGyIj9MukPVDSm7u1CbZvM/FFXcU6Gg9GKPfu9B0XR5NUNYdp/7gal5uo/959Yw dKCbqZD1ncLdNlz2PyGc8uHZrEOn1kjAQn/0iriLVXu2Cjn1SG57ZV9kP9mU7RV3nFVtnT FaeHfj+0vQQmIhVDUxG6ObcRFhlV31w= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-myrpAT2uM7aHa0sw5prm1w-1; Sun, 16 Nov 2025 01:33:21 -0500 X-MC-Unique: myrpAT2uM7aHa0sw5prm1w-1 X-Mimecast-MFC-AGG-ID: myrpAT2uM7aHa0sw5prm1w_1763274800 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-477a11d9f89so78765e9.3 for ; Sat, 15 Nov 2025 22:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1763274800; x=1763879600; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=i26Qsd4zcCbdcCUnhvn7MD8Ef78Ua9nu0uaADaCZAtc=; b=L640yfDlsGwb70C5Hx0iodmzHWoJdcOq/QatL6iXub/AIEquyaSDPfrqX6gAsL0gH0 g8yxrmxmi3kx2DsEQZQSAQqFPKeXp+p38pfytt4URUhBtxZghkrTx/i5rdTbDTWIh3z5 QuipZjgkQfQMkEN8TDpVBF0wLe7TIUsUIQf0P7T3fMFJFSqov07NOjttDtzYTXgZEDVF pIse28uYZXoXx9Ee4I2oU7MFDGSRkrHGtSKRoflAgrNMHY7U97v868A7CmKqjnrMdHiE oFO/Clr7fkBnASSkJiOW+MKCrRUqYHoNGxPefFjWT421++FNQiQC/IHJvNrbjm3tr+xC 1XRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763274800; x=1763879600; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i26Qsd4zcCbdcCUnhvn7MD8Ef78Ua9nu0uaADaCZAtc=; b=P+BaQOTF/LXgSrcUjDi+week9qUxLjR54S7KTaPaZBFn5pO9V11muoZkD4tDh9N9Cr nIecp/NVRho2EKw3x/X0MhxjpcZEdQIpn8K0phIDBMAQy8J02BdkO7TCJJRQO7meHTdt JuTSReF9/2XOEloE4TjgsLpXn9Y5a254QCLVAg9yBRxeUieBdLCKpiX1OJMoc3UX+nfB HowOEISpGLOOD9E2/X2ET8P0yV3CV7Yo+eVkrlsDUkkfXqJpMqxmB2Y+Wh0HvivAPW3Z NzNmd7w/d5hW2Nx8pOGdG4/9ugBe5w3gOCO8rB3S7s9C3wCMhVmYYmM2vPCN+cM/H8AH Wq3A== X-Gm-Message-State: AOJu0YxMIfb6Bm+26IxVOlsOyUlQXcmJcEs9lj28XUCETjY8C2nSYgTZ YWI+zbEHsKz33sLv+NlSiXtBWE57jzMhsqM0j9AFrD71jMq+NMrpy8/xJopNVQ/XMH+zjPvq9lV oAO5KesTERRTHYG8mwlVKiUIiZC3UM2m04ZIVj6nMCo+6RtxCZ2fuliFdev2VzQBLhQ== X-Gm-Gg: ASbGnctfDJKJXDOWtQOD5wMk0g1Lz9jnmMTxmUADZjNz2Uqgigwwict5/Lhm8ORAsHo z3lK6WVrh3A41HkpTC3PhA4iWnt/vxNMn2wNHBIvKfw+f15AcDbkiWWu14MZK9HDOauKj8DbdSh KvUwGqf676scLBjB4kWW/hq5Xt3lftNNtcUXrMHH5GDwS/JBwskqUcvsN8YgqUjTLC/SOwowFtn UGd5axBSbwaoSiRZMhLoWA/puEQ57LqRb5xEYrLCjxzLai7ZtB4KUP0HPRK0HazUMkFfwzFfFTC XQR5OSKHqiywl2ox8aecjDbXEOi8i21/FgrlH9khZlVHa4zhgWK/+sSmTdzCXWR6C2kCNG3bAkG 7UlqLsThBrXF0Oi7V75Y= X-Received: by 2002:a05:600c:3546:b0:477:e09:f0f with SMTP id 5b1f17b1804b1-4778fe60310mr85559835e9.8.1763274800416; Sat, 15 Nov 2025 22:33:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEJqXDNEPo7vrJ8jwAp5iZ9i1v+Q0rScb71Rsvl8FvHj8wP6hyFZpg1OUlCh2Wn2pVS/SsoyQ== X-Received: by 2002:a05:600c:3546:b0:477:e09:f0f with SMTP id 5b1f17b1804b1-4778fe60310mr85559695e9.8.1763274799990; Sat, 15 Nov 2025 22:33:19 -0800 (PST) Received: from redhat.com (IGLD-80-230-39-63.inter.net.il. [80.230.39.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47787e442c2sm244224345e9.7.2025.11.15.22.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 22:33:19 -0800 (PST) Date: Sun, 16 Nov 2025 01:33:17 -0500 From: "Michael S. Tsirkin" To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , virtualization@lists.linux.dev Subject: Re: [PATCH] virtio_ring: kernel-doc: fix function name, function param warnings Message-ID: <20251116013303-mutt-send-email-mst@kernel.org> References: <20251115224534.3832145-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251115224534.3832145-1-rdunlap@infradead.org> On Sat, Nov 15, 2025 at 02:45:33PM -0800, Randy Dunlap wrote: > Add description for the function parameter @vaddr. > Correct the function name in a kernel-doc comment. > > Fixes these warning: > WARNING: drivers/virtio/virtio_ring.c:3174 function parameter 'vaddr' not > described in 'virtqueue_map_free_coherent' > WARNING: drivers/virtio/virtio_ring.c:3308 expecting prototype for > virtqueue_mapping_error(). Prototype was for virtqueue_map_mapping_error() > instead > > Signed-off-by: Randy Dunlap Thanks, already fixed in my tree. > --- > Cc: "Michael S. Tsirkin" > Cc: Jason Wang > Cc: Xuan Zhuo > Cc: Eugenio Pérez > Cc: virtualization@lists.linux.dev > --- > drivers/virtio/virtio_ring.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- linux-next-20251114.orig/drivers/virtio/virtio_ring.c > +++ linux-next-20251114/drivers/virtio/virtio_ring.c > @@ -3166,6 +3166,7 @@ EXPORT_SYMBOL_GPL(virtqueue_map_alloc_co > * @vdev: the virtio device we are talking to > * @map: metadata for performing mapping > * @size: the size of the buffer > + * @vaddr: virtual address of the buffer > * @map_handle: the mapped address that needs to be freed > * > */ > @@ -3299,7 +3300,7 @@ void virtqueue_unmap_single_attrs(const > EXPORT_SYMBOL_GPL(virtqueue_unmap_single_attrs); > > /** > - * virtqueue_mapping_error - check dma address > + * virtqueue_map_mapping_error - check dma address > * @_vq: the struct virtqueue we're talking about. > * @addr: DMA address > *