From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C30D82D29C3 for ; Sun, 16 Nov 2025 12:13:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763295237; cv=none; b=jaNjJnvCLTJ8wQTQm8QcE+5zOzJbYpewWojpMxS6t+E4cRLAuQJ/YJy/utH3XxQrJJEOjEN/2mwIzh84X9SASvOmgM39JNWvYgszd5xgxQgdKL8vEVsN2UHDZdUECTUMdI2gSkegbMMolK1OCKuhWHLydv5e0QAzaKHd+8NQhCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763295237; c=relaxed/simple; bh=RUmslcAG3gb3srdtrytwbgQO16IRh0xf1qNDMkiLyYo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PKuf45uglhvnIgMOEMXFgVw7qXD/vW76IdO0qhLsqK4msIM8mD2kJf+dW8raYhjREt4d1OrWhgS4jXKRJGl5yt2FTfXGoQbkAzrzFyMr8YJ3DomKnwZWYjPEe+pDF9cJV1scQiZuY+Ws8gACVtidHxCGNRZkbCdF8C8tk5uT0YM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=u4rYmLtR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="u4rYmLtR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E839BC4CEF1; Sun, 16 Nov 2025 12:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1763295237; bh=RUmslcAG3gb3srdtrytwbgQO16IRh0xf1qNDMkiLyYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u4rYmLtR6OCQ5+5NiYDoZiLaUdYvo8SSoXqS8ChTu8LGxKB9ukMFIxZy6KgJDNlPe qWgStER2kT1nx4aQMwlM/gH+eOD7bKC0W+waJlbaYej8MiDafcutBh0dgj9rzFe4ic Aka9htxwYPXDnua/eJ2e2hhCsYRyNDhk6jfovyyA= Date: Sun, 16 Nov 2025 07:13:54 -0500 From: Greg Kroah-Hartman To: Rene Rebe Cc: Christoph Hellwig , Jens Axboe , "Martin K. Petersen" , Geoff Levand , linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] Fix ps3disk: use memcpy_{from,to}_bvec index Message-ID: <2025111611-spinout-blabber-0ae2@gregkh> References: <20251114.153033.430439310885688884.rene@exactco.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251114.153033.430439310885688884.rene@exactco.de> On Fri, Nov 14, 2025 at 03:30:33PM +0100, Rene Rebe wrote: > With 6e0a48552b8c (ps3disk: use memcpy_{from,to}_bvec) converting > ps3disk to new bvec helpers, incrementing the offset was accidently > lost, corrupting consecutive buffers. Restore index for non-corrupted > data transfers. > > Fixes: 6e0a48552b8c (ps3disk: use memcpy_{from,to}_bvec) > > Signed-off-by: René Rebe > > --- a/drivers/block/ps3disk.c 2023-08-07 17:40:55.200957746 +0200 > +++ b/drivers/block/ps3disk.c 2023-08-07 17:46:39.702964129 +0200 > @@ -85,10 +93,14 @@ > struct bio_vec bvec; > > rq_for_each_segment(bvec, req, iter) { > + dev_dbg(&dev->sbd.core, "%s:%u: %u sectors from %llu\n", > + __func__, __LINE__, bio_sectors(iter.bio), In the future, please note that all dev_dbg() calls have __func__ built into them, and I think __LINE__ as well, so there's no need to ever add that to the output. Take a look at the documentation for more details on how to see that in the log. thanks, greg k-h