public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>,
	larryw3i <larryw3i@yeah.net>,
	stable@vger.kernel.org, AlanSong-oc@zhaoxin.com,
	CobeChen@zhaoxin.com, GeorgeXue@zhaoxin.com, HansHu@zhaoxin.com,
	LeoLiu-oc@zhaoxin.com, TonyWWang-oc@zhaoxin.com,
	YunShen@zhaoxin.com
Subject: [PATCH] crypto: padlock-sha - Disable broken driver
Date: Sun, 16 Nov 2025 10:39:26 -0800	[thread overview]
Message-ID: <20251116183926.3969-1-ebiggers@kernel.org> (raw)
In-Reply-To: <3af01fec-b4d3-4d0c-9450-2b722d4bbe39@yeah.net>

This driver is known broken, as it computes the wrong SHA-1 and SHA-256
hashes.  Correctness needs to be the first priority for cryptographic
code.  Just disable it, allowing the standard (and actually correct)
SHA-1 and SHA-256 implementations to take priority.

Reported-by: larryw3i <larryw3i@yeah.net>
Closes: https://lore.kernel.org/r/3af01fec-b4d3-4d0c-9450-2b722d4bbe39@yeah.net/
Closes: https://lists.debian.org/debian-kernel/2025/09/msg00019.html
Closes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1113996
Cc: stable@vger.kernel.org
Cc: AlanSong-oc@zhaoxin.com
Cc: CobeChen@zhaoxin.com
Cc: GeorgeXue@zhaoxin.com
Cc: HansHu@zhaoxin.com
Cc: LeoLiu-oc@zhaoxin.com
Cc: TonyWWang-oc@zhaoxin.com
Cc: YunShen@zhaoxin.com
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---

This patch is targeting crypto/master

 drivers/crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index a6688d54984c..16ea3e741350 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -38,11 +38,11 @@ config CRYPTO_DEV_PADLOCK_AES
 	  If unsure say M. The compiled module will be
 	  called padlock-aes.
 
 config CRYPTO_DEV_PADLOCK_SHA
 	tristate "PadLock driver for SHA1 and SHA256 algorithms"
-	depends on CRYPTO_DEV_PADLOCK
+	depends on CRYPTO_DEV_PADLOCK && BROKEN
 	select CRYPTO_HASH
 	select CRYPTO_SHA1
 	select CRYPTO_SHA256
 	help
 	  Use VIA PadLock for SHA1/SHA256 algorithms.

base-commit: 59b0afd01b2ce353ab422ea9c8375b03db313a21
-- 
2.51.2


  reply	other threads:[~2025-11-16 18:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a1ed50c2-7338-4c97-8c36-84d2fa83d018@yeah.net>
2025-11-16 15:50 ` linux-image-amd64: self-tests for sha256 using sha256-padlock-nano failed larryw3i
2025-11-16 18:39   ` Eric Biggers [this message]
2025-11-17  9:03     ` [PATCH] crypto: padlock-sha - Disable broken driver AlanSong-oc
2025-11-17 10:08       ` larryw3i
2025-11-18  8:22         ` AlanSong-oc
2025-11-19  3:41           ` larryw3i
2025-11-18  3:34     ` Herbert Xu
2025-11-18  4:02       ` Eric Biggers
2025-12-17  4:30         ` AlanSong-oc
2025-12-17  4:56           ` Herbert Xu
2025-12-17  9:04             ` AlanSong-oc
2026-01-06 14:47               ` larryw3i

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251116183926.3969-1-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=AlanSong-oc@zhaoxin.com \
    --cc=CobeChen@zhaoxin.com \
    --cc=GeorgeXue@zhaoxin.com \
    --cc=HansHu@zhaoxin.com \
    --cc=LeoLiu-oc@zhaoxin.com \
    --cc=TonyWWang-oc@zhaoxin.com \
    --cc=YunShen@zhaoxin.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=larryw3i@yeah.net \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox