From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Akhilesh Patil <akhilesh@ee.iitb.ac.in>
Cc: andriy.shevchenko@intel.com, david.daney@cavium.com,
ddaney@caviumnetworks.com, david.hunter.linux@gmail.com,
skhan@linuxfoundation.org, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org, akhileshpatilvnit@gmail.com
Subject: Re: [PATCH] rtc: isl12026: Implement callbacks for alarm feature
Date: Sun, 16 Nov 2025 23:08:43 +0100 [thread overview]
Message-ID: <202511162208431d06192b@mail.local> (raw)
In-Reply-To: <20251116-51715-3266073@bhairav-test.ee.iitb.ac.in>
On 16/11/2025 10:47:15+0530, Akhilesh Patil wrote:
> > > static const struct rtc_class_ops isl12026_rtc_ops = {
> > > .read_time = isl12026_rtc_read_time,
> > > .set_time = isl12026_rtc_set_time,
> > > + .set_alarm = isl12026_rtc_set_alarm,
> > > + .read_alarm = isl12026_rtc_read_alarm,
> > > + .alarm_irq_enable = isl12026_rtc_alarm_irq_en,
> > > };
> > >
> >
> > This is missing an interrupt handler and proper handling in probe for
> > the wakeup-source property as this seems to be how you use it.
>
> Agree. However, I thought of first implementing alarm callbacks only and
> test them independedntly using ioctls for alarm settings in this patch.
> I will add interrupt handler and wakeup-source in v2 to complete this
> functionality.
Sure, the issue is that without interrupt handling and wakeup-source,
the driver will behave in a way that will break DT backward
compatibility later on.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2025-11-16 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-15 11:05 [PATCH] rtc: isl12026: Implement callbacks for alarm feature Akhilesh Patil
2025-11-15 11:24 ` Alexandre Belloni
2025-11-16 5:17 ` Akhilesh Patil
2025-11-16 22:08 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202511162208431d06192b@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=akhilesh@ee.iitb.ac.in \
--cc=akhileshpatilvnit@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=david.daney@cavium.com \
--cc=david.hunter.linux@gmail.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox