From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFF1531E0E6 for ; Mon, 17 Nov 2025 09:04:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763370265; cv=none; b=U7trU8xUZxlqv42w8JKQqF0UyIdHCIqHNFS3p0KuvHvZfgT10P1ffPyTLd+UT5PZ/7hW6E6NObPe1bSenCeeiD30o+sefi9MC9GRqkuUOE1B1lNeLzU07qNlr/oRuiS5AAf04QNiKU/wFitdVJYAzw2eaP1hztplyfSTdfcdMv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763370265; c=relaxed/simple; bh=NSG4vmX1Rk5OzSdVkKZf/U2bncKPRRHJC4jH6QsSl/w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Hg05l01oJUdI1nuknnjlwm4hf8H3Q+rYPQ+Qyge4kVrnEhX/2q7BgPNHOcM5+4LmNsDypmGEvtLft4/u+ljhf9rckQDyhBQ3+iuuxW45VZ9H9uGZqRR1VmjsQhDmYS0b0F66vyUaCGSk4h31Y2DQI2fQxNT2IXYaAON5Oy6J5GA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NXpG6vzg; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NXpG6vzg" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-378e8d10494so52450521fa.2 for ; Mon, 17 Nov 2025 01:04:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763370262; x=1763975062; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qjFvsbFPyFbyPgm+bw1kDJa74CcXAQQRLv+LVg1qWAo=; b=NXpG6vzgytKM1wOM8zB2OkTLCgqfgNRarlh6BZPwleE7W25HGsgAOcO5bp0gVg9/Dc dleBuXR8ns+h9q7fqC5gsRqMkmeH8twkSqhIIsmDjcgXSFTF2vla89tw1lpqgm4bzmd6 WWMCJk4rWWMnF8XYAFBlKr1a7mwnIqBzBl7wT41rU2vd2Orhu8C9NHpFZbwyXXjO3nYc d0Bu/548hd9CgO+OiqjOO+LrbvtTktV22a0hMi7CpYLcrQc+P33nQC5HLh+vjYBBtTn9 WePECA7M561d2BliD7QUJ2xzumq0qDJf4FRkAYIZXV4DFe2WZlR5qFT8vC7yuPXZI2bm Az7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763370262; x=1763975062; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=qjFvsbFPyFbyPgm+bw1kDJa74CcXAQQRLv+LVg1qWAo=; b=XUZVkmS0N7NvCbuW9+6ZTYkL5ejI9hrhMmQf/5nHXrbFXv450uLi0DYwORTp5ndeHk S6Qv5ZsQtnpe/LM58r7s81Q84NtsSh2M5Y3dyaNwyT0Ga/u1nXpu044ZuM0fKMzMSXQB C5xkMJoJ+hoOTMC3z3fBhe6MXUXvH9OROPUyLDC+7yNCsRkqH92q/ThcuHtRd/SzDN/p 75/FZoXq6/LAUdNFK607kqpgZlBeGGzzUMlPMBIhUQJxJZA9wgElc08hZETlfChdzLSU WyxttQeCi/nZcVfveU0gg8XMMKEKEFoLW6bEEHtTUb7NyQ8ZdReVPXK5t/SrtpJn9mVb H3aA== X-Forwarded-Encrypted: i=1; AJvYcCVMtabOOktJLRtbtvgKsGZKYy70qUGX80t/euV0zPRE6Ydm2wiiyeuae9640poKrHCndtqePG14MCJGOWY=@vger.kernel.org X-Gm-Message-State: AOJu0YxKWm0myeG7EgGcnHRNXI0ZHIP8Zwn5qxeJGem9pAH+jtSeaae+ H2lXizS0d2aUhmNZp9FHugckNALpWQrGQCQuWkFzQhDM+S9Ky4mp7DKt X-Gm-Gg: ASbGncv57AD/ZUt9Kp9cr7MbpvjFJgXjM1Mp4MjLUNw50YaexGUl1Ijdyx1hQGCnZsS wJAu62LY41nhThfokXYSB5La1Mnlha/t3diCQXrG66bbH7N4ytVt4ee8DMfRvCMg4JZemjWH+Y9 y+ymWkfM6vNK5LgU5kRVQpRBsHZ7Wd7JI8DL5ldIwSLafF3d0Dh7kL4ihtsQ4lv26GdK/3Xe+e7 yGlGw6fa1cVL21Hg93Es6VwjCMZQOdp0pCNzwmDxmtf9qXd8GG1HlxfayBcrL+rhU5FoxLO6KGb tzD6hi9+XXyQX8ZHTyhf81heoHwGmeSu043xEq1hIq0xe8YJQwTsTStzwBop6fI+Cno0jSDpDO9 YHl7WV6skfgw+uLp2zx5qnIys0GNVvUwbc6GxwtM0yQWaD3F/TMAZ4JLW2zeKn+4OcEckrlsOI1 bj3N/oPrZb8yZzGjH5r9742HcThXatZKANr3t9oQzNP35r6t1x3dD6cGD7 X-Google-Smtp-Source: AGHT+IEc1+Wzn8iDtJyi139bcvAwyCv3NlECHhkgxUDEIaUok8sSJJX5SnGL/8lmpJwV0yXlr7kWZQ== X-Received: by 2002:a2e:781a:0:b0:37a:47a4:d5cc with SMTP id 38308e7fff4ca-37babbedb40mr26961621fa.36.1763370261853; Mon, 17 Nov 2025 01:04:21 -0800 (PST) Received: from [192.168.1.168] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-595803b77e5sm2982498e87.42.2025.11.17.01.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 01:04:21 -0800 (PST) From: Marcus Folkesson Date: Mon, 17 Nov 2025 10:03:44 +0100 Subject: [PATCH RESEND v2 2/6] drm/sitronix/st7571-i2c: add 'struct device' to st7571_device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251117-st7571-split-v2-2-13189da95265@gmail.com> References: <20251117-st7571-split-v2-0-13189da95265@gmail.com> In-Reply-To: <20251117-st7571-split-v2-0-13189da95265@gmail.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Marcus Folkesson X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4428; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=NSG4vmX1Rk5OzSdVkKZf/U2bncKPRRHJC4jH6QsSl/w=; b=owEBbQKS/ZANAwAKAYiATm9ZXVIyAcsmYgBpGuT6zMXa+2W4BK6Lf7Yd6Boq3M2uqDbnEqpAT enxgYUGENqJAjMEAAEKAB0WIQQFUaLotmy1TWTBLGWIgE5vWV1SMgUCaRrk+gAKCRCIgE5vWV1S Mr2KD/46ZbwdwMJIZV6HDIcDxtJK7CRJ7fGjSj3YqqKzSW7xZEhvd6iMYLMqtk7l7vw6BFoOWYr /y2Y2N1r7oa0mpZhkADfb5WU8z8BFlNKiFnrTdLNxk8C7bajJMf4Or8JmjeU60m04J+ANQhxLKt rL4YUcWaXECJpxWa9rVu7kbWJ6yOYlPxct5nF1qLQpyXvWzFPTudddFCTr3EWRa8cM2HNDvPwg6 R7YcjsaqLXxV8JilkAhIawPyC/nWNVS12h85gU8AkDjQ6g0+xfa2vPmJHH1vU9PdV1/Kod7S635 cjJZ8WXBsifpX4ptvNn1Y0BDndy/9P5RtDn6qbPTYsOz8Pj1/uxtCMNC3jTWrQCWn06/xsqs9Br UcjX+WjYLxiboaI8GFDCCRchIIGFjjAURwzc5tvGfyUO7wFUSqqH3XUiSg+XGI7uz4j31ypjUlB 5yk93K/EEbFBeVcAUFSzQNbbnMyZg5np0bWcb7FBc2NtI0vslRxW5AepmhBQDZPDxGaJALB1VPY 2bdN1de/mEsb9XgAtmWc5qqZagBgmTYgtJoEUoxW3Rlf75p0H3tsqJAVNdSzfNCnp8vrpT2lnzV 8pQ/7meOYDY0kq0bS7WfeD8zioIrLJCf3umaDmrqscihLzwpzbNP4+y5S50F6seVGj18kSrZ/tK Ef4xBVEplDeALmA== X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 Keep a copy of the device structure instead of referring to i2c_client. This is a preparation step to separate the generic part from all i2c stuff. Signed-off-by: Marcus Folkesson --- drivers/gpu/drm/sitronix/st7571-i2c.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitronix/st7571-i2c.c index 71814a3eb93b..2b52919d7dd4 100644 --- a/drivers/gpu/drm/sitronix/st7571-i2c.c +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c @@ -113,6 +113,7 @@ struct st7571_panel_format { struct st7571_device { struct drm_device drm; + struct device *dev; struct drm_plane primary_plane; struct drm_crtc crtc; @@ -741,7 +742,7 @@ static const struct regmap_config st7571_regmap_config = { static int st7571_validate_parameters(struct st7571_device *st7571) { - struct device *dev = st7571->dev.dev; + struct device *dev = st7571->dev; const struct st7571_panel_constraints *constraints = &st7571->pdata->constraints; if (st7571->width_mm == 0) { @@ -781,7 +782,7 @@ static int st7571_validate_parameters(struct st7571_device *st7571) static int st7567_parse_dt(struct st7571_device *st7567) { - struct device *dev = &st7567->client->dev; + struct device *dev = st7567->dev; struct device_node *np = dev->of_node; struct display_timing dt; int ret; @@ -808,7 +809,7 @@ static int st7567_parse_dt(struct st7571_device *st7567) static int st7571_parse_dt(struct st7571_device *st7571) { - struct device *dev = &st7571->client->dev; + struct device *dev = st7571->dev; struct device_node *np = dev->of_node; struct display_timing dt; int ret; @@ -943,9 +944,10 @@ static int st7571_probe(struct i2c_client *client) return PTR_ERR(st7571); drm = &st7571->drm; + st7571->dev = &client->dev; st7571->client = client; i2c_set_clientdata(client, st7571); - st7571->pdata = device_get_match_data(&client->dev); + st7571->pdata = device_get_match_data(st7571->dev); ret = st7571->pdata->parse_dt(st7571); if (ret) @@ -966,20 +968,20 @@ static int st7571_probe(struct i2c_client *client) if (i2c_check_functionality(client->adapter, I2C_FUNC_PROTOCOL_MANGLING)) st7571->ignore_nak = true; - st7571->regmap = devm_regmap_init(&client->dev, &st7571_regmap_bus, + st7571->regmap = devm_regmap_init(st7571->dev, &st7571_regmap_bus, client, &st7571_regmap_config); if (IS_ERR(st7571->regmap)) { - return dev_err_probe(&client->dev, PTR_ERR(st7571->regmap), + return dev_err_probe(st7571->dev, PTR_ERR(st7571->regmap), "Failed to initialize regmap\n"); } - st7571->hwbuf = devm_kzalloc(&client->dev, + st7571->hwbuf = devm_kzalloc(st7571->dev, (st7571->nlines * st7571->ncols * st7571->bpp) / 8, GFP_KERNEL); if (!st7571->hwbuf) return -ENOMEM; - st7571->row = devm_kzalloc(&client->dev, + st7571->row = devm_kzalloc(st7571->dev, (st7571->ncols * st7571->bpp), GFP_KERNEL); if (!st7571->row) @@ -987,34 +989,34 @@ static int st7571_probe(struct i2c_client *client) ret = st7571_mode_config_init(st7571); if (ret) - return dev_err_probe(&client->dev, ret, + return dev_err_probe(st7571->dev, ret, "Failed to initialize mode config\n"); ret = st7571_plane_init(st7571, st7571->pformat); if (ret) - return dev_err_probe(&client->dev, ret, + return dev_err_probe(st7571->dev, ret, "Failed to initialize primary plane\n"); ret = st7571_crtc_init(st7571); if (ret < 0) - return dev_err_probe(&client->dev, ret, + return dev_err_probe(st7571->dev, ret, "Failed to initialize CRTC\n"); ret = st7571_encoder_init(st7571); if (ret < 0) - return dev_err_probe(&client->dev, ret, + return dev_err_probe(st7571->dev, ret, "Failed to initialize encoder\n"); ret = st7571_connector_init(st7571); if (ret < 0) - return dev_err_probe(&client->dev, ret, + return dev_err_probe(st7571->dev, ret, "Failed to initialize connector\n"); drm_mode_config_reset(drm); ret = drm_dev_register(drm, 0); if (ret) - return dev_err_probe(&client->dev, ret, + return dev_err_probe(st7571->dev, ret, "Failed to register DRM device\n"); drm_client_setup(drm, NULL); -- 2.51.2