From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sukrut Heroorkar <hsukrut3@gmail.com>
Cc: "Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"open list:VIRTIO CORE AND NET DRIVERS"
<virtualization@lists.linux.dev>,
"open list" <linux-kernel@vger.kernel.org>,
shuah@kernel.org, david.hunter.linux@gmail.com
Subject: Re: [PATCH] virtio: document @vaddr in virtqueue_map_free_coherent kernel-doc comment
Date: Mon, 17 Nov 2025 04:39:47 -0500 [thread overview]
Message-ID: <20251117043922-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20251029033559.83145-1-hsukrut3@gmail.com>
On Wed, Oct 29, 2025 at 09:05:58AM +0530, Sukrut Heroorkar wrote:
> Building with W=1 reports:
> Warning: drivers/virtio/virtio_ring.c:3174 function parameter 'vaddr'
> not described in 'virtqueue_map_free_coherent'
>
> The @vaddr parameter was introduced when virtqueue_map_free_coherent
> was added in order to provide map operations to virtio device, but it
> was never documented. Document @vaddr to silence this warning.
>
> Fixes: bee8c7c24b73 ("virtio: introduce map ops in virtio core")
> Signed-off-by: Sukrut Heroorkar <hsukrut3@gmail.com>
I picked a different version that fixed a couple of other
issues as well, but thanks!
> ---
> drivers/virtio/virtio_ring.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 7b6205253b46..d763060ff0f6 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -3166,6 +3166,7 @@ EXPORT_SYMBOL_GPL(virtqueue_map_alloc_coherent);
> * @vdev: the virtio device we are talking to
> * @map: metadata for performing mapping
> * @size: the size of the buffer
> + * @vaddr: virtual address of the buffer
> * @map_handle: the mapped address that needs to be freed
> *
> */
> --
> 2.43.0
prev parent reply other threads:[~2025-11-17 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 3:35 [PATCH] virtio: document @vaddr in virtqueue_map_free_coherent kernel-doc comment Sukrut Heroorkar
2025-11-06 6:44 ` Jason Wang
2025-11-17 9:39 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117043922-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=david.hunter.linux@gmail.com \
--cc=eperezma@redhat.com \
--cc=hsukrut3@gmail.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox