From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C891725F79A for ; Mon, 17 Nov 2025 09:58:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763373506; cv=none; b=ElDVPIOwwhe9+g8a0vQckn4oE9j3Whp5d9nIC9Judzluaw0b31RyahcXLlwGYFwqFLtudj29iMMbVFPoNx9h4pLA7Jdyo5z+pAmD65hNgIXVDkakkdfn1ftG0Do6PhOCwhYEd7cDj30n0lrb5TIEWn95VBEXYBfpxerHc3LUozc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763373506; c=relaxed/simple; bh=ZR6vU6rukgE7/4fTmTtSkHFBM7iZajv8UE31qvhjE1c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=su00he9RtODEtyjiCAQ+IZc98SyDLPPZ4e74ITk50maiGiKO8zKIbAcPw1k7c75oDZTawzVAd7tenQ0gmka4dFAWb34ZJVjWqNQIrDBg4HvYdO8TOw+wYR7Q+j4X1+JIyfN/EDg7f37YEbetDyG7sYOisCEDVXm1P29zYho7fk0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Kvs/geW6; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=b/eiHE1O; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Kvs/geW6"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="b/eiHE1O" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763373502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mv+ABs1/aqXKwYa9fnN8KDfkMvmLi7ermffaowrPFDI=; b=Kvs/geW6neyyctLel50jBmYmqVFOdQVlfBMX0VIIL8hsxpUcIX2HBQwHpNHD33KUA9yw0u ZXkrCVoyGseezKnu/OApUavD8dj/H9FkRTsiaBuRik3F7Z5ibyY4TJBqso8AAtTSSn1YrZ 0za0RQAiHY/OODvPzdg9wOFDk5gBsuQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-DuZXpzGaPYaNEh1bxUHydw-1; Mon, 17 Nov 2025 04:58:20 -0500 X-MC-Unique: DuZXpzGaPYaNEh1bxUHydw-1 X-Mimecast-MFC-AGG-ID: DuZXpzGaPYaNEh1bxUHydw_1763373500 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-429cbed2b8fso1622259f8f.1 for ; Mon, 17 Nov 2025 01:58:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1763373499; x=1763978299; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Mv+ABs1/aqXKwYa9fnN8KDfkMvmLi7ermffaowrPFDI=; b=b/eiHE1OZRcrvXEHy0omB44qLebcYRnRfy4WCTSeHgnubfYCiavsg8LrSB7MhVjy7a ha6YTvlqsreF4rz7MElLcX1lrDyIkd6UfMM3NW/bCdSbJJa9ay3JuHeCfpb4Fe/COjgl ENAqusTuET8aYGZE/hb0ztbEs3Ia32OaPTiJVLe9831RtYZpza9ho9jBkX2RqvcsPpWh erCyWjSymxX3Kc1Cf6HUhpyEypwFvGFyqREu0wt5YRzJ8zcdL/3ts0JtNIQQ9HDsLLWx LUyRjYNQi4+B8AmfehYcPRGxsLl+Ad01uKF+WiX4qk9h6nS4b8wQoXuRbNEWlMTgoyzQ 7vyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763373499; x=1763978299; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mv+ABs1/aqXKwYa9fnN8KDfkMvmLi7ermffaowrPFDI=; b=nQGxiDqlDTiz9JdWoTDBp1YSxAcJ6cgwVJk+dnDcL9r2TkmwJOkTxrN//k7MVsTfjJ lPGi2MYyZot+K9QT1xFDF2LWcTPE/oNqTMQp7Iti41C+gA86Sa1yN9mAQcW6NddWJqCB A1WRe6QviHKXVpwiU/Rdi0RRBMhzWr28bxkJ0iExmuanAWZwNhw5m1sVXjkFFU2RkAUG 9gHl+enCFFT5lZRFGjxrxJQCBVR2Ijfe2fXVnGD+hNLJ2dOVFQvR/VwmguW3Abk8nOQ3 uAl+KcpN14aD76fkjA+eplsLewQ43+iiCaNyA2KgDdeffBZkRWcjSCxx6a0XSXsby53t l+vw== X-Forwarded-Encrypted: i=1; AJvYcCVa2hhjQooXeRJfSKqMOy6aQ9iA0koiULKia4uYbdTgCyQCSuzLFvFBBo1yPowxJAHuaokYbH5/PHsmsKo=@vger.kernel.org X-Gm-Message-State: AOJu0YxJiE4hBGHQ+A5i/q5woc2kA5eBThfq/AlHDuqmJTU/5BRlyoC8 NUqjJgvM1k386e2Wv4ix4FiEI6PdvvpV2R7sV/xXdmxoTxwAnJ7P06ITw7z7FPdsCD6Ll+qfGtN WUIIgH/YHJhE3IWSF22dM2l0UrE1O+YVWtjnN3NjbzrVGWYMbLh1xOT3D2fG2GO6ozg== X-Gm-Gg: ASbGncspXFmYuaesJvWLPaJNExw7GiNpE4fxzEEBlUrItQGOlavQKFCm8hEcRgzwOxY LCwwDlEvzP9m6cywu5P6UzyXaMsZcbqGaXtB9M82d2pyOrH29ii/+UhS2Yl8xB+CUgltWyHbJyT ei8PGJBuAcn5jg9ZuVm6OfLHg2sGvbbBeYWT24/PzcGc0ZN2kDhN2Tz4FoQ+C3eweLHsuRz5Pqc thTCSdJL4OBbVOwDoQyU7sEbyazogEJ6nFqJkT1llGX9s3c89RWKMo1bRgQO4AmsE3vI4aiRgar KKJFa01XLvXpcnedMwlWy7CBTXl/FEcy4/nhMWaS86iUNL0rK3+HvQbC/dHEz68mkJV2YPtughP EBV0nftOO4Ph+bbJTIp4= X-Received: by 2002:a05:600c:a49:b0:477:55c9:c3ea with SMTP id 5b1f17b1804b1-4778feaa94amr95560615e9.35.1763373499206; Mon, 17 Nov 2025 01:58:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUAGkKB3PJ0ez/r6G8ofkqaQVy8V1bxLdxogwN5gAPLflGK8si6AWTCXMhsuNoie48HG1+MA== X-Received: by 2002:a05:600c:a49:b0:477:55c9:c3ea with SMTP id 5b1f17b1804b1-4778feaa94amr95560255e9.35.1763373498459; Mon, 17 Nov 2025 01:58:18 -0800 (PST) Received: from redhat.com (IGLD-80-230-39-63.inter.net.il. [80.230.39.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4779527235esm158593855e9.8.2025.11.17.01.58.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 01:58:17 -0800 (PST) Date: Mon, 17 Nov 2025 04:58:15 -0500 From: "Michael S. Tsirkin" To: Fabian Vogt Cc: Gabriel Somlo , qemu-devel@nongnu.org, linux-kernel@vger.kernel.org, Takashi Iwai Subject: Re: [PATCH v2] firmware: qemu_fw_cfg: Do not hard depend on CONFIG_HAS_IOPORT_MAP Message-ID: <20251117045307-mutt-send-email-mst@kernel.org> References: <24142953.6Emhk5qWAg@fvogt-thinkpad> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24142953.6Emhk5qWAg@fvogt-thinkpad> On Mon, Nov 03, 2025 at 03:11:05PM +0100, Fabian Vogt wrote: > Some configs have CONFIG_NO_IOPORT_MAP=y but support qemu_fw_cfg over > MMIO. Currently the qemu_fw_cfg module can't be built for those as it > needs HAS_IOPORT_MAP=y for ioport remapping. > > This patch allows to build qemu_fw_cfg in those cases. If > CONFIG_HAS_IOPORT_MAP=n, qemu_fw_cfg is just built without support for > ioport based access. > > Signed-off-by: Fabian Vogt Thanks for the patch! yet something to improve: > --- > v2: Guard ioport_unmap as well, which makes it work on archs like arm64 > in the !PCI case. Unlike arm, arm64 has no stub for ioport_unmap. > Reword description. > > drivers/firmware/Kconfig | 1 - > drivers/firmware/qemu_fw_cfg.c | 7 +++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index bbd2155d8483..91442f85f0f0 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -122,7 +122,6 @@ config RASPBERRYPI_FIRMWARE > config FW_CFG_SYSFS > tristate "QEMU fw_cfg device support in sysfs" > depends on SYSFS && (ARM || ARM64 || PARISC || PPC_PMAC || RISCV || SPARC || X86) > - depends on HAS_IOPORT_MAP > default n > help > Say Y or M here to enable the exporting of the QEMU firmware > diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c > index 0eebd572f9a5..fa4385339824 100644 > --- a/drivers/firmware/qemu_fw_cfg.c > +++ b/drivers/firmware/qemu_fw_cfg.c > @@ -204,8 +204,10 @@ static void fw_cfg_io_cleanup(void) > iounmap(fw_cfg_dev_base); > release_mem_region(fw_cfg_p_base, fw_cfg_p_size); > } else { > +#ifdef CONFIG_HAS_IOPORT_MAP > ioport_unmap(fw_cfg_dev_base); > release_region(fw_cfg_p_base, fw_cfg_p_size); > +#endif > } > } > > @@ -258,6 +260,7 @@ static int fw_cfg_do_platform_probe(struct platform_device *pdev) > return -EFAULT; > } > } else { > +#ifdef CONFIG_HAS_IOPORT_MAP > if (!request_region(fw_cfg_p_base, > fw_cfg_p_size, "fw_cfg_io")) > return -EBUSY; > @@ -266,6 +269,10 @@ static int fw_cfg_do_platform_probe(struct platform_device *pdev) > release_region(fw_cfg_p_base, fw_cfg_p_size); > return -EFAULT; > } > +#else > + dev_err(&pdev->dev, "IO region given but CONFIG_HAS_IOPORT_MAP=n"); > + return -EINVAL; > +#endif I do not like ifdefs spread all around the code. Don't these arches provide stubs so fwcfg can just have same code, with ioport stuff eliminated by compiler? If not, stubs can be added to fwcfg as last resort. -- MST