From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6880D2DBF5B for ; Mon, 17 Nov 2025 05:17:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763356635; cv=none; b=lxByyucFunT1BOtNKqAxmE89v549JPD5dQnQjv8v+ByrgWezzIgd38OhP0yF0CX9OJD5A3gcXrRmjpSs/nfgLr/ER6z0QA4nFx2BYQ81QKvQBJc1cEq02de6XqQJtsQxi/YZmguwU5KDlh6CcArehnJdNpoL9eSubZeVTwsd/oM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763356635; c=relaxed/simple; bh=jMetAjXswfKk89xDttBgjMjZ7rBfdZBoYOr/KWndOtI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PxqPuIOOZhDZjNOTAxeooRiPx4WQ6NGY/QPRo+hdZaYWJvLLMcoOsdqdGYYpZltbMVoM/LdMNZFABtIA+ofRTzO1pl8l8wgCjt54TTpjpWlKB0QGT5EY9ZX11/QdqG/hy/yFSENOinllmBmdIbtN/yeMjNY1QHKMH27V47t6sdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca; spf=pass smtp.mailfrom=marek.ca; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b=PiC47BZG; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marek.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b="PiC47BZG" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-8b2ec756de0so57713085a.3 for ; Sun, 16 Nov 2025 21:17:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek.ca; s=google; t=1763356632; x=1763961432; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1zPoFzhzfSfJq6z3nwCCFRs05FcCD1UdEmhhsy+Y9N4=; b=PiC47BZGYCUlA1JFvPI6JxGd8ZrMt0PitZyHe2dV3YKzvS4JyCLQsV+xvo/Kf1COEb LGiXqwdsgeyxrsYdyCXKD39HtXiN519niHCjdte0aC27jgHMgXhodHz3AT2M0uUTK9Bw lxAKxUHsbmbp6qxQMO+fu/T4G7QqDV5iWy+UBUitgtEwNnl2jwDB/K8Fq6nuzJSY8tnK Tp115MWXZj7ujr89Goie+g3gXOPV1dBL2HzKzplRGz1JxgYNAi0aoPDZ29j7UnvdpSHC nJWBUupmqRw9+LW9Az7+s/TwHe5Hmq9d1eEaZEaGfKRPkh/OX/gHsOo+y//lRfXZL1Xj LrmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763356632; x=1763961432; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1zPoFzhzfSfJq6z3nwCCFRs05FcCD1UdEmhhsy+Y9N4=; b=PYVXTxvHd6EqsDfDiRscZz0Ov+QY56+8j07WyEd+NuRndALklcY2GuXJYbpQqfJIQg GoiFYuoZnJjpY2JHcn4kyJUCf/w02oM0kJO5Q5kHgzO1vzO2vuvVqRtTo/pQF47ykAaT iWF4az6wgO+SAyd8uDlqgRf+ASmdmP9s+m2tHu8ODqDP2qR3JOWDnPlvo9zPaNp+miey LBUes8dz8P0SQrbj34zWCYA6Z7FWxwOMXO/AkZOsjh3XERD/C5cuXR6tVMdZ8oKXJMU4 AOYFpPgcKul1qHxZ+vEkWctQHVZT1feMntCqjoHAFAZDteu+cf6u6J2h97Q/6bYmpqS7 9drg== X-Forwarded-Encrypted: i=1; AJvYcCVHFVoQK0Et5r6Bc3wUKIB1WwrxVTqYds83eHvkFhYyoNsAu9JakTbLKD9mA9oyAnFWYXLo1dF5uKQou4U=@vger.kernel.org X-Gm-Message-State: AOJu0YyXWq5ERntEXF03X+jqzQsqeiF6K621ByLinSxibL1Of9SbEYh2 9brOShgxMbnnSZ4TwoJQAQaOmBJEbwGhKX4mw0Ga8timG89f1srTc61EhKJtaCq7rXY= X-Gm-Gg: ASbGncseBPt31sXmqVD/+0eofgmFdJZw+MQkBbF8dBCDUGF5KevpB55dJsoqQTti+IL W8Y1qeKFbnU7SljuMsHY1AdNQ0AK6REmXzA9WVrC8a6G2M+4Wu5gah/tE0lddpGo74mTyPxWom6 NWXCogK4xL3U497ky5L0z0pjwXkZR1QZCRiLIziqKzagYeJx4iPikV7rD6WjyGLUGGe6ki4UeTB Olvhq5KWOWVTnpzlycauRF/M6vXa/O0/SiMJdtiZAUQ6oglEowWCyx+w5+UX8Ac2a9rtVfXOujI dKgbtlmru/kif7F3daRUefchJZWesqDAQ4sXardiBfNDTu/xSZhqnjdsVKvB8KHFYWtlkb6a3nP utx1by1XFRBWjlgyBik6SNex7eMQxkp4BO/m3T//ikqPXozfi2B/EmNu+yBcNlHxa3pExli4HAE 7ETH3Hs+SceKs130rOJlJQ7dI+YFJfmfSzkXQg8IypfQ6SfEbJi6hcdC3rSED4rdsLMw== X-Google-Smtp-Source: AGHT+IEKEHjgfMdQRDp2kMcmdyptWSAZDc1BLteCr++y67jIrvfuS9EbngFPfnmOmRhGKb2Nu3/DLg== X-Received: by 2002:a05:620a:2908:b0:8a2:a5b2:e3bc with SMTP id af79cd13be357-8b2c31e904emr1313924985a.89.1763356632100; Sun, 16 Nov 2025 21:17:12 -0800 (PST) Received: from localhost.localdomain (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b2aef2f936sm906417185a.29.2025.11.16.21.17.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 21:17:11 -0800 (PST) From: Jonathan Marek To: linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org (open list:QCOM AUDIO (ASoC) DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/9] ASoC: codecs: lpass-wsa-macro: remove useless gain read/write sequence Date: Mon, 17 Nov 2025 00:15:14 -0500 Message-ID: <20251117051523.16462-2-jonathan@marek.ca> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251117051523.16462-1-jonathan@marek.ca> References: <20251117051523.16462-1-jonathan@marek.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Reading and writing the same value to this register does nothing. Looking at downstream driver it seems there was meant to be an offset added Signed-off-by: Jonathan Marek --- sound/soc/codecs/lpass-wsa-macro.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c index 6e54c1beac8f9..6f16d54aee401 100644 --- a/sound/soc/codecs/lpass-wsa-macro.c +++ b/sound/soc/codecs/lpass-wsa-macro.c @@ -1567,17 +1567,14 @@ static int wsa_macro_enable_mix_path(struct snd_soc_dapm_widget *w, struct snd_kcontrol *kcontrol, int event) { struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); - u16 path_reg, gain_reg; - int val; + u16 path_reg; switch (w->shift) { case WSA_MACRO_RX_MIX0: path_reg = CDC_WSA_RX0_RX_PATH_MIX_CTL; - gain_reg = CDC_WSA_RX0_RX_VOL_MIX_CTL; break; case WSA_MACRO_RX_MIX1: path_reg = CDC_WSA_RX1_RX_PATH_MIX_CTL; - gain_reg = CDC_WSA_RX1_RX_VOL_MIX_CTL; break; default: return 0; @@ -1585,8 +1582,6 @@ static int wsa_macro_enable_mix_path(struct snd_soc_dapm_widget *w, switch (event) { case SND_SOC_DAPM_POST_PMU: - val = snd_soc_component_read(component, gain_reg); - snd_soc_component_write(component, gain_reg, val); break; case SND_SOC_DAPM_POST_PMD: snd_soc_component_update_bits(component, path_reg, @@ -1931,7 +1926,6 @@ static int wsa_macro_enable_interpolator(struct snd_soc_dapm_widget *w, struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); u16 gain_reg; u16 reg; - int val; struct wsa_macro *wsa = snd_soc_component_get_drvdata(component); if (w->shift == WSA_MACRO_COMP1) { @@ -1971,8 +1965,6 @@ static int wsa_macro_enable_interpolator(struct snd_soc_dapm_widget *w, CDC_WSA_RX_PGA_HALF_DB_MASK, CDC_WSA_RX_PGA_HALF_DB_ENABLE); } - val = snd_soc_component_read(component, gain_reg); - snd_soc_component_write(component, gain_reg, val); wsa_macro_config_ear_spkr_gain(component, wsa, event, gain_reg); break; -- 2.51.0