From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20092313551 for ; Mon, 17 Nov 2025 05:17:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763356638; cv=none; b=OgsEytGWLASYBN8Nz19ONwEaMPecDFldcLuy4AAJwRCeUwQ53CdeXCPrf4k6Tj2Shz1jjC7BVMYxoMwB/mMCM+71dUG/zKTDR+AsCHgrcz7bGvmAw7BteIYYzTdTMEkAcZNi2VBb9jid5hSJhljbEaqbP5xFlOXAeqgWhbaQsZs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763356638; c=relaxed/simple; bh=nxfCsocaK0cFweuyt80/qsHaaKO8U7Cv6z1iAWrdcgs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iCvCVSA7IhtOvhesVpj9eAg4gKvrPwdZFeV/G7DNgo1KFwf8Xn7F1xjJ52j0TAespkEQPMDGIkSX9ZQz9oE84r3C3iILMoF9fcCe9XlIosieCjC2ZcDU4wXoMEI5ZA3pSFFPBIJOoy8aCVlYTT5hT9mFY3qaEyMiz+1FxymtHII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca; spf=pass smtp.mailfrom=marek.ca; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b=CK3hVbv3; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=marek.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marek.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marek.ca header.i=@marek.ca header.b="CK3hVbv3" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-8b1f2fbaed7so315561485a.2 for ; Sun, 16 Nov 2025 21:17:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek.ca; s=google; t=1763356636; x=1763961436; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xhu/xwE3akCLuvlVIvCt12pssctwOpgKAURZZ/wZRw4=; b=CK3hVbv3qRcHEXQxGd5g0lfeqsVXtRCkIKIbyDCZlrQ4neZlweaHo7Tx+TU7ZBNkrA hBVeHtMeikqHdCl62LvW7M67tsdfm6J7lrpy/7+E/UoPN791/x2DJPt4jH21Wuh3Lc5a w4Fgjj8ld9epHKhTSsaEw7uyT/+BbbBlRXyx4nkmRhi4K/XEAyRDbOM8qIJEqe5fbZvg 6JUbAoTWVWQbvEXh94eSUokMRMNHPXr8pGo+WbqNBZq0NSBkwsWlVrAF+MgpINOYtOMA g+Fnnr6ZdtzDGOfQp2ujdpReIvZCBdq0TIwjF7CNFmk1f6NMeLzWJMWYAzRFV6J6iCpx DERA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763356636; x=1763961436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xhu/xwE3akCLuvlVIvCt12pssctwOpgKAURZZ/wZRw4=; b=OG1PLuL38z1EXebrWb9DNl/svdjCYi9cmi4+uw1XFBBnQf9GWoAdwHuPN+5UWVsgvO r+z0y+zgD0N13Q1W6xrF+XPrG7zJxH5RRjipghQK92DJKDbFp8obb+KgXD7YF4eHxVr+ SHTszZV19nM1gho9j4JmN7tHWJoVedP7ZefDWcZaE7W1oEgE4JfIievwmG+iRDHWffLG pz1RW5E2SSm57YeMOyTU/f0eIsrPdcDYjmOSs/+3rCXxRK7bSrxCX13u0dm9OeE85t3b KM1/GXeWkvJR28d0lMF3lLnNyM4JNB6mNSr/bj3+EJS+YyO6kEItNdJ58yuIPleSQ+Xs ssCA== X-Forwarded-Encrypted: i=1; AJvYcCUfQt2EYOgFuwyE8tu2ABegwM45GuW94O7+HCoG6SQTZ1GQ95I7PTVBllh4GEbz7+XXiF9k2wq/PWMXmNU=@vger.kernel.org X-Gm-Message-State: AOJu0YxD+Te7q5D+6iBwEsKPUP7H9HZmSFEdATvi5H2U4wX20wSINVwR OixG58b11irMJArXNc7Y44wM8nQEAkDf6lV1vq2/jDpCWLLIVPXOMRBxzNcep4GHsdM= X-Gm-Gg: ASbGncsMk5NZjyH8NZhzBKECyxuG4vjdsvWToj5rQfTiCGUV1MBLS6V+QAcbEg8f6aF f1mLP8oO252A2zNDK6st5B6u8ELaYbs1K0pX6UbsytFZ+QoofnOg2ctuKm+7IBOY6kjR6Xpeu9p AOZaY0W3l/DQoOyGbwyRum7bggMfS5oVWVo+YtFIK5RFsTpNGXNAleB4j6ovjkuCG6dmf3lVje3 eDSKjL37OuxlDola62ty7734BEApYCSjXSmifEqzAoyaZfb3VI+HLrvG65R+o7K8tNjY5a0pOFs YxWfjQpxR674ZSSWx1mOlZOsrIBDryJpZjzEcXcIQigOoeZMqu1d821xfaDB2NFmzt+OQEFv/K3 4oMdM60KCLuWTHrtkLnOz+9IC/SQrnYKEKufqB1JRi9nAk3v2vmSFV9/4LAGxeQdGNqmuPCIuJM QnLJCvB9s/MyICavb+IykTqRLBvk6BtR8OZczAnzQjKiVt9VmyLmZq8tc= X-Google-Smtp-Source: AGHT+IEgJnqQ0EhhsbG4Q0ct0bfnX4ZHO7Bu8ZyywX9Vj3w0sULS5OMvdnUpE3L4eiQGjIBhYG/pUQ== X-Received: by 2002:a05:620a:199c:b0:8b2:f145:7f28 with SMTP id af79cd13be357-8b2f1458d4bmr183844885a.33.1763356635974; Sun, 16 Nov 2025 21:17:15 -0800 (PST) Received: from localhost.localdomain (modemcable125.110-19-135.mc.videotron.ca. [135.19.110.125]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b2aef2f936sm906417185a.29.2025.11.16.21.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 21:17:14 -0800 (PST) From: Jonathan Marek To: linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org (open list:QCOM AUDIO (ASoC) DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 4/9] ASoC: codecs: lpass-wsa-macro: fix path clock dependencies Date: Mon, 17 Nov 2025 00:15:16 -0500 Message-ID: <20251117051523.16462-4-jonathan@marek.ca> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251117051523.16462-1-jonathan@marek.ca> References: <20251117051523.16462-1-jonathan@marek.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit "WSA_RX0_CLK",etc. are path clocks, but "WSA RX0",etc. are ports, and there isn't a correspondence between the ports and paths. For example "WSA RX0" port could be used by the "RX1 MIX" path. The problem becomes obvious when RX4,etc. ports are added. Enabling the path clocks should depend on the path being enabled. With this fix, the main path clock will be enabled whenever the path is active: previously using the mix ports only would only activate the mix path clock and no audio would play. Signed-off-by: Jonathan Marek --- sound/soc/codecs/lpass-wsa-macro.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c index 06570e474c850..27c8c060cab19 100644 --- a/sound/soc/codecs/lpass-wsa-macro.c +++ b/sound/soc/codecs/lpass-wsa-macro.c @@ -2496,10 +2496,8 @@ static const struct snd_soc_dapm_route wsa_audio_map[] = { {"WSA RX_MIX0", NULL, "WSA RX_MIX0 MUX"}, {"WSA RX_MIX1", NULL, "WSA RX_MIX1 MUX"}, - {"WSA RX0", NULL, "WSA_RX0_CLK"}, - {"WSA RX1", NULL, "WSA_RX1_CLK"}, - {"WSA RX_MIX0", NULL, "WSA_RX_MIX0_CLK"}, - {"WSA RX_MIX1", NULL, "WSA_RX_MIX1_CLK"}, + {"WSA_RX INT0 MIX", NULL, "WSA_RX0_CLK"}, + {"WSA_RX INT1 MIX", NULL, "WSA_RX1_CLK"}, {"WSA_RX0 INP0", "RX0", "WSA RX0"}, {"WSA_RX0 INP0", "RX1", "WSA RX1"}, @@ -2529,6 +2527,8 @@ static const struct snd_soc_dapm_route wsa_audio_map[] = { {"WSA_RX0 MIX INP", "RX1", "WSA RX1"}, {"WSA_RX0 MIX INP", "RX_MIX0", "WSA RX_MIX0"}, {"WSA_RX0 MIX INP", "RX_MIX1", "WSA RX_MIX1"}, + {"WSA_RX0 MIX INP", NULL, "WSA_RX0_CLK"}, + {"WSA_RX0 MIX INP", NULL, "WSA_RX_MIX0_CLK"}, {"WSA_RX INT0 SEC MIX", NULL, "WSA_RX0 MIX INP"}, {"WSA_RX INT0 SEC MIX", NULL, "WSA_RX INT0 MIX"}, @@ -2568,6 +2568,8 @@ static const struct snd_soc_dapm_route wsa_audio_map[] = { {"WSA_RX1 MIX INP", "RX1", "WSA RX1"}, {"WSA_RX1 MIX INP", "RX_MIX0", "WSA RX_MIX0"}, {"WSA_RX1 MIX INP", "RX_MIX1", "WSA RX_MIX1"}, + {"WSA_RX1 MIX INP", NULL, "WSA_RX1_CLK"}, + {"WSA_RX1 MIX INP", NULL, "WSA_RX_MIX1_CLK"}, {"WSA_RX INT1 SEC MIX", NULL, "WSA_RX1 MIX INP"}, {"WSA_RX INT1 SEC MIX", NULL, "WSA_RX INT1 MIX"}, -- 2.51.0