From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDCD632C95C for ; Mon, 17 Nov 2025 12:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763383054; cv=none; b=VQKJGemmWqsT85gUD4U3xE6CF+SBZF4YROt2eWen/qhTNCyY8oUBdCYf7dtaOfWH2xuiFVnouV7kJBV+VLyJh/uT93vA/NZeDAK4crbT9dlEDSFLCe8bkeDNu9cB3uUpSiRT2yUAxXl/IAAMVsZfc7nA52fhkizR/grfp/AmOds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763383054; c=relaxed/simple; bh=2/CLLB11jZ+2Vde9Fu7d0+mmmZrUaoPkTUqt+9mnxrU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cYETZlN2UkTaCEcMdRIZjFbVXjahXHYurnD9TdFI5lO/HjFEQWbnO2BGUOC50d9+W8QAXkVg4DMLTs3qO762u2/iEzPp8zcad7ogEVe39waBBi8EQeWr8GSsWI7HYKzR1q2TBVppoym1lk+o7yLO4lKuzbpwKpFpaqDdIoe93zc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AXiu2fFn; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AXiu2fFn" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4777771ed1aso28242465e9.2 for ; Mon, 17 Nov 2025 04:37:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763383051; x=1763987851; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6/zDQJp5XRQqTJbQ2zXOQGgTvGTfgr5PnvBLSwIOrfA=; b=AXiu2fFnAX0Ro7Pch3zAuCGJgcvHqYUBCmNtwbpDzSo1IGySpyUvJ3Itvv6IEB8WXF fUjSTzC+cHV18Gk5pQij6+B61x/K7CP0SEZg01rfgz/0HmbjplG3QUiHeRY8fi/vZJfw cSH48D5i2BvhLJXpZp7AMfybi9pJEF3j1swNQiRil9q+AKOLYl562HqE/A7dIPHzqFdz sBPUm486vN9RRwsgzKAkDNMIETK4nSEmjiGl3EbP4KkgeSeT3ukLQxQNfPkcqaIuhKQn i9XFFQbP0t1IEpOnH41UwMUKug437i/YACy9mNk8kHXiz3W+UP4rNjmEpOpRsOyyF2xD g6Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763383051; x=1763987851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6/zDQJp5XRQqTJbQ2zXOQGgTvGTfgr5PnvBLSwIOrfA=; b=Hx7Gm13rGe4Fonby8Y4vFGiAsVcQ7ZnFwH79sDrLQMri4N3GrGKX1bQ0zTLTg/duI3 csmSyT15i1wmDjH6gptptJijnruH/R0FRsBeszxe8HIFcS4Td+6whNmgJMIklrEpaL+5 A9fBfxw2gJUSrXq+r4PR1G9yIvjKOZ1axJVO3ZHaHHsURcsM1RY+qQ5wXCY4y4fjeAR5 BpJKlIdIFdvHSnfJqEgTyvyiyBwynYTZk2zdhTRDOSF4RL8UHMX8ySJ1AZHKaC9OoexR +oVY73FCXbJ+OSD0rN+2462ASVxajbeLl3fFOqW2Ij+kiTmDRFEnOXSin+vRdUkOlxX5 Njrw== X-Forwarded-Encrypted: i=1; AJvYcCXnXkbjGfvFu6Xdlsx1JjKNNXEQf762nB+SyVGyAwRGojzN9wHw4PcCGGn2sCNjK7pdLU4Zp3XP2Yc86b0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9ObgYYiXHh26dFgqsmvZpuRDs6jRAehTBNrpRbsA5Vy1i7PCL hEBH7Ob0PmfZEPHtZYbtaJKev9gAYtNAn8gcoLnYKFQh1cMCM6jU56ETpZ0MCQ== X-Gm-Gg: ASbGncs/pIRS+NaaVve/HJ5WIa6MzHQhoXp07jNqOAwB9mcQQIQ8kvnoIfsIagRFoDn U2oV+re8F4JJ2yvQMvnZMUBhFgxOOAkaJoLJgt12eFFUKWQaZeFrBjEMahgewKO9PiSoC35BmeB nLMZfmiepT1l4C3N6cWU0sBY9en8ZQNTH1eRBPZuw5vtSezqfOBhXb8tG04Z0ILE1nfk4f47xcJ 9ixdPs2IlkDS/dSa2KeDUiKHlMarunzIk4O7hcT7UooVHqCdCQzAZrDqox/T+WgWm3OSoyP27cY QtW5e5FLxcXUPvkfUTT1mzrpXoM2b6BWxsK1ANiMRbsdQnBXRYrPwzpZzhHDtaaSgAWiRuRP9Hw 9SFrAY037QsYSY2BQdV5x92Ebe9vHHbHfQRODA9EHidN44UrOLa3HfPQxSEKW6eQcSGCu6bONcw jpoVWYIELwsLrOc7lB4VLJb8dnMa8isJf2cCtmyfANwknXaifwI/N9SzjBuKG/0hk= X-Google-Smtp-Source: AGHT+IHKxl4hUaLmO0In0iv9LPFg2mn5WvljaeGECiRiJti0suAsUgeii/qhMZq7VPB66ESjpusThg== X-Received: by 2002:a05:600c:4714:b0:477:8ba7:fe0a with SMTP id 5b1f17b1804b1-4778feaa8ffmr114072105e9.24.1763383050763; Mon, 17 Nov 2025 04:37:30 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477991646b2sm134836335e9.7.2025.11.17.04.37.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 04:37:30 -0800 (PST) Date: Mon, 17 Nov 2025 12:37:29 +0000 From: David Laight To: Alexandre Chartre Cc: Josh Poimboeuf , linux-kernel@vger.kernel.org, mingo@kernel.org, peterz@infradead.org Subject: Re: [PATCH v4 00/28] objtool: Function validation tracing Message-ID: <20251117123729.72ffa3e2@pumpkin> In-Reply-To: <81693206-9002-4669-ab74-fda3d31c25bb@oracle.com> References: <20251113164917.2563486-1-alexandre.chartre@oracle.com> <3367da83-16b7-4c6a-bd08-d14ec4067025@oracle.com> <20251117094210.3c3e4f40@pumpkin> <81693206-9002-4669-ab74-fda3d31c25bb@oracle.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 17 Nov 2025 10:47:06 +0100 Alexandre Chartre wrote: > On 11/17/25 10:42, David Laight wrote: ... > > Although I think there ought to be some indication of the 31 NOP bytes > > at the end of the middle alternative. > > I am now compacting the code by removing all trailing NOPs. I should probably > improve that with printing the actual number of NOPs, for example NOP31 (or nop31) That is the sort of thing I was thinking of. Perhaps the actual opcodes on one line - eg: NOP5; NOP5; NOP5; NOP1 > > I'd also decode those callq as 'callq .+6' - not sure what other people think? > > It is rather specific to that code. > > This is done by libopcodes. I will need to check if there is an option to display > the branch distance instead of the branch target. The 'problem' is that mostly you want the branch target - except when it is small. Then you don't need both 'address' and 'symbol+offset', and it is quicker to find the target by looking at the branch distance. I'm not sure how you'd please everyone :-) I'm sure one of the disassemblers ends up giving you the target address in a form that isn't on the instruction line! I've definitely counted opcode bytes to find the target. David