From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D3D12FFF91 for ; Mon, 17 Nov 2025 18:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763403146; cv=none; b=tYM7Z2D9+2pAdjVL29fjfx3PXUb/RDv7OckLiN02e6r66aC1uoNB3TSC3nmfPEhdTGfFmh/4s1v+M99upYvuDxPDD1cep2P16Y2047fGu0HOcArW06BoHU6g/h295dqQI5IJ2JSGk9bc6GEzjbC3j32hHtpRUZAawJVFTcV678w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763403146; c=relaxed/simple; bh=pD9ONn34d9sG7g4Bf9OyDOTWtp2GV4h/WO7lKA1w9YA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=IC7vqkSH373FZNndhTbf1Iz4m8O3Z723b6IwD35N+1xrZFoxVxbqrVQS/YauqCXY+4S/+qrCeI1Pxc/9lsZhr4wFyugBbdJHru3ONv8IR73BqF9ij9JXLAK44tkhVNzfIaic61L0dq5RJEkQeZnaDFiA9jb2cjy6OAPSh8eMFxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QavKxQdI; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QavKxQdI" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7aab061e7cbso5166708b3a.1 for ; Mon, 17 Nov 2025 10:12:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763403145; x=1764007945; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZfcsfKcv/BP7tqClGVimV0mOVKurM0RlBCGupkv+8Gk=; b=QavKxQdI/e09N35XOa0TScS66BhrAeWh0CByEj0ULNfIJIiaQwRJ68HJhzQ6bEmBg5 5uOfy6OzCNWcM73PIzDN3bV58TqK9/R4cd8AnlZ3hAPDB3wTd7TnJJpPsxWQHz2TPAnh jtkEzC4hQarAG+jYMf3ILn7C/V3AuDmHOFB1ak7tsTeSGXtggo9aouVZzRHhNRUyvb5Q egUudXwLGP4VeqG4aFv6N0Io0jxxruz3V2RgBfVVoKSAgEiquIQPxcddHE2h+qIyHNzr NKUhZ+1BVsOBqG9tdu14NZvCCHs7bjdBrgYYJ6mtd3fW/cVZ61Kw72KRTBw893p9RSYO 9zrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763403145; x=1764007945; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZfcsfKcv/BP7tqClGVimV0mOVKurM0RlBCGupkv+8Gk=; b=Jhjz2Xx1w8OeuZMP6Getk1aNBkMFl//RRQlT7LXYQLtMYPM9fKFvE5ylxi/aodErTm ptQbjATyaGfbmwjevyX1UasSiTvgWkzpgqW/Kf7JSGGPvGmQzL1a5QCAUmW+s/Jog2gm vNxu7fYvV6gr7bzacGjBRU4SDqOCPJFJOlXxPNIC6gyBWKydAJOBQbNwQos1gWUiMz1F lxh0JQq4gtw9tBbkR4XRPImb6lcrw8KeySJn5mFhn+KPphtMQGVOOqpWL1o2Ag4I5reY xlS3cUYjqBHjJRyh5gZ4NmmPDSDD9Dhs7VzP1F7SmfJ5qfvXN4eyruJ3hiR+08JMoNdW /eNA== X-Forwarded-Encrypted: i=1; AJvYcCUvHwW0RM1BrJTaD9U9Wow5ssGA/bnuYukoz2u8WzSPN/s58o2lT9CMRNDBS7J4J8YYNW0/4ZvRFro8iTU=@vger.kernel.org X-Gm-Message-State: AOJu0YwLMkHCNGKUMhVuIRhj6CmkMO3NPA6N6B7InYOtcBwfFokH9gnb Mbos5h8sIT2K/NCfRByDFG2MrcQXQnA/eJON0srtOp65Ll5szVEH0Qcb44Ko3TNg X-Gm-Gg: ASbGnctjQ7cQKj0MqrtbiSUfVTOvp48zobC6StDj7Ugfd0vqHKCWlO83bB03IchZb8a hTCBmMxa7Y9/jS6ri4769MSjMdrROQxZuERiysKA4or24c2mhwbPy7U6pkIgu6A+XxIf2y6vrtH ilcfzc3vr659CCbD2uyfzGrx4ANg/r1Xpz72UzeZKAkrY3Qv1/q/aVwdrAD60eXPUf5RX5sOpPK JU3oSTQJ+ND6t4Kk9EvjaC/8ovo+us2I3ISsWCvoFpZdmhscs0AnUlBHXCbAPwuUcfrGLdtxycZ IKhASJEHv81jKUtf4JhK0mbLg29jVYiS/7zZK1x22ZOziPpKjxBSNtPvLsej6gxEFwxUwuF38e3 /xUPjUyc9qy5K4p+Hb9zqpVw0dM6ZSGLFWNBOAjcOXCqV2Chvcr6qhZZTgvmZXcRL7K9YXU0ydL UteYiV7jIOfk/hwqfNmTi6uDoSf8N29iBN2mVHa90ad13REGFkvZGrhOhUgXoGnzlXD7BS4IY78 lm0zpgXs7MXxwjKS7Bb X-Google-Smtp-Source: AGHT+IHpTuvGJYLOUO2ZWin4A8dTZjs9rm9P6OGmQeUB7EQVJ3WpuDHrUNwlJ555cdwI1pdBEVozWw== X-Received: by 2002:a05:7022:6990:b0:11b:78e6:8323 with SMTP id a92af1059eb24-11b78e684admr5002172c88.37.1763403144217; Mon, 17 Nov 2025 10:12:24 -0800 (PST) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11b060885e3sm49942351c88.0.2025.11.17.10.12.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Nov 2025 10:12:23 -0800 (PST) From: Justin Tee To: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee , Daniel Wagner , Hannes Reinecke Subject: [PATCH 1/1] nvme-fabrics: add ENOKEY to no retry criteria for authentication failures Date: Mon, 17 Nov 2025 10:43:43 -0800 Message-Id: <20251117184343.97605-1-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With authentication, in addition to EKEYREJECTED there is also no point in retrying reconnects when status is ENOKEY. Thus, add -ENOKEY as another criteria to determine when to stop retries. Cc: Daniel Wagner Cc: Hannes Reinecke Closes: https://lore.kernel.org/linux-nvme/20250829-nvme-fc-sync-v3-0-d69c87e63aee@kernel.org/ Signed-off-by: Justin Tee --- drivers/nvme/host/fabrics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index 3d4d6d8e88c4..fb7765bf0cdf 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -594,7 +594,7 @@ bool nvmf_should_reconnect(struct nvme_ctrl *ctrl, int status) if (status > 0 && (status & NVME_STATUS_DNR)) return false; - if (status == -EKEYREJECTED) + if (status == -EKEYREJECTED || status == -ENOKEY) return false; if (ctrl->opts->max_reconnects == -1 || -- 2.38.0