From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7878126ED37 for ; Tue, 18 Nov 2025 01:40:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763430027; cv=none; b=bJfkhHKicWCG7mhl8J3HQUXEg67fqJd1QOejYFizzXdRZlUtsi2mU7uqExqp88Sl4WTjyYz1X8DnleafXl6WoT1ZDHz5wjQl8MC08+7Z8q2AR07jddxYQhJuLplLIqXn785k94VNX1GN0BWvuMtuYdzVFOWoAeIgZtlaVweoavw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763430027; c=relaxed/simple; bh=HC0wW5cR4LQyHkZxX4Q3FPGBPQk+o6MWSt6ijm5OY7g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eay8CGyOsAFcGAinWHOOJFZ2Yo+WY4t3rsyifqyUO4yERt6viWi7dRR1U2DkDbee0gJ9JR1T79eUGvMDtFpTTV71JYp3VBtGUu72FaZT0u58DCJSR0ExYk7ib892/rvWb2OwDVR+t0vPeAwPix0xtTA2k80fQIoleq/GGuU7y1g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K0OFoAo9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K0OFoAo9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37554C2BCB7; Tue, 18 Nov 2025 01:40:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763430026; bh=HC0wW5cR4LQyHkZxX4Q3FPGBPQk+o6MWSt6ijm5OY7g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K0OFoAo9hpMJaYk5dmE4U3o6J0wqXWjvkf49BV9l17fiB/Tw7ezuWPcWRCFpF6+uq wB0dp0idRFjw1AqdQc5nCqdC01DOyUjjegb/Kxn3XdvGfTnFrm9h+cK8h9D8bbGc8a 8QpsqCE3j3TVhs8W2DjNfqv7TgELBFr4Q1PecDPxpyOrGIZ/r8BB+hNQCRQz94pBjY H5izwudDqYftYs3d7Wg0AGeaWq1IVd2akkkB4xpKeTxRqlGJF1A4aZDSkcE8d0C4d/ //g9njU4SUGowAIELm7VJEPS+BRjl2e4ZQoCGl3BRZhFdMuz+Xd/VGFYF7u217x+m0 kRfdEb4aQmS9Q== From: SeongJae Park To: Jean Delvare Cc: SeongJae Park , linux-mm@kvack.org, LKML , David Hildenbrand , Oscar Salvador Subject: Re: [PATCH RFC 2/2] mm/cma: Consolidate accounting in dedicated functions Date: Mon, 17 Nov 2025 17:40:20 -0800 Message-ID: <20251118014021.75804-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251117121502.6db0fd7a@endymion> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, 17 Nov 2025 12:15:02 +0100 Jean Delvare wrote: > Move all accounting to dedicated functions and rename them > accordingly. > > Signed-off-by: Jean Delvare Reviewed-by: SeongJae Park > --- > This is based on a suggestion by SeongJae Park. Comments welcome. > > mm/cma.c | 43 ++++++++++++++++++------------------------- > 1 file changed, 18 insertions(+), 25 deletions(-) > > --- linux-6.17.orig/mm/cma.c > +++ linux-6.17/mm/cma.c [...] > @@ -1029,7 +1022,7 @@ bool cma_release(struct cma *cma, const > > free_contig_range(pfn, count); > cma_clear_bitmap(cma, cmr, pfn, count); > - cma_sysfs_account_release_pages(cma, count); > + cma_account_release(cma, count); > trace_cma_release(cma->name, pfn, pages, count); I was thinking we could further move trace_*() function calls to the new functions, but this version also looks good to me. Thanks, SJ [...]