From: kernel test robot <lkp@intel.com>
To: azey <me@azey.net>, "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org
Subject: Re: [PATCH] net/ipv6: allow device-only routes via the multipath API
Date: Tue, 18 Nov 2025 07:51:48 +0800 [thread overview]
Message-ID: <202511180742.7iC868V8-lkp@intel.com> (raw)
In-Reply-To: <a6vmtv3ylu224fnj5awi6xrgnjoib5r2jm3kny672hemsk5ifi@ychcxqnmy5us>
Hi azey,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
[also build test WARNING on net/main klassert-ipsec/master linus/master v6.18-rc6 next-20251117]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/azey/net-ipv6-allow-device-only-routes-via-the-multipath-API/20251117-023331
base: net-next/main
patch link: https://lore.kernel.org/r/a6vmtv3ylu224fnj5awi6xrgnjoib5r2jm3kny672hemsk5ifi%40ychcxqnmy5us
patch subject: [PATCH] net/ipv6: allow device-only routes via the multipath API
config: i386-randconfig-141-20251117 (https://download.01.org/0day-ci/archive/20251118/202511180742.7iC868V8-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251118/202511180742.7iC868V8-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511180742.7iC868V8-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/ipv6/route.c: In function 'rtm_to_fib6_multipath_config':
>> net/ipv6/route.c:5122:22: warning: variable 'has_gateway' set but not used [-Wunused-but-set-variable]
5122 | bool has_gateway = cfg->fc_flags & RTF_GATEWAY;
| ^~~~~~~~~~~
vim +/has_gateway +5122 net/ipv6/route.c
86872cb57925c4 Thomas Graf 2006-08-22 5105
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5106 static int rtm_to_fib6_multipath_config(struct fib6_config *cfg,
bd11ff421d36ab Kuniyuki Iwashima 2025-04-17 5107 struct netlink_ext_ack *extack,
bd11ff421d36ab Kuniyuki Iwashima 2025-04-17 5108 bool newroute)
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5109 {
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5110 struct rtnexthop *rtnh;
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5111 int remaining;
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5112
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5113 remaining = cfg->fc_mp_len;
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5114 rtnh = (struct rtnexthop *)cfg->fc_mp;
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5115
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5116 if (!rtnh_ok(rtnh, remaining)) {
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5117 NL_SET_ERR_MSG(extack, "Invalid nexthop configuration - no valid nexthops");
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5118 return -EINVAL;
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5119 }
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5120
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5121 do {
e6f497955fb6a0 Kuniyuki Iwashima 2025-04-17 @5122 bool has_gateway = cfg->fc_flags & RTF_GATEWAY;
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5123 int attrlen = rtnh_attrlen(rtnh);
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5124
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5125 if (attrlen > 0) {
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5126 struct nlattr *nla, *attrs;
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5127
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5128 attrs = rtnh_attrs(rtnh);
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5129 nla = nla_find(attrs, attrlen, RTA_GATEWAY);
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5130 if (nla) {
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5131 if (nla_len(nla) < sizeof(cfg->fc_gateway)) {
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5132 NL_SET_ERR_MSG(extack,
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5133 "Invalid IPv6 address in RTA_GATEWAY");
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5134 return -EINVAL;
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5135 }
e6f497955fb6a0 Kuniyuki Iwashima 2025-04-17 5136
e6f497955fb6a0 Kuniyuki Iwashima 2025-04-17 5137 has_gateway = true;
e6f497955fb6a0 Kuniyuki Iwashima 2025-04-17 5138 }
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5139 }
e6f497955fb6a0 Kuniyuki Iwashima 2025-04-17 5140
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5141 rtnh = rtnh_next(rtnh, &remaining);
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5142 } while (rtnh_ok(rtnh, remaining));
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5143
f0a56c17e64bb5 Kuniyuki Iwashima 2025-05-15 5144 return lwtunnel_valid_encap_type_attr(cfg->fc_mp, cfg->fc_mp_len, extack);
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5145 }
4cb4861d8c3b3b Kuniyuki Iwashima 2025-04-17 5146
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2025-11-17 23:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 18:31 [PATCH] net/ipv6: allow device-only routes via the multipath API azey
2025-11-17 1:57 ` David Ahern
2025-11-18 9:05 ` Nicolas Dichtel
2025-11-18 11:00 ` azey
2025-11-18 16:04 ` David Ahern
2025-11-18 16:41 ` Nicolas Dichtel
2025-11-18 16:58 ` azey
2025-11-18 16:47 ` azey
2025-11-18 18:18 ` David Ahern
2025-11-17 23:51 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202511180742.7iC868V8-lkp@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@azey.net \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox