Re: [POC][RFC][PATCH 1/3] tracing: Add perf events

[Peter Zijlstra <peterz@infradead.org>]

On Mon, Nov 17, 2025 at 07:29:51PM -0500, Steven Rostedt wrote:
> +u64 do_trace_perf_event(int type)
> +{
> +	struct trace_perf_event __percpu **pevents;
> +	struct trace_perf_event __percpu *events;
> +	struct perf_event *e;
> +	int *count;
> +	int cpu;
> +
> +	if (set_perf_type(type, NULL, NULL, &count, &pevents) < 0)
> +		return 0;
> +
> +	if (!*count)
> +		return 0;
> +
> +	guard(preempt)();
> +
> +	events = READ_ONCE(*pevents);
> +	if (!events)
> +		return 0;
> +
> +	cpu = smp_processor_id();
> +
> +	e = per_cpu_ptr(events, cpu)->event;
> +	if (!e)
> +		return 0;
> +
> +	e->pmu->read(e);
> +	return local64_read(&e->count);
> +}

NAK, wtf do you think its okay to use internal stuff like that? And
wrongly while at it.

What you wanted to use was perf_event_read_local().