From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FF91268C42 for ; Tue, 18 Nov 2025 09:58:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763459930; cv=none; b=RrKTMgygtOW/oPBVr0eX5AyRsLDHk5UlTdUe2W2ygDiNohHChgYH32i+qPHtHKmh0OKSRFJIlwdY0tDlHG3IucmUwKZdHWCQhQrA1ZKpGl7bojpTGrV+KbvBegSrLHfoM6pvUoBIqumKhabUolcHBUQBZoINTAiryuKmELhlEhM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763459930; c=relaxed/simple; bh=6bH4FMFnhmor0Jpt+/IfKK4pkPUy1xXuUNGqEWsXjTc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Q/AmrfcUls7DWJFaJvyzJMZZXxmzL+ywUblLWCYtJb1fltRBpx68lvMdgbV7IaZwP3PUKvB/MMD5rIvMgsZNkvpRyjzyQLIXpuSNNUUvpXxpfmz+g6jW7dgaT4tdlbJA9Rdr5PdCquTteky2JfGcJFpW86RjXKYtIGduSPjf/gU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RwZmSoNs; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RwZmSoNs" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-42b3108f41fso3230419f8f.3 for ; Tue, 18 Nov 2025 01:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763459927; x=1764064727; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=quKUSxgGNkDcW2rawb6iqfcdc4aeHiUyngBcWRemy0k=; b=RwZmSoNsw8eSfBdBC4x9SdhU1jIKHHHjMahLwmltVPLRABQ153FMaHHihnT273+XOR pXRV8GlDSWWpAJmj89+UGMFnjlTWWl/DV2PVU8bOckGye9OttWJb6g0ZpE3OFmwbK6rD ySbymttQDYcm2kGIgNKuddZ9Va5SJrkdYOvdq6fCwZ+/jlvCeZUQdYzSHSschMjABgB1 nCgpFE/+kmF8kmOexzo6Q+LpWRECoY5klJdMGJ1SFTa4+GXdyyTgWIS2apG6q3wKqkhb R63B+vhvHX39oNYoYvnnd2cVbVgH5MUYIQXxx/2Ybby9bVF2GRx75JQvAwYM/MCv6bH5 6tFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763459927; x=1764064727; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=quKUSxgGNkDcW2rawb6iqfcdc4aeHiUyngBcWRemy0k=; b=ejzXLDZrU6mMHsMkn30D6ewVwzLq2KRK1SDfufAZnLRrb7+PYH/gzPOIqJNBpscl1i +5HmadfP05Ynnm14sy4hfaX+r43vwOM8zWFJAAoLDAhmPmLC2ypYDsyR/lklXI0/3i6Z VGgAvQFS/qeDZaliFPSQ0xk1NJCKZvhUxLSlziyuCFGt22rZ/9MrIHXc+TSzJ8jiI7r9 mSElcnvu2ZiM/qxXNCoq2e+7NmyPRJSz/d4Senq2VSWjZ3j9Qn56T/UCSwqQ5wiPdylp lt9aKIxgNNVoAD7TkQDbjpGv9tgLjZHuguxZUgRJ3rUs/7GiPzyKe0pOvjh6GgQDEul2 NCfw== X-Forwarded-Encrypted: i=1; AJvYcCW5xRs2Gvqbi1/CKnxuVzlgvXuc5R0ODg4r3+txnUnfFIIFK5KlezctnSHnyfUHpPoUfPdHh8slh4VrkuU=@vger.kernel.org X-Gm-Message-State: AOJu0YxgyzLhYPofJQWJtvs29SM/yPfvL6aZ0/ay3KAxGAcqgwQQ+VuK WFtpeqjvDPvMlPWPdY+KrZZ3h0upamgJnMP2XmdRiw+wWf99fliEEtXdqwk3Xw== X-Gm-Gg: ASbGncu/DTNoGSLwEJsD60M37izpcLsLjvNKJ7aq8/zUAyzmpaFx2ubBBIU6nPGNCwG oKkpIoJNiUUF4P3SPI0N5nU3EUCc/mpWC7dk2zVX86s48ps1qobXLllIAWfw/z2Kmf0MluiVvy0 kUSN1UWFHDjWjbNO058nwkneNS0LK2lzvqjXwZ4YBZ1RhIUI/WIjFdjIcCwXzSpyCrCQC5YH8Gt Gg0TKpT42lpSbVjtxzedOA+gH3xB6lm5vK8Y6ElXVXGUI3BcdVJNMQ8g7gavocnOgIsluXiSrw2 LDTAlcqSBSLmPMZ1FCTD14AbyYtbjqQuCf9y9VW8UWnc2AHiAuvBLxIKA8aSo7Hx0bibCPcMmp7 kf1H2TBWf4SNrX/bhYE3oo5MygsrRBU/Fh+UFNhgnjOXp9eJm8y29AdyK4VYhIJP7tKwwTuRBSd d8z009Ev5zNebyI4TgVZARwrnIm7Ah1PXh/DiHtAZelEML3wNlgxJlL4s/blIhZBU= X-Google-Smtp-Source: AGHT+IHh3t7B+DErSADWFnngC4L7xOifKOSbR0RoznMag8AQeGs6aXGQopOd91sFWvBwE06ukxoHVg== X-Received: by 2002:a5d:5d03:0:b0:429:d391:642e with SMTP id ffacd0b85a97d-42b593742fdmr14365493f8f.30.1763459927103; Tue, 18 Nov 2025 01:58:47 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f206aasm31390623f8f.40.2025.11.18.01.58.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 01:58:46 -0800 (PST) Date: Tue, 18 Nov 2025 09:58:45 +0000 From: David Laight To: Josh Poimboeuf Cc: Alexandre Chartre , linux-kernel@vger.kernel.org, mingo@kernel.org, peterz@infradead.org Subject: Re: [PATCH v4 00/28] objtool: Function validation tracing Message-ID: <20251118095845.0878e759@pumpkin> In-Reply-To: References: <20251113164917.2563486-1-alexandre.chartre@oracle.com> <3367da83-16b7-4c6a-bd08-d14ec4067025@oracle.com> <20251117094210.3c3e4f40@pumpkin> <81693206-9002-4669-ab74-fda3d31c25bb@oracle.com> <20251117123729.72ffa3e2@pumpkin> <3673c975-dc51-47ea-940b-8f09afa213a5@oracle.com> <20251117220953.4f7bccc7@pumpkin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 17 Nov 2025 14:38:49 -0800 Josh Poimboeuf wrote: > On Mon, Nov 17, 2025 at 10:09:53PM +0000, David Laight wrote: > > On Mon, 17 Nov 2025 14:11:55 +0100 > > Alexandre Chartre wrote: > > > > > On 11/17/25 13:37, David Laight wrote: > > > > On Mon, 17 Nov 2025 10:47:06 +0100 > > > > Alexandre Chartre wrote: > > > > > > > >> On 11/17/25 10:42, David Laight wrote: > > > > ... > > > >>> Although I think there ought to be some indication of the 31 NOP bytes > > > >>> at the end of the middle alternative. > > I'm not sure we need that. It's already implied those gaps will be > filled with NOPs. This could add unnecessary visual clutter. But you need some idea of the size of the gap. A large gap isn't really a good idea and may mean it is better to refactor the code. While the execution time of nops might be zero, there is still the cost of fetching and decoding them. ... > > Do I remember something about the trailing nop being merged? > > Perhaps that is the kernel patching code. > > Something made me think objtool might (also) be doing it. > > Yes, IIRC, the alternatives code merges the small NOPs into bigger ones. That probably means it doesn't matter how objdump displays them. But perhaps it ought to output NOP*5 rather than NOP5 to make it clear it is a block of NOP (that will converted later) rather than a single NOP5 instruction. David