From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DDC535CBA9 for ; Tue, 18 Nov 2025 10:45:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763462743; cv=none; b=LAcpj4KQeTthfN6+egDgO6dDcHAvwVp4YabBW9OB1bBxJUVUHzIEtoLqyedU0B6vBkUdEymZhx81G26RdnDfVI1nxMicojuRQUQYYWjWIRjLW2/P9Q8GHcIyn+9df9l3gzzyA2LkcdLjDzBn+ha50ScWWg1FQL2VXkxPTCh/CE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763462743; c=relaxed/simple; bh=6zQvc8rQ6llvi2iD99NyN0wU6ZNJCXu/3B/nTH8u2/E=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=inX2yi0JFwRyZxsTHayB72TY7oDbESwM4dXVtPDxC9v9NvoR88hq4zz+VBpc0gmQtGqHMGATJGQFdng7Foyng8wU/EyfQRyYzdbV3j2RKbS6Td3PWy/GVqkzq1DwxB4M28dd7r51H3NxUJSolIqD+FrslMMj36w6qnqNSSpxNX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UdIJyjsg; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UdIJyjsg" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-477632d45c9so39260875e9.2 for ; Tue, 18 Nov 2025 02:45:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763462740; x=1764067540; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YSC0++zcwlAEFKF5FAa/y1OLBIMh6DxQaj6lBFEO748=; b=UdIJyjsgGy2+GP2iId/E/fwMZfFLxU4e7dqvR7e+5Mujnn4DNotZ0y9OkzgSgLt25L tXrIioY8e7DX1BcCqi8vHu6QfXBSWvI/6SMrTUfYgSebLvxQl9sSNxMfQuRGUWAsRZ16 gjotvypZeGzT9bVfWKp2GbwDKw8jdXaCXy13MktBQPH9GS8Pl7mOfgoiEioewOD8Yj/1 avUrKXfnaW3WIZTh86JH/iKm/yZebncnvhlhkkExr3OLfs8xPVSMi+lo87EEc+JA2c0A jPXwg/C7kxJIr2Rv7EPHmBla6V5Y6QlnnKRCNPqkyrqXtTswvzo/FmlhHzUDFUhdt9S7 RxCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763462740; x=1764067540; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YSC0++zcwlAEFKF5FAa/y1OLBIMh6DxQaj6lBFEO748=; b=JaqEBcjTayZI1EuXu7/5bat4hVhc9bi4MBKp7ouYlKQtuMzCqqaOne8XPnZUfa4xeG uzb/yZ4gry1B5QJWX4O7N7guGYbHUkzvT2BYATJC+K8AtZUliMcXQZzRJP5shueuR3Qh lQAkRouT8BTvonxb30Trej58zF4joqzCU+jBrsJhQcJVsrWe25eXN69ZcMihvm/XNw7i 08L20o/345rlaQinXX3KGC+NowATEJEW650M3D8qrGIx+TESQ5ov6kJ5hu8nHwtVGgzL tWtKlEMvNK0pJ3m3tzhufO16coIUSzhKris6TTzqz8i2nF+FmzPhpnap2LQCk0opuram rv0A== X-Forwarded-Encrypted: i=1; AJvYcCUyV+5yJLZWn6fXG4HGjQsy9jhWEo8jk2xfsYS2gIRg8ARG+Kzzy8d2lxOOcoKZqdXsPseoChJXaSNlLHU=@vger.kernel.org X-Gm-Message-State: AOJu0YyNPy7NAcOmzkbKSM8WIRsqjbSTGrKntb0aeU563vppuSazkQZN zPyKRPu7W8eeS9o1OR6DNcnrVKImnXULPhwVsgOcV+JG0j5QWiJcX1g5 X-Gm-Gg: ASbGncudGNeKClU/eijA8uNOeLTVLziLqFIv9OKJnB02SpVzZ0K1FIKzdsPnOCVUQkG wX05ldFWLqjFBybIe12knVH/fKeMO9rkR1pfVwDMhH1tb4tX61R4/Vw2zpPcg/BJ4Atjc3HZA/S dNlaREVWGN/qixR8aGyQnIIJOQD3lB6xWVYHI6My4ZFgU9VpceCCqppuc/7YrP0Fe8EHY0373eY QqS4CM/sFtDXMHpbjmz8HJZbfBTCWJ1/5Wbi42sGg5IOeUCqhnBbjfyK1ZW+7B7x1NBNY82j9DL gcemyOgnJFdJO4oY764Gg3jo9j+LhNLlWJAJj7NdoQQep0A61CZ/dZCIdGMxjtHHjmn5fPjTBfI OkH3vnuPWYF7p0hsbkEqMm6vN/aXLTxwPmQSDHKM0dCGAQ/NMODIkYIUFs6Xy7uznhJACJrpv1Y GbC+jgCZmeX31BFOITB8op4p6q3UqHoVIJ4VYmUNZWGNQN7UgI/SQPXDYaecbpGyg= X-Google-Smtp-Source: AGHT+IGts6ykTvFE1YIf5+/taVV8z+p5pVaBDGIqd212np4Jl9wdklMUecq1eWRr8hlVr7tWAtBx6Q== X-Received: by 2002:a05:600c:6385:b0:477:9814:6882 with SMTP id 5b1f17b1804b1-477981470c2mr118226955e9.5.1763462740092; Tue, 18 Nov 2025 02:45:40 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47787e35b7esm366739935e9.4.2025.11.18.02.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 02:45:39 -0800 (PST) Date: Tue, 18 Nov 2025 10:45:37 +0000 From: David Laight To: Sahil Chandna Cc: akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm/pagewalk: use min() macro instead of manual ternary Message-ID: <20251118104537.7ebf4422@pumpkin> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 18 Nov 2025 11:38:49 +0530 Sahil Chandna wrote: > mm: pagewalk: use min() macro instead of manual ternary expression > > Use the kernel-provided min() macro to compute the minimum value instead > of an explicit ternary expression. This improves readability and matches > common kernel style. > > This was flagged by Coccinelle > (misc/minmax.cocci) as an opportunity to use min(). > > Found by: make coccicheck MODE=report M=mm/ > No functional change intended. > > Signed-off-by: Sahil Chandna > --- > mm/pagewalk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/pagewalk.c b/mm/pagewalk.c > index 9f91cf85a5be..82db421b5b34 100644 > --- a/mm/pagewalk.c > +++ b/mm/pagewalk.c > @@ -313,7 +313,7 @@ static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr, > unsigned long end) > { > unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h); > - return boundary < end ? boundary : end; > + return min(boundary, end); You can remove the temporary: return min((addr & huge_page_mask(h)) + huge_page_size(h), end); David > } > > static int walk_hugetlb_range(unsigned long addr, unsigned long end,