From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCB4730EF74 for ; Tue, 18 Nov 2025 13:07:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763471230; cv=none; b=FprRUh1lxWKaucawIDimHF41mw/7q+bjPjGi0ib6ttL60FhRQaPpkGb/YweulbixjCvEc2LimG5eakPripL3zUD7hbdTlDbLL0wewCViceEqXcE75x9IVXUDNC06TFNssEeFbcIS9PMw4Ceo2EY2xmLTyVlteTl5tES9xoxoBFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763471230; c=relaxed/simple; bh=0K6UEvURiAEWar7kPyKJFAcajBtTOpZblSnfITdRYp4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JnkjIgVRZodWRfo7u8stNEHDMrrOyS6giSKfj3edNm1QrRCiYmkzqUHFROjJzQpVsvwz9pTTVyA0iaYu66reJObkifDUYp6dsS/1S4YaR5maoJGvzHGSyzSqn7sjzCU0uaXBfKd++yramB87KRszpYii/BUWHuhpOkoNNv9fjsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=KqthiE9M; arc=none smtp.client-ip=115.124.30.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="KqthiE9M" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1763471213; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=EnIDh0HJgKxwQb31liCsQP34D8Yjbk5hFoiHSWRZ7cE=; b=KqthiE9MTZVGNTg46Iplyq/WoH8AIsCySFRgHVoDZwWc4bQOv7U37FmtsqWiSg0noS29rRJzrCpRKsRieiO6oYLNwMc6vg5NDByWOt8g5vgXPKErkzzMGtRUMeGag5JVKPwy8zIU3CJaRzd2aZtDkigRfE3UMgfPwIfB/nkf1sA= Received: from DESKTOP-S9E58SO.localdomain(mailfrom:cp0613@linux.alibaba.com fp:SMTPD_---0WsjrMO0_1763471205 cluster:ay36) by smtp.aliyun-inc.com; Tue, 18 Nov 2025 21:06:52 +0800 From: cp0613@linux.alibaba.com To: pjw@kernel.org Cc: anup@brainfault.org, atish.patra@linux.dev, cp0613@linux.alibaba.com, guoren@kernel.org, haibo1.xu@intel.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH] tools: riscv: Fixed misalignment of CSR related definitions Date: Tue, 18 Nov 2025 21:06:44 +0800 Message-ID: <20251118130644.468-1-cp0613@linux.alibaba.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <421f4746-8d75-227b-6459-bbd82dfd6fa9@kernel.org> References: <421f4746-8d75-227b-6459-bbd82dfd6fa9@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, 16 Nov 2025 10:22:34 -0700, pjw@kernel.org: > > The file tools/arch/riscv/include/asm/csr.h borrows from > > arch/riscv/include/asm/csr.h, and subsequent modifications > > related to CSR should maintain consistency. > > Thanks for the patch. A few comments: > > > Fixes: 16b0bde9a37c ("RISC-V: KVM: Add perf sampling support for guests") > > Fixes: d1927f64e0e1 ("RISC-V: Fix the typo in Scountovf CSR name") > > It seems like this is pushing the definition of "fixes" here. It looks > like the only thing wrong with those patches is that they didn't change > the files under tools/. right? It would have been nice if they had > included the changes to files under tools/, but since the patches don't > introduce any bugs directly, I don't think we should include these Fixes: > lines here. > Yes, that's true, thanks for reminding me. > > > > Signed-off-by: Chen Pei > > Please, no blank line between the Fixes: headers and the Signed-off-by:. > > I've removed the Fixes: lines and the superfluous blank line, and queued > this for v6.18-rc fixes. > Thank you for your help. > > - Paul Thanks, Pei