From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C5DA363C40 for ; Tue, 18 Nov 2025 14:58:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763477898; cv=none; b=c8c0EjX4bP/u3p1rA0BH0D2BqzMfjj1ycAPa9+TVfvz/Ad2hzNwnoF+L/OT//TGwNVUg7OanZvoGlna7XrXmnO/1cUYBiVx4IVAJWeuDlAeLv1tUaTMtAb2F2QaAKeNVsB5Kh96BmVI381+LqrwB8x4jexTYYhjiTXbgW8t+zEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763477898; c=relaxed/simple; bh=DPfztGpTpKeZwjuO3Y+4RpBkmoIsNivSOXSgBqsyN+0=; h=Date:In-Reply-To:Mime-Version:Message-ID:Subject:From:To:Cc: Content-Type; b=LPAxwS4LNdTk7wPNYQ3yLGOBYaa4E3ad7DipMtbRMmLqvJ38cYR+3+AcbnUvomANq02+jb2tHDmk3JCso8nq+EJW2Fj14q5nHBJGHSOCXq+rqFg0NUdGSE70mRQEEzOMh3G+7lx+h6N1dJQ9p+FVj9lUX8cR3caNdA95eQo8AZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--gprocida.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=XQEC+Wz8; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--gprocida.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="XQEC+Wz8" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4775d8428e8so62171355e9.0 for ; Tue, 18 Nov 2025 06:58:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763477895; x=1764082695; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=DPfztGpTpKeZwjuO3Y+4RpBkmoIsNivSOXSgBqsyN+0=; b=XQEC+Wz8UIXoObeaMiJGlUUUvDcb4FseZK2UuMU8au9M843kYGS99h2eHb9yefkI+P wEE6MVpKzjYgFqcMpCcfoiiyNYerIEo0Y1TRup9+CVafJC68DgHSprzpjf0NjRyXW8jB r2GZdJU3mrSdmtg4JhcZ3QUNo3FvqoCxo3cr26bkKbMNos2SuJW67yIH6CfTXC5lv3fS 86LRppOz2ExLpinT25jF7jshe6nQD7d018Vy394BS7/xOt5h6WwoNEkltX/ROiCcEFAg fo7BwCW370UituEtDTfejknVT9BzC4Jls4stUCZ2O3xfUzyo70A7rzcmtaCXAmSYLUru wT0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763477895; x=1764082695; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DPfztGpTpKeZwjuO3Y+4RpBkmoIsNivSOXSgBqsyN+0=; b=vViea4qqhZ9N8WORQTZ6dGJWyVSIxiSxw+XWiAHTLWRpz4Rk5MC5Uk0VS879SxaMuo 5PE4RIq+Rke9JLek3o46NXaY1zsFHmY5LhBz4SYfIUhbcYa9MUgQ59zRdcnl+wvGoD3H r05TF5JzI1IeO5ER2rX+Ia+LOelq1zC2ymzO4aPW/N/kpOt9zeiTZaTKy9BiQrXbgvxV cWkGK3D6u6fmGklbRkn7xXKM40GsvstCofbCyy7GofrkxOy2eABnIBvTySUctwkiKdBT M+DcKV929B9h5HZuqMrTdGMkI0uu7jm0vyt8dvaC88YjlxiHD54w/K2gswGEbR7nHrnc JOlA== X-Forwarded-Encrypted: i=1; AJvYcCVNxeI2I6zoJkq+Wz96h3Hw40T5sc9haoDbt+qHLrjBTGhW8NRNVb9frPGoFA3eua/TG1VK1OF+GLvWVC8=@vger.kernel.org X-Gm-Message-State: AOJu0YxPzCMJOj4XRK6dk78KWecHRT5rsnhI8NS3boPOc36nu4E5Mcna ssZrCYtVkG3h6iH3RDyqawFwXgdP7qBuZygVd5k8VtkqkQTeOfwg/AJ4e0P9q+3ePtw1+WN7w21 OPV6wL/7S8RBNrA== X-Google-Smtp-Source: AGHT+IF5IuKqsfo4fGvtEqK6+inM6Wme3e1NzVR1nM/R1oTA+LPa6JsLnhIYst5T5QUx9HKDMNad3Q0W0SjPeQ== X-Received: from wmpl35.prod.google.com ([2002:a05:600c:8a3:b0:475:d8de:fe5b]) (user=gprocida job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:a07:b0:46f:c55a:5a8d with SMTP id 5b1f17b1804b1-4778fe55101mr148495515e9.4.1763477894678; Tue, 18 Nov 2025 06:58:14 -0800 (PST) Date: Tue, 18 Nov 2025 14:57:36 +0000 In-Reply-To: <20251110131913.1789896-1-ojeda@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.rc1.455.g30608eb744-goog Message-ID: <20251118145741.1042013-1-gprocida@google.com> Subject: Re: [PATCH v2] gendwarfksyms: Skip files with no exports From: Giuliano Procida To: Miguel Ojeda Cc: Sami Tolvanen , Alex Gaynor , linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org, Boqun Feng , Gary Guo , "=?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?=" , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, stable@vger.kernel.org, Haiyue Wang Content-Type: text/plain; charset="UTF-8" Hi. > Thus do the last one: don't attempt to process files if we have no symbol > versions to calculate. This results in the -T foo option being ignored in the case there were no symbols. I think it would be better, consistent with the documentation and expectations, for the file to be produced empty. This means that just the for loop should be skipped, say by adding the condition there with &&. If you disagree, then please update the documentation to match the new behaviour. Regards, Giuliano.