From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2E0E26CE2D for ; Tue, 18 Nov 2025 16:56:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763484975; cv=none; b=pR5mq59D91oWDLaH3+jwrEq7bu5lyzRfncpuF4mENgt2DPAS25qfNCCHfT0peWujo2BQHJsFDnggQPcKm/oWQa4mJEex/A4Wg6aIblwmhHAkhQZy9mxZZIPfsw4Cq9uADaqHFjnEXgP48VHXf9NWARPRX4BvgQXRJpK47tImmok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763484975; c=relaxed/simple; bh=MAyH1PZXcJslZygZ68oIDHrwPXXSfhgcW2ReroRPOlw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Fm14Uo3Qc2oNJM7nCA/HFA2yJEaggXYkBgdyFYdPy8JTbWckgvzQZADLGx+RsUiHn/DCYEbVITOrzY26v5U1R4LXcU1jmq3MrhLC+1CHMTdhUMespCovjNv2aY7lv4kdUExyzkfiFvDteBSAbzhY4TZq9E/vDO7redlm1W0tBXc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DrAcibjH; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DrAcibjH" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4775ae5684fso29636325e9.1 for ; Tue, 18 Nov 2025 08:56:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763484972; x=1764089772; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=qnZHl6EdkZmdNegwl3qorciCL3OsPRajekD+9uhu3UM=; b=DrAcibjHXyySsh/+sLPi+Mu9qf2eeJKxOHPR0BD2jIIvvfMyxzhZNpvxCQlEcCbi6z uFTTxMFZXib2gXU2yt2JD/zwTCYO+zFsSSx7+Rlf5aPBVZC5YRjY/XArmy0gBBcbITDJ 0U3SA2l8TLo00KPGJzQRHs+yjYaJFE4lSPxJI11VdSs5EFFNl74KaVz4N1YWBs+yrnbh Crf7HWrgZSZse9GD0xRwgZJ/1dQSwV3uxWJCQMgdOlOuEWran2o0xNIn1wVa8yZDFTn4 n4IWCOKktC5/8YhBRzkxFnYTS4bPKvI5ZT/bR1M16HU7fHfjjtnLdGea/HgzJUoFVqjd 0AyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763484972; x=1764089772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qnZHl6EdkZmdNegwl3qorciCL3OsPRajekD+9uhu3UM=; b=sBXo1EF4ITeX3NQK6Ln6ibpQGbvvLbvNPZGe8XhYzDYt8SmftIjo9gsJ1SBwCoEsD1 kuzBBN58U0B+8mbcI9yfO0r/TK0R12YnhpV5w7hS0g7PCbUhMIm8zjYf2a3PJqyWQu7S UqqwxRl7S6F2Z6pQRCZjQQ7eLpzpdbV55RsNtn3j3X5WTH1BLJvpP+32/qpARHg5nYHZ RZL7UoSDipvJ61/n5Kh2w0XTTQ7oi/VaEnrNYHkb5StJc+SxCzNBPKRByfjWzhyeI+FE Vzcj3w7J+PptOY74/ouoHyRheKW+rD/Kw7TQd5N7kDRHt130yhOpFOmjGSk+SsZfDjuL yK1g== X-Forwarded-Encrypted: i=1; AJvYcCVVgP1eqggWxa1VyYDQKaQbbVTtPN2IH/EHILzOZiLnWhkukTt3XODucfmXKNECVZL4uUxWGHHiHrLYarQ=@vger.kernel.org X-Gm-Message-State: AOJu0YycfdPV13vquKn+VABZZyzn5VsBFBJU/33hqoQo6epwuXs8ism1 k4a4lM85NCglzAHAuJQXZt9zEy1be20b/tlMxTtd0WZ9JyVezRRLPg2Z X-Gm-Gg: ASbGncs9NMRdQz2wzSZi2etzvs7BffmiUZOJG3FGkQX7IIW3MErxmzJapMEOrNovpSL cnGEqTOoUdo0BZx/P1RHm7KHlr/JSaP3zsr51FDsr52gKCEUY2BkfV99ozyxpith+AFKLZs631i +ZTKFr81vv1PxiMUw0zvprnsIZbiqTZyC9c8NthFtmYYUofkbwAWlwB8SuMmt6G3bij8E4lwWxT ZgMXZcrGgaPtyy7eGty+Evn997xyWHYy4mek6o8uPB4pylOrx8QhchKkc2VYP3d785U16Ik1y1R 1SqUrB4Rs/qY/pd/ZmNDUGwh/x+2WJwaplZ9mJHfa24ZNs+/Qdti1zjMO7p2cyIoAu7PWZsp8jF soRD0sRDqlOKSAsuiHTBT2R1s/tW9yGZVmUxy2yrOVZ5WiOv0kJK8xhFULeC58eQqBnzKruz6yr /+dAtI6WPWA18FvB3UzMvuX8mtpXxtbKpO9pX5XK4xktYfhfJRXACsPB1f20Z999Q= X-Google-Smtp-Source: AGHT+IG7RLyD5r17W4B9aNcEk/dLQDIBHTizsXKOqwUqzCyMHcM5ArtxErg5wUnqaERmxMbOekTLsw== X-Received: by 2002:a05:600c:301:b0:477:9650:3175 with SMTP id 5b1f17b1804b1-4779650335dmr97097495e9.0.1763484971559; Tue, 18 Nov 2025 08:56:11 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f17291sm33150084f8f.32.2025.11.18.08.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 08:56:11 -0800 (PST) Date: Tue, 18 Nov 2025 16:56:09 +0000 From: David Laight To: Matthew Wilcox Cc: Sahil Chandna , akpm@linux-foundation.org, david@redhat.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, zhengqi.arch@bytedance.com, Liam.Howlett@oracle.com, weixugc@google.com, axelrasmussen@google.com, yuanchu@google.com, yosry.ahmed@linux.dev, nphamcs@gmail.com, chengming.zhou@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm/pagewalk: use min() macro instead of manual ternary Message-ID: <20251118165609.16c09e74@pumpkin> In-Reply-To: References: <20251118104537.7ebf4422@pumpkin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 18 Nov 2025 15:18:50 +0000 Matthew Wilcox wrote: > On Tue, Nov 18, 2025 at 10:45:37AM +0000, David Laight wrote: > > On Tue, 18 Nov 2025 11:38:49 +0530 > > Sahil Chandna wrote: > > > +++ b/mm/pagewalk.c > > > @@ -313,7 +313,7 @@ static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr, > > > unsigned long end) > > > { > > > unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h); > > > - return boundary < end ? boundary : end; > > > + return min(boundary, end); > > > > You can remove the temporary: > > return min((addr & huge_page_mask(h)) + huge_page_size(h), end); > > You can, but I'm not sure that's better. What would be better is: > > unsigned long boundary = (addr | ~huge_page_mask(h)) + 1; > return min(boundary, end); > > if you insist, we could do: > > return min((addr | ~huge_page_mask(h)) + 1, end); Indeed... David