From: "Rob Herring (Arm)" <robh@kernel.org>
To: Lee Jones <lee@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexander Kurz <akurz@blala.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] dt-bindings: mfd: fsl,mc13xxx: Fix leds node schema
Date: Tue, 18 Nov 2025 15:35:40 -0600 [thread overview]
Message-ID: <20251118213541.43812-1-robh@kernel.org> (raw)
The 'leds' node is missing constraints on additional properties. It is
mixing 'leds' node and child node properties as well as missing some
properties. Add the 'led@' child nodes and the missing properties.
Fixes: 1160f9f88be2 ("dt-bindings: mfd: fsl,mc13xxx: Convert txt to DT schema")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../devicetree/bindings/mfd/fsl,mc13xxx.yaml | 74 +++++++++++--------
1 file changed, 43 insertions(+), 31 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml b/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
index d2886f2686a8..cfa69f1f380a 100644
--- a/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
+++ b/Documentation/devicetree/bindings/mfd/fsl,mc13xxx.yaml
@@ -93,38 +93,14 @@ properties:
leds:
type: object
- $ref: /schemas/leds/common.yaml#
+ additionalProperties: false
properties:
- reg:
- description: |
- One of
- MC13783 LED IDs
- 0: Main display
- 1: AUX display
- 2: Keypad
- 3: Red 1
- 4: Green 1
- 5: Blue 1
- 6: Red 2
- 7: Green 2
- 8: Blue 2
- 9: Red 3
- 10: Green 3
- 11: Blue 3
-
- MC13892 LED IDs
- 0: Main display
- 1: AUX display
- 2: Keypad
- 3: Red
- 4: Green
- 5: Blue
-
- MC34708 LED IDs
- 0: Charger Red
- 1: Charger Green
- maxItems: 1
+ '#address-cells':
+ const: 1
+
+ '#size-cells':
+ const: 0
led-control:
$ref: /schemas/types.yaml#/definitions/uint32-array
@@ -132,6 +108,42 @@ properties:
Setting for LED-Control register array length depends on model,
mc13783: 6, mc13892: 4, mc34708: 1
+ patternProperties:
+ '^led@[0-9a-b]$':
+ $ref: /schemas/leds/common.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ reg:
+ description: |
+ One of
+ MC13783 LED IDs
+ 0: Main display
+ 1: AUX display
+ 2: Keypad
+ 3: Red 1
+ 4: Green 1
+ 5: Blue 1
+ 6: Red 2
+ 7: Green 2
+ 8: Blue 2
+ 9: Red 3
+ 10: Green 3
+ 11: Blue 3
+
+ MC13892 LED IDs
+ 0: Main display
+ 1: AUX display
+ 2: Keypad
+ 3: Red
+ 4: Green
+ 5: Blue
+
+ MC34708 LED IDs
+ 0: Charger Red
+ 1: Charger Green
+ maxItems: 1
+
regulators:
type: object
@@ -262,7 +274,7 @@ examples:
#size-cells = <0>;
led-control = <0x000 0x000 0x0e0 0x000>;
- sysled@3 {
+ led@3 {
reg = <3>;
label = "system:red:live";
linux,default-trigger = "heartbeat";
--
2.51.0
next reply other threads:[~2025-11-18 21:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 21:35 Rob Herring (Arm) [this message]
2025-11-20 14:52 ` (subset) [PATCH] dt-bindings: mfd: fsl,mc13xxx: Fix leds node schema Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118213541.43812-1-robh@kernel.org \
--to=robh@kernel.org \
--cc=akurz@blala.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox